diff options
| author | dkf <donal.k.fellows@manchester.ac.uk> | 2001-01-12 09:54:16 (GMT) |
|---|---|---|
| committer | dkf <donal.k.fellows@manchester.ac.uk> | 2001-01-12 09:54:16 (GMT) |
| commit | 131bb85d732222882579df7f1cd45bfba4dda989 (patch) | |
| tree | 3b1b5a338b67f6f0308d3e335eb7acb12fdc0f3e | |
| parent | 82208ae074ac93ecebefb924402d1dc992a72432 (diff) | |
| download | tcl-131bb85d732222882579df7f1cd45bfba4dda989.zip tcl-131bb85d732222882579df7f1cd45bfba4dda989.tar.gz tcl-131bb85d732222882579df7f1cd45bfba4dda989.tar.bz2 | |
Fixes tests when spaces exist in install pathnames.
(Applies patch #103174 which fixes bug #119406.)
| -rw-r--r-- | ChangeLog | 9 | ||||
| -rw-r--r-- | tests/pkgMkIndex.test | 4 | ||||
| -rw-r--r-- | tests/winDde.test | 4 | ||||
| -rw-r--r-- | tests/winPipe.test | 4 |
4 files changed, 15 insertions, 6 deletions
@@ -1,3 +1,12 @@ +2001-01-10 Donal K. Fellows <fellowsd@cs.man.ac.uk> + + * tests/winPipe.test (winpipe-1.20): + * tests/winDde.test (createChildProcess): + * tests/pkgMkIndex.test (pkgtest::createIndex): Removed + assumption that paths contain no spaces which causes problems with + both [eval] and [open |...] due to the well-known differences + between lists and strings. Fixes bug #119406 + 2001-01-04 Don Porter <dgp@users.sourceforge.net> * tests/unixInit.test: * unix/tclUnixInit.c (TclpInitLibraryPath): diff --git a/tests/pkgMkIndex.test b/tests/pkgMkIndex.test index af0d5c6..76476f0 100644 --- a/tests/pkgMkIndex.test +++ b/tests/pkgMkIndex.test @@ -8,7 +8,7 @@ # Copyright (c) 1998-1999 by Scriptics Corporation. # All rights reserved. # -# RCS: @(#) $Id: pkgMkIndex.test,v 1.17 2000/07/19 21:40:57 ericm Exp $ +# RCS: @(#) $Id: pkgMkIndex.test,v 1.18 2001/01/12 09:54:16 dkf Exp $ if {[lsearch [namespace children] ::tcltest] == -1} { package require tcltest @@ -165,7 +165,7 @@ proc pkgtest::createIndex { args } { if {[catch { file delete [file join $dirPath pkgIndex.tcl] - eval pkg_mkIndex $options $dirPath $patternList + eval pkg_mkIndex $options [list $dirPath] $patternList } err]} { return [list 1 $err] } diff --git a/tests/winDde.test b/tests/winDde.test index 7a8bb01..90c51ed 100644 --- a/tests/winDde.test +++ b/tests/winDde.test @@ -9,7 +9,7 @@ # See the file "license.terms" for information on usage and redistribution # of this file, and for a DISCLAIMER OF ALL WARRANTIES. # -# RCS: @(#) $Id: winDde.test,v 1.8 2000/04/10 17:19:06 ericm Exp $ +# RCS: @(#) $Id: winDde.test,v 1.9 2001/01/12 09:54:17 dkf Exp $ if {[lsearch [namespace children] ::tcltest] == -1} { package require tcltest @@ -56,7 +56,7 @@ proc createChildProcess { ddeServerName } { } close $f - set f [open "|$tcltest::tcltest $::scriptName" r] + set f [open |[list $tcltest::tcltest $::scriptName] r] gets $f return $f } diff --git a/tests/winPipe.test b/tests/winPipe.test index 8cfda55..a108733 100644 --- a/tests/winPipe.test +++ b/tests/winPipe.test @@ -12,7 +12,7 @@ # See the file "license.terms" for information on usage and redistribution # of this file, and for a DISCLAIMER OF ALL WARRANTIES. # -# RCS: @(#) $Id: winPipe.test,v 1.12 2000/04/10 17:19:06 ericm Exp $ +# RCS: @(#) $Id: winPipe.test,v 1.13 2001/01/12 09:54:17 dkf Exp $ if {[lsearch [namespace children] ::tcltest] == -1} { package require tcltest @@ -156,7 +156,7 @@ test winpipe-1.19 {32 bit comprehensive tests: to file handle} {pcOnly stdio cat } {little stderr32} test winpipe-1.20 {32 bit comprehensive tests: write to application} \ {pcOnly stdio cat32} { - set f [open "|$cat32 > stdout" w] + set f [open |[list $cat32 >stdout] w] puts -nonewline $f "foo" catch {close $f} msg list [contents stdout] $msg |