summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authordgp <dgp@users.sourceforge.net>2008-12-03 07:08:44 (GMT)
committerdgp <dgp@users.sourceforge.net>2008-12-03 07:08:44 (GMT)
commit6098a1e4066549ea5b34b4d51586fe5182111487 (patch)
tree376c7e72209b44ee58c200a22b49d3c493c93a19
parent45d2e7298dcad1a8d3c598fef8a2446d3a77310b (diff)
downloadtcl-6098a1e4066549ea5b34b4d51586fe5182111487.zip
tcl-6098a1e4066549ea5b34b4d51586fe5182111487.tar.gz
tcl-6098a1e4066549ea5b34b4d51586fe5182111487.tar.bz2
* generic/tclFileName.c (DoGlob): One of the
Tcl_FSMatchInDirectory() calls did not have its return code checked. This caused error messages returned by some Tcl_Filesystem drivers to be swallowed.
-rw-r--r--ChangeLog7
-rw-r--r--generic/tclFileName.c7
2 files changed, 11 insertions, 3 deletions
diff --git a/ChangeLog b/ChangeLog
index 5d6d1ec..0b4f6cb 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2008-12-03 Don Porter <dgp@users.sourceforge.net>
+
+ * generic/tclFileName.c (DoGlob): One of the
+ Tcl_FSMatchInDirectory() calls did not have its return code checked.
+ This caused error messages returned by some Tcl_Filesystem drivers
+ to be swallowed.
+
2008-12-02 Don Porter <dgp@users.sourceforge.net>
TIP #336 IMPLEMENTATION
diff --git a/generic/tclFileName.c b/generic/tclFileName.c
index cca1a9b..2d62414 100644
--- a/generic/tclFileName.c
+++ b/generic/tclFileName.c
@@ -10,7 +10,7 @@
* See the file "license.terms" for information on usage and redistribution of
* this file, and for a DISCLAIMER OF ALL WARRANTIES.
*
- * RCS: @(#) $Id: tclFileName.c,v 1.94 2008/10/16 22:34:19 nijtmans Exp $
+ * RCS: @(#) $Id: tclFileName.c,v 1.95 2008/12/03 07:08:44 dgp Exp $
*/
#include "tclInt.h"
@@ -2464,9 +2464,10 @@ DoGlob(
}
Tcl_IncrRefCount(joinedPtr);
Tcl_DStringFree(&append);
- Tcl_FSMatchInDirectory(interp, matchesObj, joinedPtr, NULL, types);
+ result = Tcl_FSMatchInDirectory(interp, matchesObj, joinedPtr, NULL,
+ types);
Tcl_DecrRefCount(joinedPtr);
- return TCL_OK;
+ return result;
}
/*