* generic/tclIOUtil.c (TclGetOpenMode): Added the flag O_APPEND to

	  the list of POSIX modes used when opening a file for
	  'a'ppend. This enables the proper automatic seek-to-end-on-write
	  by the OS. See [Bug 680143] for longer discussion.

	* tests/ioCmd.test (iocmd-13.7.*): Extended the testsuite to check
	  the new handling of 'a'.

3 files changed, 54 insertions, 3 deletions

diff --git a/ChangeLog b/ChangeLog
index f59888f..ca4b1fa 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,13 @@
+2006-03-16  Andreas Kupries <andreask@activestate.com>
+
+	* generic/tclIOUtil.c (TclGetOpenMode): Added the flag O_APPEND to
+	  the list of POSIX modes used when opening a file for
+	  'a'ppend. This enables the proper automatic seek-to-end-on-write
+	  by the OS. See [Bug 680143] for longer discussion.
+
+	* tests/ioCmd.test (iocmd-13.7.*): Extended the testsuite to check
+	  the new handling of 'a'.
+
 2006-03-15  Andreas Kupries <andreask@activestate.com>
 
 	* tests/socket.test: Extended the timeout in socket-11.11 from 10
diff --git a/generic/tclIOUtil.c b/generic/tclIOUtil.c
index 84c9161..99240e4 100644
--- a/generic/tclIOUtil.c
+++ b/generic/tclIOUtil.c
@@ -17,7 +17,7 @@
  * See the file "license.terms" for information on usage and redistribution
  * of this file, and for a DISCLAIMER OF ALL WARRANTIES.
  *
- * RCS: @(#) $Id: tclIOUtil.c,v 1.77.2.26 2006/02/15 16:04:29 dgp Exp $
+ * RCS: @(#) $Id: tclIOUtil.c,v 1.77.2.27 2006/03/16 18:23:22 andreas_kupries Exp $
  */
 
 #include "tclInt.h"
@@ -1567,7 +1567,11 @@ TclGetOpenMode(interp, string, seekFlagPtr)
 		mode = O_WRONLY|O_CREAT|O_TRUNC;
 		break;
 	    case 'a':
-		mode = O_WRONLY|O_CREAT;
+	        /* [Bug 680143].
+		 * Added O_APPEND for proper automatic
+		 * seek-to-end-on-write by the OS.
+		 */
+	        mode = O_WRONLY|O_CREAT|O_APPEND;
                 *seekFlagPtr = 1;
 		break;
 	    default:
diff --git a/tests/ioCmd.test b/tests/ioCmd.test
index 448b222..29ddba7 100644
--- a/tests/ioCmd.test
+++ b/tests/ioCmd.test
@@ -1,3 +1,4 @@
+# -*- tcl -*-
 # Commands covered: open, close, gets, read, puts, seek, tell, eof, flush,
 #		    fblocked, fconfigure, open, channel, fcopy
 #
@@ -12,7 +13,7 @@
 # See the file "license.terms" for information on usage and redistribution
 # of this file, and for a DISCLAIMER OF ALL WARRANTIES.
 #
-# RCS: @(#) $Id: ioCmd.test,v 1.16.2.2 2003/10/07 18:53:23 dgp Exp $
+# RCS: @(#) $Id: ioCmd.test,v 1.16.2.3 2006/03/16 18:23:24 andreas_kupries Exp $
 
 if {[lsearch [namespace children] ::tcltest] == -1} {
     package require tcltest
@@ -459,6 +460,42 @@ test iocmd-13.6 {errors in open command} {
 	string tolower $msg
 } {1 {couldn't open "_non_existent_": no such file or directory} {posix enoent {no such file or directory}}}
 
+
+test iocmd-13.7.1 {open for append, a mode} -setup {
+    set log   [makeFile {} out]
+    set chans {}
+} -body {
+    foreach i { 0 1 2 3 4 5 6 7 8 9 } {
+	puts [set ch [open $log a]] $i
+	lappend chans $ch
+    }
+    foreach ch $chans {catch {close $ch}}
+    lsort [split [string trim [viewFile out]] \n]
+} -cleanup {
+    removeFile out
+    # Ensure that channels are gone, even if body failed to do so
+    foreach ch $chans {catch {close $ch}}
+} -result {0 1 2 3 4 5 6 7 8 9}
+
+test iocmd-13.7.2 {open for append, O_APPEND} -setup {
+    set log   [makeFile {} out]
+    set chans {}
+} -body {
+    foreach i { 0 1 2 3 4 5 6 7 8 9 } {
+	puts [set ch [open $log {WRONLY CREAT APPEND}]] $i
+	lappend chans $ch
+    }
+    foreach ch $chans {catch {close $ch}}
+    lsort [split [string trim [viewFile out]] \n]
+} -cleanup {
+    removeFile out
+    # Ensure that channels are gone, even if body failed to do so
+    foreach ch $chans {catch {close $ch}}
+} -result {0 1 2 3 4 5 6 7 8 9}
+
+
+
+
 test iocmd-14.1 {file id parsing errors} {
     list [catch {eof gorp} msg] $msg $errorCode
 } {1 {can not find channel named "gorp"} NONE}