summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authordgp <dgp@users.sourceforge.net>2014-11-06 15:49:30 (GMT)
committerdgp <dgp@users.sourceforge.net>2014-11-06 15:49:30 (GMT)
commit4ec8e3c11c2a7fdc1fd9efce21a8e6d92ce8a0e5 (patch)
tree80fe8530ae6f736615821a2db7450308467c9fe4
parenta8c6a73058b823dbb1ea5e3832d016284820400e (diff)
downloadtcl-4ec8e3c11c2a7fdc1fd9efce21a8e6d92ce8a0e5.zip
tcl-4ec8e3c11c2a7fdc1fd9efce21a8e6d92ce8a0e5.tar.gz
tcl-4ec8e3c11c2a7fdc1fd9efce21a8e6d92ce8a0e5.tar.bz2
fix failing test
-rw-r--r--generic/tclIOGT.c15
1 files changed, 11 insertions, 4 deletions
diff --git a/generic/tclIOGT.c b/generic/tclIOGT.c
index a78a5b4..7ba2f2a 100644
--- a/generic/tclIOGT.c
+++ b/generic/tclIOGT.c
@@ -187,6 +187,7 @@ struct TransformChannelData {
Tcl_Channel self; /* Our own Channel handle. */
int readIsFlushed; /* Flag to note whether in.flushProc was
* called or not. */
+ int eofPending; /* Flag: EOF seen down, not raised up */
int flags; /* Currently CHANNEL_ASYNC or zero. */
int watchMask; /* Current watch/event/interest mask. */
int mode; /* Mode of parent channel, OR'ed combination
@@ -292,6 +293,7 @@ TclChannelTransform(
Tcl_DStringInit(&ds);
Tcl_GetChannelOption(interp, chan, "-blocking", &ds);
dataPtr->readIsFlushed = 0;
+ dataPtr->eofPending = 0;
dataPtr->flags = 0;
if (ds.string[0] == '0') {
dataPtr->flags |= CHANNEL_ASYNC;
@@ -624,7 +626,7 @@ TransformInputProc(
if (toRead == 0 || dataPtr->self == NULL) {
/*
- * Catch a no-op.
+ * Catch a no-op. TODO: Is this a panic()?
*/
return 0;
}
@@ -676,8 +678,7 @@ TransformInputProc(
if (toRead <= 0) {
break;
}
-
- if (dataPtr->readIsFlushed) {
+ if (dataPtr->eofPending) {
/*
* Already saw EOF from downChan; don't ask again.
* NOTE: Could move this up to avoid the last maxRead
@@ -724,6 +725,7 @@ TransformInputProc(
* on the down channel.
*/
+ dataPtr->eofPending = 1;
dataPtr->readIsFlushed = 1;
ExecuteCallback(dataPtr, NULL, A_FLUSH_READ, NULL, 0,
TRANSMIT_IBUF, P_PRESERVE);
@@ -751,8 +753,11 @@ TransformInputProc(
break;
}
} /* while toRead > 0 */
- ReleaseData(dataPtr);
+ if (gotBytes == 0) {
+ dataPtr->eofPending = 0;
+ }
+ ReleaseData(dataPtr);
return gotBytes;
}
@@ -863,6 +868,7 @@ TransformSeekProc(
P_NO_PRESERVE);
ResultClear(&dataPtr->result);
dataPtr->readIsFlushed = 0;
+ dataPtr->eofPending = 0;
}
ReleaseData(dataPtr);
@@ -936,6 +942,7 @@ TransformWideSeekProc(
P_NO_PRESERVE);
ResultClear(&dataPtr->result);
dataPtr->readIsFlushed = 0;
+ dataPtr->eofPending = 0;
}
ReleaseData(dataPtr);