summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorpatthoyts <patthoyts@users.sourceforge.net>2009-11-07 09:24:22 (GMT)
committerpatthoyts <patthoyts@users.sourceforge.net>2009-11-07 09:24:22 (GMT)
commitf9939610df42a3d9d20c0fb54082804b6488c8f1 (patch)
treec51f583bb19fcc6b0895ee77119d835445c8d888
parent7b628883ba94899516793d2f04aa7879fc264793 (diff)
downloadtcl-f9939610df42a3d9d20c0fb54082804b6488c8f1.zip
tcl-f9939610df42a3d9d20c0fb54082804b6488c8f1.tar.gz
tcl-f9939610df42a3d9d20c0fb54082804b6488c8f1.tar.bz2
[Bug 2891026] add addtional contraints for vista+ for non-readable directories
-rw-r--r--ChangeLog6
-rw-r--r--tests/fCmd.test35
2 files changed, 32 insertions, 9 deletions
diff --git a/ChangeLog b/ChangeLog
index 5dd91df..4691bc3 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2009-11-07 Pat Thoyts <patthoyts@users.sourceforge.net>
+
+ * tests/fCmd.test: [Bug 2891026] Exclude tests using chmod 555
+ directories on vista and win7. The current user has access denied
+ and so cannot rename the directory without admin privileges.
+
2009-11-06 Andreas Kupries <andreask@activestate.com>
* library/safe.tcl (::safe::Setup): Added documentation of the
diff --git a/tests/fCmd.test b/tests/fCmd.test
index 78be937..53360b3 100644
--- a/tests/fCmd.test
+++ b/tests/fCmd.test
@@ -10,7 +10,7 @@
# See the file "license.terms" for information on usage and redistribution of
# this file, and for a DISCLAIMER OF ALL WARRANTIES.
#
-# RCS: @(#) $Id: fCmd.test,v 1.65 2008/09/24 19:31:40 dgp Exp $
+# RCS: @(#) $Id: fCmd.test,v 1.66 2009/11/07 09:24:22 patthoyts Exp $
#
if {[lsearch [namespace children] ::tcltest] == -1} {
@@ -20,6 +20,9 @@ if {[lsearch [namespace children] ::tcltest] == -1} {
testConstraint testsetplatform [llength [info commands testsetplatform]]
testConstraint testchmod [llength [info commands testchmod]]
+testConstraint winVista 0
+testConstraint win2000orXP 0
+testConstraint winOlderThan2000 0
# Don't know how to determine this constraint correctly
testConstraint notNetworkFilesystem 0
testConstraint 95or98 [expr {[testConstraint 95] || [testConstraint 98]}]
@@ -37,6 +40,20 @@ if {[testConstraint unix]} {
}
}
+# Also used in winFCmd...
+if {[testConstraint winOnly]} {
+ set major [string index $tcl_platform(osVersion) 0]
+ if {[testConstraint nt] && $major > 4} {
+ if {$major > 5} {
+ testConstraint winVista 1
+ } elseif {$major == 5} {
+ testConstraint win2000orXP 1
+ }
+ } else {
+ testConstraint winOlderThan2000 1
+ }
+}
+
testConstraint darwin9 [expr {[testConstraint unix] &&
$tcl_platform(os) eq "Darwin" &&
int([string range $tcl_platform(osVersion) 0 \
@@ -384,7 +401,7 @@ test fCmd-5.4 {TclFileDeleteCmd: multiple files} -constraints notRoot -setup {
set x [list [file exists tf1] [file exists tf2] [file exists td1]]
file delete tf1 td1 tf2
lappend x [file exists tf1] [file exists tf2] [file exists tf3]
-} -result {1 1 1 0 0 0}
+} -cleanup {cleanup} -result {1 1 1 0 0 0}
test fCmd-5.5 {TclFileDeleteCmd: stop at first error} -setup {
cleanup
} -constraints {notRoot unixOrPc} -body {
@@ -393,7 +410,7 @@ test fCmd-5.5 {TclFileDeleteCmd: stop at first error} -setup {
file mkdir td1
catch {file delete tf1 td1 $root tf2}
list [file exists tf1] [file exists tf2] [file exists td1]
-} -result {0 1 0}
+} -cleanup {cleanup} -result {0 1 0}
test fCmd-5.6 {TclFileDeleteCmd: Tcl_TranslateFileName fails} -constraints {notRoot} -body {
file delete ~_totally_bogus_user
} -returnCodes error -result {user "_totally_bogus_user" doesn't exist}
@@ -765,7 +782,7 @@ test fCmd-9.3 {file rename: comprehensive: file to new name} -setup {
} -result {{tf3 tf4} 1 0}
test fCmd-9.4 {file rename: comprehensive: dir to new name} -setup {
cleanup
-} -constraints {unixOrPc notRoot testchmod notDarwin9} -body {
+} -constraints {unixOrPc notRoot testchmod notDarwin9 win2000orXP} -body {
file mkdir td1 td2
testchmod 555 td2
file rename td1 td3
@@ -786,7 +803,7 @@ test fCmd-9.5 {file rename: comprehensive: file to self} -setup {
} -result {tf1 tf2 1 0}
test fCmd-9.6 {file rename: comprehensive: dir to self} -setup {
cleanup
-} -constraints {notRoot unixOrPc testchmod} -body {
+} -constraints {notRoot unixOrPc testchmod win2000orXP} -body {
file mkdir td1
file mkdir td2
testchmod 555 td2
@@ -862,12 +879,12 @@ test fCmd-9.9 {file rename: comprehensive: dir to non-empty dir} -setup {
file mkdir tds2
file mkdir [file join tdd1 tds1 xxx]
file mkdir [file join tdd2 tds2 xxx]
- if {![testConstraint unix]} {
+ if {!([testConstraint unix] || [testConstraint winVista])} {
testchmod 555 tds2
}
set a1 [list [catch {file rename -force tds1 tdd1} msg] $msg]
set a2 [list [catch {file rename -force tds2 tdd2} msg] $msg]
- if {[testConstraint unix]} {
+ if {[testConstraint unix] || [testConstraint winVista]} {
set w2 0
} else {
set w2 [file writable tds2]
@@ -893,12 +910,12 @@ test fCmd-9.11 {file rename: comprehensive: dir to new name and dir} -setup {
file mkdir td1
file mkdir td2
file mkdir td3
- if {![testConstraint unix]} {
+ if {!([testConstraint unix] || [testConstraint winVista])} {
testchmod 555 td2
}
file rename td1 [file join td3 td3]
file rename td2 [file join td3 td4]
- if {[testConstraint unix]} {
+ if {[testConstraint unix] || [testConstraint winVista]} {
set w4 0
} else {
set w4 [file writable [file join td3 td4]]