summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authordkf <donal.k.fellows@manchester.ac.uk>2004-08-19 21:12:03 (GMT)
committerdkf <donal.k.fellows@manchester.ac.uk>2004-08-19 21:12:03 (GMT)
commitc9da5ee615083ce94c4a918c020f6d3bed656ed3 (patch)
tree76cd978d84e7c39546540ce6800867d25c620f4d
parente5ffe43044ced6c87d5ae984a781f33ae89f9d99 (diff)
downloadtcl-c9da5ee615083ce94c4a918c020f6d3bed656ed3.zip
tcl-c9da5ee615083ce94c4a918c020f6d3bed656ed3.tar.gz
tcl-c9da5ee615083ce94c4a918c020f6d3bed656ed3.tar.bz2
Ensure that the %ld conversion works correctly on 64-bit platforms. [Bug 1011860]
-rw-r--r--ChangeLog5
-rw-r--r--generic/tclScan.c15
-rw-r--r--tests/scan.test7
3 files changed, 15 insertions, 12 deletions
diff --git a/ChangeLog b/ChangeLog
index df24275..120f229 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2004-08-19 Donal K. Fellows <donal.k.fellows@man.ac.uk>
+
+ * generic/tclScan.c (Tcl_ScanObjCmd, ValidateFormat): Ensure that
+ the %ld conversion works correctly on 64-bit platforms. [Bug 1011860]
+
2004-08-16 Miguel Sofer <msofer@users.sf.net>
* doc/SetVar.3:
diff --git a/generic/tclScan.c b/generic/tclScan.c
index 7d5b093..693fa60 100644
--- a/generic/tclScan.c
+++ b/generic/tclScan.c
@@ -8,7 +8,7 @@
* See the file "license.terms" for information on usage and redistribution
* of this file, and for a DISCLAIMER OF ALL WARRANTIES.
*
- * RCS: @(#) $Id: tclScan.c,v 1.12 2002/02/25 15:23:02 dkf Exp $
+ * RCS: @(#) $Id: tclScan.c,v 1.12.2.1 2004/08/19 21:12:04 dkf Exp $
*/
#include "tclInt.h"
@@ -371,9 +371,7 @@ ValidateFormat(interp, format, numVars, totalSubs)
switch (ch) {
case 'l':
case 'L':
-#ifndef TCL_WIDE_INT_IS_LONG
flags |= SCAN_LONGER;
-#endif
case 'h':
format += Tcl_UtfToUniChar(format, &ch);
}
@@ -704,9 +702,7 @@ Tcl_ScanObjCmd(dummy, interp, objc, objv)
switch (ch) {
case 'l':
case 'L':
-#ifndef TCL_WIDE_INT_IS_LONG
flags |= SCAN_LONGER;
-#endif
/*
* Fall through so we skip to the next character.
*/
@@ -1040,12 +1036,11 @@ Tcl_ScanObjCmd(dummy, interp, objc, objv)
if ((flags & SCAN_UNSIGNED) && (value < 0)) {
sprintf(buf, "%lu", value); /* INTL: ISO digit */
objPtr = Tcl_NewStringObj(buf, -1);
+ } else if ((flags & SCAN_LONGER)
+ || (unsigned long) value > UINT_MAX) {
+ objPtr = Tcl_NewLongObj(value);
} else {
- if ((unsigned long) value > UINT_MAX) {
- objPtr = Tcl_NewLongObj(value);
- } else {
- objPtr = Tcl_NewIntObj(value);
- }
+ objPtr = Tcl_NewIntObj(value);
}
#ifndef TCL_WIDE_INT_IS_LONG
}
diff --git a/tests/scan.test b/tests/scan.test
index a86c3da..173edb1 100644
--- a/tests/scan.test
+++ b/tests/scan.test
@@ -11,7 +11,7 @@
# See the file "license.terms" for information on usage and redistribution
# of this file, and for a DISCLAIMER OF ALL WARRANTIES.
#
-# RCS: @(#) $Id: scan.test,v 1.14 2002/06/22 04:19:47 dgp Exp $
+# RCS: @(#) $Id: scan.test,v 1.14.2.1 2004/08/19 21:12:04 dkf Exp $
if {[lsearch [namespace children] ::tcltest] == -1} {
package require tcltest 2
@@ -417,12 +417,15 @@ test scan-5.11 {integer scanning} {nonPortable} {
list [scan "4294967280 4294967280" "%u %d" a b] $a \
[expr {$b == -16 || $b == 0x7fffffff}]
} {2 4294967280 1}
-
test scan-5.12 {integer scanning} {64bitInts} {
set a {}; set b {}; set c {}
list [scan "7810179016327718216,6c63546f6c6c6548,661432506755433062510" \
%ld,%lx,%lo a b c] $a $b $c
} {3 7810179016327718216 7810179016327718216 7810179016327718216}
+test scan-5.13 {integer scanning and overflow} {
+ # This test used to fail on some 64-bit systems. [Bug 1011860]
+ scan {300000000 3000000000 30000000000} {%ld %ld %ld}
+} {300000000 3000000000 30000000000}
test scan-6.1 {floating-point scanning} {
set a {}; set b {}; set c {}; set d {}