diff options
| author | dgp <dgp@users.sourceforge.net> | 2010-03-29 21:57:33 (GMT) |
|---|---|---|
| committer | dgp <dgp@users.sourceforge.net> | 2010-03-29 21:57:33 (GMT) |
| commit | 9ef227372e59919e9aadd784fbf922027cb6289b (patch) | |
| tree | 797731259de846223c51b5e5170468b9964f4098 | |
| parent | 3c90840fbff766b8e5eba6584f1dfbe00dadd91b (diff) | |
| download | tcl-9ef227372e59919e9aadd784fbf922027cb6289b.zip tcl-9ef227372e59919e9aadd784fbf922027cb6289b.tar.gz tcl-9ef227372e59919e9aadd784fbf922027cb6289b.tar.bz2 | |
* generic/tclStringObj.c: Fix array overrun in test format-1.12
caught by valgrind testing.
| -rw-r--r-- | ChangeLog | 5 | ||||
| -rw-r--r-- | generic/tclStringObj.c | 4 |
2 files changed, 7 insertions, 2 deletions
@@ -1,3 +1,8 @@ +2010-03-29 Don Porter <dgp@users.sourceforge.net> + + * generic/tclStringObj.c: Fix array overrun in test format-1.12 + caught by valgrind testing. + 2010-03-25 Donal K. Fellows <dkf@users.sf.net> * unix/tclUnixFCmd.c (TclUnixCopyFile): [Bug 2976504]: Corrected diff --git a/generic/tclStringObj.c b/generic/tclStringObj.c index ffa51f8..ab6a600 100644 --- a/generic/tclStringObj.c +++ b/generic/tclStringObj.c @@ -33,7 +33,7 @@ * See the file "license.terms" for information on usage and redistribution of * this file, and for a DISCLAIMER OF ALL WARRANTIES. * - * RCS: @(#) $Id: tclStringObj.c,v 1.70.2.19 2010/01/18 09:50:57 dkf Exp $ */ + * RCS: @(#) $Id: tclStringObj.c,v 1.70.2.20 2010/03/29 21:57:33 dgp Exp $ */ #include "tclInt.h" #include "tommath.h" @@ -2275,7 +2275,7 @@ Tcl_AppendFormatToObj( int digitOffset; if (useBig && big.used) { - if ((size_t) shift < + if (index < big.used && (size_t) shift < CHAR_BIT*sizeof(Tcl_WideUInt) - DIGIT_BIT) { bits |= (((Tcl_WideUInt)big.dp[index++]) <<shift); shift += DIGIT_BIT; |