summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authordgp <dgp@users.sourceforge.net>2008-12-03 07:03:13 (GMT)
committerdgp <dgp@users.sourceforge.net>2008-12-03 07:03:13 (GMT)
commit07dfdbffea40d23c42aa88231f95e3d8a8360608 (patch)
tree52e42e89d7300ed5a7f9042991dd57ee8edbfbed
parent367a0d1f43cd0fd0273c65d8398d77926f811239 (diff)
downloadtcl-07dfdbffea40d23c42aa88231f95e3d8a8360608.zip
tcl-07dfdbffea40d23c42aa88231f95e3d8a8360608.tar.gz
tcl-07dfdbffea40d23c42aa88231f95e3d8a8360608.tar.bz2
* generic/tclFileName.c (DoGlob): One of the
Tcl_FSMatchInDirectory() calls did not have its return code checked. This caused error messages returned by some Tcl_Filesystem drivers to be swallowed.
-rw-r--r--ChangeLog7
-rw-r--r--generic/tclFileName.c7
2 files changed, 11 insertions, 3 deletions
diff --git a/ChangeLog b/ChangeLog
index 878caab..8aa8b15 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2008-12-03 Don Porter <dgp@users.sourceforge.net>
+
+ * generic/tclFileName.c (DoGlob): One of the
+ Tcl_FSMatchInDirectory() calls did not have its return code checked.
+ This caused error messages returned by some Tcl_Filesystem drivers
+ to be swallowed.
+
2008-12-02 Andreas Kupries <andreask@activestate.com>
* generic/tclIO.c (TclFinalizeIOSubsystem): Replaced Alexandre
diff --git a/generic/tclFileName.c b/generic/tclFileName.c
index 1c4b97e..c56c684 100644
--- a/generic/tclFileName.c
+++ b/generic/tclFileName.c
@@ -10,7 +10,7 @@
* See the file "license.terms" for information on usage and redistribution of
* this file, and for a DISCLAIMER OF ALL WARRANTIES.
*
- * RCS: @(#) $Id: tclFileName.c,v 1.86.2.1 2008/08/13 18:12:56 dgp Exp $
+ * RCS: @(#) $Id: tclFileName.c,v 1.86.2.2 2008/12/03 07:03:13 dgp Exp $
*/
#include "tclInt.h"
@@ -2456,9 +2456,10 @@ DoGlob(
}
Tcl_IncrRefCount(joinedPtr);
Tcl_DStringFree(&append);
- Tcl_FSMatchInDirectory(interp, matchesObj, joinedPtr, NULL, types);
+ result = Tcl_FSMatchInDirectory(interp, matchesObj, joinedPtr, NULL,
+ types);
Tcl_DecrRefCount(joinedPtr);
- return TCL_OK;
+ return result;
}
/*