diff options
| author | nijtmans@users.sourceforge.net <jan.nijtmans> | 2012-07-16 20:31:44 (GMT) |
|---|---|---|
| committer | nijtmans@users.sourceforge.net <jan.nijtmans> | 2012-07-16 20:31:44 (GMT) |
| commit | baba6f241492da135b95e133faf14f40f3a4c1c4 (patch) | |
| tree | 647407113d44545b2f799d4c0f3470478397f027 | |
| parent | 24cb6a7f513a872e861626174e9cdd7ff1da3326 (diff) | |
| download | tcl-baba6f241492da135b95e133faf14f40f3a4c1c4.zip tcl-baba6f241492da135b95e133faf14f40f3a4c1c4.tar.gz tcl-baba6f241492da135b95e133faf14f40f3a4c1c4.tar.bz2 | |
[Bug 3496014]: Unecessary memset() in Tcl_SetByteArrayObj()
| -rw-r--r-- | generic/tclBinary.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/generic/tclBinary.c b/generic/tclBinary.c index 444e7fa..ae8172f 100644 --- a/generic/tclBinary.c +++ b/generic/tclBinary.c @@ -307,12 +307,8 @@ Tcl_SetByteArrayObj( byteArrayPtr = ckalloc(BYTEARRAY_SIZE(length)); byteArrayPtr->used = length; byteArrayPtr->allocated = length; - if (length) { - if (bytes) { - memcpy(byteArrayPtr->bytes, bytes, (size_t) length); - } else { - memset(byteArrayPtr->bytes, 0, (size_t) length); - } + if (length && bytes) { + memcpy(byteArrayPtr->bytes, bytes, (size_t) length); } objPtr->typePtr = &tclByteArrayType; |