diff options
| author | vincentdarley <vincentdarley> | 2002-10-29 14:17:56 (GMT) |
|---|---|---|
| committer | vincentdarley <vincentdarley> | 2002-10-29 14:17:56 (GMT) |
| commit | a04cf8ef01358dba752718a48cde2847e3e98ad0 (patch) | |
| tree | 0b3d945a96ad90618611731efeadbd12b3896361 | |
| parent | fb6c631d984e1edda14aa4a7494f6262192cf788 (diff) | |
| download | tcl-a04cf8ef01358dba752718a48cde2847e3e98ad0.zip tcl-a04cf8ef01358dba752718a48cde2847e3e98ad0.tar.gz tcl-a04cf8ef01358dba752718a48cde2847e3e98ad0.tar.bz2 | |
comments added
| -rw-r--r-- | ChangeLog | 8 | ||||
| -rw-r--r-- | win/tclWin32Dll.c | 16 | ||||
| -rw-r--r-- | win/tclWinInt.h | 9 |
3 files changed, 31 insertions, 2 deletions
@@ -1,3 +1,11 @@ +2002-10-29 Vince Darley <vincentdarley@users.sourceforge.net> + + * win/tclWinInt.h: + * win/tclWin32Dll.c: added comments about certain NULL function + pointers which will be filled in when Tcl_FindExecutable is + called, so that users don't report invalid bugs on this topic. + (No code changes at all). + 2002-10-29 Daniel Steffen <das@users.sourceforge.net> * unix/tclLoadDyld.c (TclpFindSymbol): pass all dyld error diff --git a/win/tclWin32Dll.c b/win/tclWin32Dll.c index e3e95e5..d3a1172 100644 --- a/win/tclWin32Dll.c +++ b/win/tclWin32Dll.c @@ -9,7 +9,7 @@ * See the file "license.terms" for information on usage and redistribution * of this file, and for a DISCLAIMER OF ALL WARRANTIES. * - * RCS: @(#) $Id: tclWin32Dll.c,v 1.16 2002/06/13 09:40:01 vincentdarley Exp $ + * RCS: @(#) $Id: tclWin32Dll.c,v 1.17 2002/10/29 14:17:58 vincentdarley Exp $ */ #include "tclWinInt.h" @@ -83,6 +83,13 @@ static TclWinProcs asciiProcs = { WCHAR *, TCHAR **)) SearchPathA, (BOOL (WINAPI *)(CONST TCHAR *)) SetCurrentDirectoryA, (BOOL (WINAPI *)(CONST TCHAR *, DWORD)) SetFileAttributesA, + /* + * These two function pointers will only be set when + * Tcl_FindExecutable is called. If you don't ever call that + * function, the application will crash whenever WinTcl tries to call + * functions through these null pointers. That is not a bug in Tcl + * -- Tcl_FindExecutable is obligatory in recent Tcl releases. + */ NULL, NULL, }; @@ -122,6 +129,13 @@ static TclWinProcs unicodeProcs = { WCHAR *, TCHAR **)) SearchPathW, (BOOL (WINAPI *)(CONST TCHAR *)) SetCurrentDirectoryW, (BOOL (WINAPI *)(CONST TCHAR *, DWORD)) SetFileAttributesW, + /* + * These two function pointers will only be set when + * Tcl_FindExecutable is called. If you don't ever call that + * function, the application will crash whenever WinTcl tries to call + * functions through these null pointers. That is not a bug in Tcl + * -- Tcl_FindExecutable is obligatory in recent Tcl releases. + */ NULL, NULL, }; diff --git a/win/tclWinInt.h b/win/tclWinInt.h index eb89c35..b6f144d 100644 --- a/win/tclWinInt.h +++ b/win/tclWinInt.h @@ -8,7 +8,7 @@ * See the file "license.terms" for information on usage and redistribution * of this file, and for a DISCLAIMER OF ALL WARRANTIES. * - * RCS: @(#) $Id: tclWinInt.h,v 1.16 2002/06/13 09:40:02 vincentdarley Exp $ + * RCS: @(#) $Id: tclWinInt.h,v 1.17 2002/10/29 14:17:58 vincentdarley Exp $ */ #ifndef _TCLWININT @@ -89,6 +89,13 @@ typedef struct TclWinProcs { CONST TCHAR *, DWORD, WCHAR *, TCHAR **); BOOL (WINAPI *setCurrentDirectoryProc)(CONST TCHAR *); BOOL (WINAPI *setFileAttributesProc)(CONST TCHAR *, DWORD); + /* + * These two function pointers will only be set when + * Tcl_FindExecutable is called. If you don't ever call that + * function, the application will crash whenever WinTcl tries to call + * functions through these null pointers. That is not a bug in Tcl + * -- Tcl_FindExecutable is obligatory in recent Tcl releases. + */ BOOL (WINAPI *getFileAttributesExProc)(CONST TCHAR *, GET_FILEEX_INFO_LEVELS, LPVOID); BOOL (WINAPI *createHardLinkProc)(CONST TCHAR*, CONST TCHAR*, |