summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authordgp <dgp@users.sourceforge.net>2013-08-15 19:59:32 (GMT)
committerdgp <dgp@users.sourceforge.net>2013-08-15 19:59:32 (GMT)
commit9feda62fe0318715623c455abe7289bbb7dec34e (patch)
tree53980304ebd4b378c6e5926bd746ac753440f77d
parent77e6fd7e3c4a62f918f3a52cfb48d176c0d9d9a7 (diff)
parent86d682b82273fd98a4259df86f4303bc65a896b6 (diff)
downloadtcl-9feda62fe0318715623c455abe7289bbb7dec34e.zip
tcl-9feda62fe0318715623c455abe7289bbb7dec34e.tar.gz
tcl-9feda62fe0318715623c455abe7289bbb7dec34e.tar.bz2
Make sure the errors raised by execution traces become errors raised by the
traced command, as documented. Deletion of the traced command was supressing that.
-rw-r--r--generic/tclBasic.c6
-rw-r--r--tests/trace.test7
2 files changed, 10 insertions, 3 deletions
diff --git a/generic/tclBasic.c b/generic/tclBasic.c
index dd6a40b..4a95340 100644
--- a/generic/tclBasic.c
+++ b/generic/tclBasic.c
@@ -4188,12 +4188,12 @@ TclNREvalObjv(
result = TEOV_RunEnterTraces(interp, &cmdPtr, TclGetSourceFromFrame(
flags & TCL_EVAL_SOURCE_IN_FRAME ? iPtr->cmdFramePtr : NULL,
objc, objv), objc, objv, lookupNsPtr);
- if (!cmdPtr) {
- return TEOV_NotFound(interp, objc, objv, lookupNsPtr);
- }
if (result != TCL_OK) {
return result;
}
+ if (!cmdPtr) {
+ return TEOV_NotFound(interp, objc, objv, lookupNsPtr);
+ }
}
diff --git a/tests/trace.test b/tests/trace.test
index a3a5604..d830f3c 100644
--- a/tests/trace.test
+++ b/tests/trace.test
@@ -2661,6 +2661,13 @@ test trace-39.1 {bug #3485022: tracing Bc'ed commands} -setup {
rename dotrace {}
rename foo {}
} -result {3 | 0 1 1}
+
+test trace-40.1 {execution trace errors become command errors} {
+ proc foo args {}
+ trace add execution foo enter {rename foo {}; error bar;#}
+ catch foo m
+ return -level 0 $m[unset m]
+} bar
# Delete procedures when done, so we don't clash with other tests
# (e.g. foobar will clash with 'unknown' tests).