diff options
| author | dkf <donal.k.fellows@manchester.ac.uk> | 2011-08-04 14:13:33 (GMT) |
|---|---|---|
| committer | dkf <donal.k.fellows@manchester.ac.uk> | 2011-08-04 14:13:33 (GMT) |
| commit | a789207beed7bac51e02a7710720d6c550e7014d (patch) | |
| tree | 3631427f35da8f0fa86dd03ea08eec56a20a20ed | |
| parent | 2d023b4b58bc316adcf9e9721273392145c60fc2 (diff) | |
| download | tcl-a789207beed7bac51e02a7710720d6c550e7014d.zip tcl-a789207beed7bac51e02a7710720d6c550e7014d.tar.gz tcl-a789207beed7bac51e02a7710720d6c550e7014d.tar.bz2 | |
More memleak plugging.
| -rw-r--r-- | ChangeLog | 14 | ||||
| -rw-r--r-- | generic/tclAssembly.c | 17 |
2 files changed, 9 insertions, 22 deletions
@@ -1,14 +1,15 @@ -<<<<<<< BEGIN MERGE CONFLICT: local copy shown first <<<<<<<<<<<<<<< +2011-08-04 Donal K. Fellows <dkf@users.sf.net> + + * generic/tclAssembly.c (FreeAssemblyEnv): [Bug 3384840]: Plug another + possible memory leak due to over-complex code for freeing the table of + labels. + 2011-08-04 Reinhard Max <max@suse.de> * generic/tclIOSock.c (TclCreateSocketAddress): Don't bother using AI_ADDRCONFIG for now, as it was causing problems in various situations. - -2011-08-02 Don Porter <dgp@users.sourceforge.net> -======= COMMON ANCESTOR content follows ============================ -2011-08-02 Don Porter <dgp@users.sourceforge.net> -======= MERGED IN content follows ================================== + 2011-08-04 Donal K. Fellows <dkf@users.sf.net> * generic/tclAssembly.c (AssembleOneLine, GetBooleanOperand) @@ -20,7 +21,6 @@ tests. 2011-08-02 Don Porter <dgp@users.sourceforge.net> ->>>>>>> END MERGE CONFLICT >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> * changes: Updates for 8.6b2 release. * tools/tcltk-man2html.tcl: Variable substitution botch. diff --git a/generic/tclAssembly.c b/generic/tclAssembly.c index e12d0f8..7868882 100644 --- a/generic/tclAssembly.c +++ b/generic/tclAssembly.c @@ -1173,24 +1173,10 @@ FreeAssemblyEnv( } /* - * Free the label hash. - */ - - while (1) { - Tcl_HashEntry* hashEntry; - Tcl_HashSearch hashSearch; - - hashEntry = Tcl_FirstHashEntry(&assemEnvPtr->labelHash, &hashSearch); - if (hashEntry == NULL) { - break; - } - Tcl_DeleteHashEntry(hashEntry); - } - - /* * Dispose what's left. */ + Tcl_DeleteHashTable(&assemEnvPtr->labelHash); TclStackFree(interp, assemEnvPtr->parsePtr); TclStackFree(interp, assemEnvPtr); } @@ -2255,6 +2241,7 @@ FindLocalVar( } varNameStr = Tcl_GetStringFromObj(varNameObj, &varNameLen); if (CheckNamespaceQualifiers(interp, varNameStr, varNameLen)) { + Tcl_DecrRefCount(varNameObj); return -1; } localVar = TclFindCompiledLocal(varNameStr, varNameLen, 1, envPtr); |