NRE-enable non-compiled [foreach]. [Bug 2017632]

1 files changed, 46 insertions, 39 deletions

diff --git a/ChangeLog b/ChangeLog
index c70f1d1..bdbda13 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2008-08-24  Donal K. Fellows  <dkf@users.sf.net>
+
+	* generic/tclCmdAH.c (TclNRForeachCmd): Converted the [foreach]
+	command to have an NRE-aware non-compiled implementation. Part of the
+	[Bug 2017632] project. Also restructured the code so as to manage its
+	temporary memory more efficiently.
+
 2008-08-23  Miguel Sofer  <msofer@users.sf.net>
 
 	* generic/tclBasic.c:     Removed unused var; fixed function 
@@ -27,19 +34,19 @@
 
 	* changes:	Updates for 8.6a2 release.
 
-	* generic/tcl.h:	Drop use of USE_COMPAT85_CONST.  That added
-	indirection without value.  Use -DCONST86="" to engage source compat
+	* generic/tcl.h:	Drop use of USE_COMPAT85_CONST. That added
+	indirection without value. Use -DCONST86="" to engage source compat
 	support for code written for 8.5 headers.
 
 	* generic/tclUtil.c (TclReToGlob):      Added missing set of the
-	*exactPtr value to really fix [Bug 2065115].  Also avoid possible
+	*exactPtr value to really fix [Bug 2065115]. Also avoid possible
 	DString overflow.
 	* tests/regexpComp.test:        Correct duplicate test names.
 
 2008-08-21  Miguel Sofer  <msofer@users.sf.net>
 
 	* generic/tclBasic.c:     Previous fix, now done right.
-	* generic/tclCmdIL.c:   
+	* generic/tclCmdIL.c:
 	* generic/tclInt.h:     
 	* tests/unsupported.test:
 
@@ -55,7 +62,7 @@
 	* generic/tcl.decls:    the use of CONST86_RETURN to support source
 	code compatibility with Tcl 8.5 on those public routines passing
 	(Tcl_Filesystem *), (Tcl_Timer *), and (Tcl_Objtype *) values which
-	have been const-ified.  What remains is the minimum configurability
+	have been const-ified. What remains is the minimum configurability
 	needed to support code written for pre-8.6 headers via the new
 	-DUSE_COMPAT85_CONST compiler directive.
 	*** POTENTIAL INCOMPATIBILITY ***
@@ -178,7 +185,7 @@
 2008-08-08  Don Porter  <dgp@users.sourceforge.net>S
 
 	* generic/tclOOMethod.c (PushMethodCallFrame):	Added missing check
-	for bytecode validity.  [Bug 2037727]
+	for bytecode validity. [Bug 2037727]
 
 	* generic/tclProc.c (TclProcCompileProc):	On recompile of a
 	proc, clear away any entries on the CompiledLocal list from the
@@ -365,9 +372,9 @@
 	* generic/tclBasic.c:	Revised timing of the CmdFrame stack management
 	* tests/info.test:	in TclEvalEx so that the CmdFrame will still
 	be on the stack at the time Tcl_LogCommandInfo is called to append
-	another level of -errorinfo information.  Sets the stage to add
-	file and line data to the stack trace.  Added test to check that
-	[info frame] functioning remains unchanged by the revision.
+	another level of -errorinfo information. Sets the stage to add file
+	and line data to the stack trace. Added test to check that [info
+	frame] functioning remains unchanged by the revision.
 
 2008-07-31  Miguel Sofer  <msofer@users.sf.net>
 
@@ -961,7 +968,7 @@
 
 	* generic/tclPathObj.c: Fixed some internals management in the "path"
 	Tcl_ObjType for the empty string value. Problem led to a crash in the
-	command [glob -dir {} a]. [Bug 1999176].
+	command [glob -dir {} a]. [Bug 1999176]
 
 2008-06-24  Pat Thoyts	<patthoyts@users.sourceforge.net>
 
@@ -1475,7 +1482,7 @@
 2008-04-14  Kevin B. Kenny <kennykb@acm.org>
 
 	* unix/tclUnixTime.c (NativeGetTime): Removed obsolete use of
-	'struct timezone' in the call to 'gettimeofday'. [Bug 1942197].
+	'struct timezone' in the call to 'gettimeofday'. [Bug 1942197]
 
 	* tests/clock.test (clock-33.5, clock-33.5a, clock-33.8, clock-33.8a):
 	Added comments to the test that it can fail on a heavily loaded
@@ -1512,10 +1519,10 @@
 
 	* generic/tclIOCmd.c (Tcl_FcopyObjCmd): Added checking of -size value
 	* tests/ioCmd.test (iocmd-15.{13,14}): to reject negative values, and
-	values overflowing 32-bit signed. [Bug 1557855]. Basic patch by
-	Alexandre Ferrieux <ferrieux@users.sourceforge.net>, with
-	modifications from me to separate overflow from true negative value.
-	Extended testsuite.
+	values overflowing 32-bit signed. Basic patch by Alexandre Ferrieux
+	<ferrieux@users.sourceforge.net>, with modifications from me to
+	separate overflow from true negative value. Extended testsuite. [Bug
+	1557855]
 
 2008-04-09  Daniel Steffen  <das@users.sourceforge.net>
 
@@ -1549,8 +1556,8 @@
 
 	* generic/tclIO.c (BUSY_STATE, CheckChannelErrors, TclCopyChannel):
 	New macro, and the places using it. This change allows for
-	bi-directional fcopy on channels. [Bug 1350564]. Thanks to Alexandre
-	Ferrieux <ferrieux@users.sourceforge.net> for the patch.
+	bi-directional fcopy on channels. Thanks to Alexandre Ferrieux
+	<ferrieux@users.sourceforge.net> for the patch. [Bug 1350564]
 
 2008-04-07  Reinhard Max  <max@suse.de>
 
@@ -1664,7 +1671,7 @@
 	* generic/tclBasic.c:	Revised stubs-generation tool and interp
 	* tools/genStubs.tcl:	creation so that "tclStubsPtr" is not present
 	* unix/Makefile.in:	in libtcl.so, but is present only in
-	* win/Makefile.in:	libtclstub.a.  This tightens up the rules for
+	* win/Makefile.in:	libtclstub.a. This tightens up the rules for
 	* win/makefile.bc:	users of the stubs interfaces. [Bug 1819422]
 	* win/makefile.vc:
 
@@ -1802,10 +1809,10 @@
 2008-03-18  Andreas Kupries  <andreask@activestate.com>
 
 	* library/tm.tcl (::tcl::tm::Defaults): Modified handling of
-	environment variables. See [Bug 1914604]. Solution slightly different
-	than proposed in the report. Using the underscored form TCLX_y_TM_PATH
-	even if TCLX.y_TM_PATH exists. Also using a loop to cut prevent code
-	replication.
+	environment variables. Solution slightly different than proposed in
+	the report. Using the underscored form TCLX_y_TM_PATH even if
+	TCLX.y_TM_PATH exists. Also using a loop to cut prevent code
+	replication. [Bug 1914604]
 
 2008-03-16  Donal K. Fellows  <dkf@users.sf.net>
 
@@ -1992,7 +1999,7 @@
 
 	* generic/tclResult.c (Tcl_SetReturnOptions):	Revised the refcount
 	management of Tcl_SetReturnOptions to become that of a conventional
-	Consumer routine.  Thanks to Peter Spjuth for pointing out the
+	Consumer routine. Thanks to Peter Spjuth for pointing out the
 	difficulties calling Tcl_SetReturnOptions with non-0-count value for
 	options.
 	* generic/tclExecute.c (INST_RETURN_STK): Revised the one caller
@@ -2018,7 +2025,7 @@
 	* unix/tclUnixChan.c, unix/tclUnixNotfy.c, unix/tclUnixPipe.c:
 	Consolidate all code conditionalized on -DUSE_FIONBIO into one place.
 	* unix/tclUnixPort.h, unix/tclUnixCompat.c: New routine
-	TclUnixSetBlockingMode() [Patch 1903339].
+	TclUnixSetBlockingMode(). [Patch 1903339]
 
 2008-02-28  Don Porter	<dgp@users.sourceforge.net>
 
@@ -2059,7 +2066,7 @@
 
 	* generic/tclIOUtil.c, unix/tclUnixPort.h, unix/tclUnixChan.c:
 	Remove dead/unused portability-related #defines and unused conditional
-	code.  See [Patch 1901828] for discussion.
+	code. See [Patch 1901828] for discussion.
 
 2008-02-26  Joe English	 <jenglish@users.sourceforge.net>
 
@@ -2319,7 +2326,7 @@
 
 2007-12-21  Miguel Sofer  <msofer@users.sf.net>
 
-	* generic/tclCmdIL.c: Speed patch for lsort [Patch 1856994].
+	* generic/tclCmdIL.c: Speed patch for lsort. [Patch 1856994]
 
 2007-12-21  Miguel Sofer  <msofer@users.sf.net>
 
@@ -2343,8 +2350,8 @@
 
 	* generic/tclCompCmds.c (TclCompileSwitchCmd):	update switch -regexp
 	* tests/switch.test-14.*:			compilation to pass
-	the cflags to INST_REGEXP (changed on 12-07).  Added tests for
-	switch -regexp compilation (need more). [Bug 1854399]
+	the cflags to INST_REGEXP (changed on 12-07). Added tests for switch
+	-regexp compilation (need more). [Bug 1854399]
 
 2007-12-18  Don Porter	<dgp@users.sourceforge.net>
 
@@ -2396,8 +2403,8 @@
 2007-12-12  Don Porter	<dgp@users.sourceforge.net>
 
 	* doc/IntObj.3:	Update docs for the Tcl_GetBignumAndClearObj() ->
-	Tcl_TakeBignumFromObj() revision [TIP 298].  Added docs for the
-	Tcl_InitBignumFromDouble() routine. [Bug 1446971].
+	Tcl_TakeBignumFromObj() revision [TIP 298]. Added docs for the
+	Tcl_InitBignumFromDouble() routine. [Bug 1446971]
 
 	* changes:		Updated for 8.5.0 release.
 
@@ -2472,11 +2479,11 @@
 2007-12-06  Don Porter	<dgp@users.sourceforge.net>
 
 	* README:	Remove mention of dead comp.lang.tcl.announce
-	newsgroup.  [Bug 1846433].
+	newsgroup. [Bug 1846433]
 
 	* unix/README:	Mention the stub library created by `make` and warn
 	about the effect of embedded paths in the installed binaries.
-	Thanks to Larry Virden.	 [Bug 1794084]
+	Thanks to Larry Virden. [Bug 1794084]
 
 	* doc/AddErrInfo.3:	Documentation for the new routines in TIP 270.
 	* doc/Interp.3:
@@ -2509,7 +2516,7 @@
 2007-12-05  Jeff Hobbs	<jeffh@ActiveState.com>
 
 	* generic/tclIO.h:    Create Tcl_Obj for Tcl channels to reduce
-	* generic/tclIO.c:    overhead in lookup by Tcl_GetChannel.  New
+	* generic/tclIO.c:    overhead in lookup by Tcl_GetChannel. New
 	* generic/tclIOCmd.c: TclGetChannelFromObj for internal use.
 	* generic/tclIO.c (WriteBytes, WriteChars): add opt check to avoid
 	EOL translation when not linebuffered or using lf. [Bug 1845092]
@@ -4910,8 +4917,8 @@
 	* library/msgs/ja.msg:
 	* tools/loadICU.tcl: Corrected several localisation faults in the
 	Japanese locale (most notably, incorrect dates for the Emperors'
-	eras). [Bug 1637471]. Many thanks to SourceForge user 'nyademo' for
-	pointing this out and developing a fix.
+	eras). Many thanks to SourceForge user 'nyademo' for pointing this out
+	and developing a fix. [Bug 1637471]
 	* generic/tclPathObj.c: Corrected a 'const'ness fault that caused
 	bitter complaints from MSVC.
 	* tests/clock.test (clock-40.1, clock-58.1, clock-59.1): Corrected a
@@ -5987,7 +5994,7 @@
 	* tests/event.test (event-14.*): Corrected a bug where
 	TclUnixWaitForFile would present select() with the wrong mask on an
 	LP64 machine if a fd number exceeds 32. Thanks to Jean-Luc Fontaine
-	for reporting and diagnosing [Bug 1602208].
+	for reporting and diagnosing. [Bug 1602208]
 
 2006-11-27  Don Porter	<dgp@users.sourceforge.net>
 
@@ -7496,9 +7503,9 @@
 
 	* generic/tclProc.c (ProcCompileProc): When a bump of the compile
 	epoch forces the re-compile of a proc body, take care not to overwrite
-	any Proc struct that may be referred to on the active call stack. This
-	fixes [Bug 1482718]. Note that the fix will not be effective for code
-	that calls the private routine TclProcCompileProc() directly.
+	any Proc struct that may be referred to on the active call stack. Note
+	that the fix will not be effective for code that calls the private
+	routine TclProcCompileProc() directly. [Bug 1482718]
 
 2006-05-13  Daniel Steffen  <das@users.sourceforge.net>