summaryrefslogtreecommitdiffstats
path: root/ChangeLog
diff options
context:
space:
mode:
authordgp <dgp@users.sourceforge.net>2005-04-21 20:24:02 (GMT)
committerdgp <dgp@users.sourceforge.net>2005-04-21 20:24:02 (GMT)
commit713419b2244c57466ead6674b4c9d30c54dc60d8 (patch)
treed1b5923569a757d01be4827253f687dbd07a8163 /ChangeLog
parent28deb99f386df3eb58792a8f7785860868d24d3d (diff)
downloadtcl-713419b2244c57466ead6674b4c9d30c54dc60d8.zip
tcl-713419b2244c57466ead6674b4c9d30c54dc60d8.tar.gz
tcl-713419b2244c57466ead6674b4c9d30c54dc60d8.tar.bz2
* generic/tclGet.c: Radical code simplification. Converted
Tcl_GetFoo() routines into wrappers around Tcl_GetFooFromObj(). Reduces code duplication, and the resulting potential for inconsistency. * generic/tclObj.c: Several changes: - Fixed Tcl_GetBooleanFromObj to agree with its documentation and with Tcl_GetBoolean, accepting only "0" and "1" and not other numeric strings. [Bug 1187123] - Added new private routine TclGetTruthValueFromObj to perform the more permissive conversion of numeric values to boolean that is needed by the [expr] machinery. * generic/tclInt.h (TclGetTruthValueFromObj): New routine. * generic/tclExecute.c: Updated callers to call new routine. * tests/obj.test: Corrected bad tests that actually expected values like "47" and "0xac" to be accepted as booleans.
Diffstat (limited to 'ChangeLog')
-rw-r--r--ChangeLog31
1 files changed, 22 insertions, 9 deletions
diff --git a/ChangeLog b/ChangeLog
index cbf5ed9..c32e1f6 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -2,18 +2,31 @@
* doc/GetInt.3: Convert argument "string" to "str" to agree with code.
Also clarified a few details on int and double formats.
- * generic/tclGet.c: Radical code simplification. Converted most
+ * generic/tclGet.c: Radical code simplification. Converted
Tcl_GetFoo() routines into wrappers around Tcl_GetFooFromObj().
Reduces code duplication, and the resulting potential for inconsistency.
- * generic/tclObj.c: Re-ordered error detection code so all values
- with trailing garbage receive a "not an integer" message instead of
- an "integer too large" message.
- Removed inactive code meant to deal with strtoul* routines that fail
- to parse leading signs. All of them do, and if any are detected
- that do not, the correct fix is replacement with compat/strtoul*.c,
- not a lot of special care by the callers.
- Tcl_GetDoubleFromObj now avoids shimmering away a "wideInt" intrep.
+ * generic/tclObj.c: Several changes:
+
+ - Re-ordered error detection code so all values with trailing
+ garbage receive a "not an integer" message instead of an
+ "integer too large" message.
+ - Removed inactive code meant to deal with strtoul* routines that
+ fail to parse leading signs. All of them do, and if any are
+ detected that do not, the correct fix is replacement with
+ compat/strtoul*.c, not a lot of special care by the callers.
+ - Tcl_GetDoubleFromObj now avoids shimmering away a "wideInt" intrep.
+ - Fixed Tcl_GetBooleanFromObj to agree with its documentation and
+ with Tcl_GetBoolean, accepting only "0" and "1" and not other
+ numeric strings. [Bug 1187123]
+ - Added new private routine TclGetTruthValueFromObj to perform
+ the more permissive conversion of numeric values to boolean
+ that is needed by the [expr] machinery.
+
+ * generic/tclInt.h (TclGetTruthValueFromObj): New routine.
+ * generic/tclExecute.c: Updated callers to call new routine.
+ * tests/obj.test: Corrected bad tests that actually expected
+ values like "47" and "0xac" to be accepted as booleans.
2005-04-20 Don Porter <dgp@users.sourceforge.net>