diff options
| author | andreas_kupries <akupries@shaw.ca> | 2004-07-15 20:46:49 (GMT) |
|---|---|---|
| committer | andreas_kupries <akupries@shaw.ca> | 2004-07-15 20:46:49 (GMT) |
| commit | d030c083e5dd7913feb8736f3727f316fe525876 (patch) | |
| tree | 57898ba81f1e08b32a243a13819f2637f6435d74 /ChangeLog | |
| parent | ac5258caba03972be43bafc65a38ad4571af178f (diff) | |
| download | tcl-d030c083e5dd7913feb8736f3727f316fe525876.zip tcl-d030c083e5dd7913feb8736f3727f316fe525876.tar.gz tcl-d030c083e5dd7913feb8736f3727f316fe525876.tar.bz2 | |
* generic/tclIO.h (CHANNEL_INCLOSE): New flag. Set in
* generic/tclIO.c (Tcl_UnregisterChannel): 'Tcl_Close' while the
* generic/tclIO.c (Tcl_Close): close callbacks are
run. Checked in 'Tcl_Close' and 'Tcl_Unregister' to prevent
recursive call of 'close' in the close-callbacks. This is a
possible error made by implementors of virtual filesystems based
on 'tclvfs', thinking that they have to close the channel in the
close handler for the filesystem.
* generic/tclIO.c:
* generic/tclIO.h:
* Not reverting, but #ifdef'ing the changes from May 19, 2004 out
of the core. This removes the ***POTENTIAL INCOMPATIBILITY***
for channel drivers it introduced. This has become possible due
to Expect gaining a BlockModeProc and now handling blockingg and
non-blocking modes correctly. Thus [SF Tcl Bug 943274] is still
fixed if a recent enough version of Expect is used.
* doc/CrtChannel.3: Added warning about usage of a channel without
a BlockModeProc.
Diffstat (limited to 'ChangeLog')
| -rw-r--r-- | ChangeLog | 31 |
1 files changed, 29 insertions, 2 deletions
@@ -1,3 +1,28 @@ +2004-07-15 Andreas Kupries <andreask@activestate.com> + + * generic/tclIO.h (CHANNEL_INCLOSE): New flag. Set in + * generic/tclIO.c (Tcl_UnregisterChannel): 'Tcl_Close' while the + * generic/tclIO.c (Tcl_Close): close callbacks are + run. Checked in 'Tcl_Close' and 'Tcl_Unregister' to prevent + recursive call of 'close' in the close-callbacks. This is a + possible error made by implementors of virtual filesystems based + on 'tclvfs', thinking that they have to close the channel in the + close handler for the filesystem. + +2004-06-14 Andreas Kupries <andreask@activestate.com> + + * generic/tclIO.c: + * generic/tclIO.h: + * Not reverting, but #ifdef'ing the changes from May 19, 2004 out + of the core. This removes the ***POTENTIAL INCOMPATIBILITY*** + for channel drivers it introduced. This has become possible due + to Expect gaining a BlockModeProc and now handling blockingg and + non-blocking modes correctly. Thus [SF Tcl Bug 943274] is still + fixed if a recent enough version of Expect is used. + + * doc/CrtChannel.3: Added warning about usage of a channel without + a BlockModeProc. + 2004-07-15 Andreas Kupries <andreask@pliers.activestate.com> * generic/tclIOCmd.c (Tcl_PutsObjCmd): Added length check to the @@ -828,8 +853,8 @@ 2004-05-19 Andreas Kupries <andreask@activestate.com> - * tclIO.c: Fixed [SF Tcl Bug 943274]. This is the same problem as - * tclIO.h: [SF Tcl Bug 462317], see ChangeLog entry + * generic/tclIO.c: Fixed [SF Tcl Bug 943274]. This is the same problem as + * generic/tclIO.h: [SF Tcl Bug 462317], see ChangeLog entry 2001-09-26. The fix done at that time is incomplete. It is possible to get around it if the actual read operation is defered and not executed in the event @@ -840,6 +865,8 @@ actual data waiting. The flag is cleared by a short or full read. + ***POTENTIAL INCOMPATIBILITY*** for channel drivers. + 2004-05-17 Vince Darley <vincentdarley@users.sourceforge.net> * generic/tclPathObj.c: fix to (Bug 956063) in 'file dirname'. |