Fix [Bug 2200824] and make class constructor error handling much more robust.

1 files changed, 31 insertions, 15 deletions

diff --git a/ChangeLog b/ChangeLog
index e2d4608..6880855 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,20 @@
+2008-10-31  Donal K. Fellows  <dkf@users.sf.net>
+
+	* generic/tclOOBasic.c (TclOONRUpcatch): Reworked the code that does
+	* generic/tclOO.c (InitFoundation):	 class constructor handling so
+	that it is more robust and runs the constructor call in the context of
+	the caller of the class's constructor method. Needed because the
+	previously used code did not work at all after applying the fix below;
+	no Tcl existing command could reliably do what was needed any more.
+
+	* generic/tclOODefineCmds.c (GetClassInOuterContext): Rework and
+	factor out the code to resolve class names in definitions so that
+	classes are resolved from the perspective of the caller of the
+	[oo::define] command, rather than from the oo::define namespace! This
+	makes much code simpler by reducing how often fully-qualified names
+	are required (previously always in practice, so no back-compat issues
+	exist). [Bug 2200824]
+
 2008-10-28  Jan Nijtmans  <nijtmans@users.sf.net>
 
 	* generic/tclCompile.h:      CONSTify TclDTraceInfo
@@ -8,27 +25,26 @@
 
 2008-10-27  Don Porter  <dgp@users.sourceforge.net>
 
-	* generic/tclEncoding.c:	Use "iso8859-1" and not "identity"
-	as the default and original [encoding system] value.  Since
-	"iso8859-1" is built in to the C source code for Tcl now, there's no
-	availability issue, and it has the good feature of "identity" that
-	we must have ("bytes in" == "bytes out") without the bad feature of
-	"identity" ("broken as designed") that makes us want to abandon it.
-	[RFE 2008609]
-	*** POTENTIAL INCOMPATIBILITY for older releases of Tclkit and
-	any other code expecting a particular value for Tcl's default
-	system encoding ***
+	* generic/tclEncoding.c:	Use "iso8859-1" and not "identity" as
+	the default and original [encoding system] value. Since "iso8859-1" is
+	built in to the C source code for Tcl now, there's no availability
+	issue, and it has the good feature of "identity" that we must have
+	("bytes in" == "bytes out") without the bad feature of "identity"
+	("broken as designed") that makes us want to abandon it. [RFE 2008609]
+	*** POTENTIAL INCOMPATIBILITY for older releases of Tclkit and any
+	other code expecting a particular value for Tcl's default system
+	encoding ***
 
 2008-10-24  Pat Thoyts  <patthoyts@users.sourceforge.net>
 
 	* library/http/http.tcl: Fixed a failure to read SHOUTcast streams
-	with the new 2.7 package. Introduced a new intial state as the
-	first response may not be HTTP*.
+	with the new 2.7 package. Introduced a new intial state as the first
+	response may not be HTTP*.
 
 2008-10-23  Miguel Sofer  <msofer@users.sf.net>
 
-	* generic/tclCmdAH.c (ForNextCallback): handle TCL_CONTINUE in
-	the for body [Bug 2186888].
+	* generic/tclCmdAH.c (ForNextCallback): handle TCL_CONTINUE in the for
+	body [Bug 2186888].
 
 2008-10-22  Jan Nijtmans  <nijtmans@users.sf.net>
 
@@ -53,7 +69,7 @@
 2008-10-19  Don Porter  <dgp@users.sourceforge.net>
 
 	* generic/tclProc.c:    Reset -level and -code values to defaults
-	after they are used.  [Bug 2152286].
+	after they are used. [Bug 2152286]
 
 2008-10-19  Donal K. Fellows  <dkf@users.sf.net>