diff options
| author | dgp <dgp@users.sourceforge.net> | 2013-09-05 17:21:41 (GMT) |
|---|---|---|
| committer | dgp <dgp@users.sourceforge.net> | 2013-09-05 17:21:41 (GMT) |
| commit | 76023565adb6e64816efbf4cae39b1c5d2ab725a (patch) | |
| tree | 531f5aa3ec5d823c5a4d62ea1142497ec962b581 /generic/tclBasic.c | |
| parent | 86d682b82273fd98a4259df86f4303bc65a896b6 (diff) | |
| download | tcl-76023565adb6e64816efbf4cae39b1c5d2ab725a.zip tcl-76023565adb6e64816efbf4cae39b1c5d2ab725a.tar.gz tcl-76023565adb6e64816efbf4cae39b1c5d2ab725a.tar.bz2 | |
Partial revert of [a16752c252] bug fix to stop crashes in buggy tclcompiler.unbreak_tclcompiler
Diffstat (limited to 'generic/tclBasic.c')
| -rw-r--r-- | generic/tclBasic.c | 24 |
1 files changed, 22 insertions, 2 deletions
diff --git a/generic/tclBasic.c b/generic/tclBasic.c index 314b5fc..c3ab871 100644 --- a/generic/tclBasic.c +++ b/generic/tclBasic.c @@ -1967,7 +1967,8 @@ Tcl_CreateCommand( * * Side effects: * If a command named "cmdName" already exists for interp, it is - * first deleted. Then the new command is created from the arguments. + * first deleted. Then the new command is created from the arguments. + * [***] (See below for exception). * * In the future, during bytecode evaluation when "cmdName" is seen as * the name of a command by Tcl_EvalObj or Tcl_Eval, the object-based @@ -2034,8 +2035,27 @@ Tcl_CreateObjCommand( if (!isNew) { cmdPtr = Tcl_GetHashValue(hPtr); + /* Command already exists. */ + + /* + * [***] This is wrong. See Tcl Bug a16752c252. + * However, this buggy behavior is kept under particular + * circumstances to accommodate deployed binaries of the + * "tclcompiler" program. http://sourceforge.net/projects/tclpro/ + * that crash if the bug is fixed. + */ + + if (cmdPtr->objProc == TclInvokeStringCommand + && cmdPtr->clientData == clientData + && cmdPtr->deleteData == clientData + && cmdPtr->deleteProc == deleteProc) { + cmdPtr->objProc = proc; + cmdPtr->objClientData = clientData; + return (Tcl_Command) cmdPtr; + } + /* - * Command already exists; delete it. Be careful to preserve any + * Otherwise, we delete the old command. Be careful to preserve any * existing import links so we can restore them down below. That way, * you can redefine a command and its import status will remain * intact. |