diff options
author | dgp <dgp@users.sourceforge.net> | 2023-08-21 18:07:48 (GMT) |
---|---|---|
committer | dgp <dgp@users.sourceforge.net> | 2023-08-21 18:07:48 (GMT) |
commit | 1ec6598ede90826c668a7d40db73a95ef3a3edb8 (patch) | |
tree | 4d5b46fc9fa4ddd3aed2224d86f66c65a659bb0f /generic/tclEnsemble.c | |
parent | 8f0801033282ae8543f09d6e82509d8e1ef9122e (diff) | |
download | tcl-1ec6598ede90826c668a7d40db73a95ef3a3edb8.zip tcl-1ec6598ede90826c668a7d40db73a95ef3a3edb8.tar.gz tcl-1ec6598ede90826c668a7d40db73a95ef3a3edb8.tar.bz2 |
The experiment deployment of TclDuplicatePureObj() has been reverted from
the trunk. This branch attempts to prepare a reversion for the
core-8-branch also, via a cherrypick and resolution of conflicts.
Starting an experiment in one new release to reject it
in the next is at best odd. Also, valgrind test runs of core-8-branch
show memory leaks with TclDuplicatePureObj() on the stack trace. This
checkin shows a clean valgrind run.
There are three test failures on this checkin, which I hope someone versed
in the ArithSeries work can resolve. They are the tests:
lseq-3.14
lseq-4.19
lseq-bug-54329e39c7
merge bug-bc7ddc7944 (revert use of TclDuplicatePureObj)
Diffstat (limited to 'generic/tclEnsemble.c')
-rw-r--r-- | generic/tclEnsemble.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/generic/tclEnsemble.c b/generic/tclEnsemble.c index 610198c..b946a84 100644 --- a/generic/tclEnsemble.c +++ b/generic/tclEnsemble.c @@ -1900,11 +1900,7 @@ NsEnsembleImplementationCmdNR( TclListObjLengthM(NULL, prefixObj, &prefixObjc); if (objc == 2) { - copyPtr = TclDuplicatePureObj( - interp, prefixObj, &tclListType); - if (!copyPtr) { - return TCL_ERROR; - } + copyPtr = TclListObjCopy(NULL, prefixObj); } else { copyPtr = Tcl_NewListObj(objc - 2 + prefixObjc, NULL); Tcl_ListObjAppendList(NULL, copyPtr, prefixObj); |