diff options
| author | mig <mig> | 2013-06-03 16:52:48 (GMT) |
|---|---|---|
| committer | mig <mig> | 2013-06-03 16:52:48 (GMT) |
| commit | bcc20b58f79b107e5877ba74855fd4f5b6f567df (patch) | |
| tree | 0538ed9c955879fe921c239527c88bfab0677094 /generic/tclExecute.c | |
| parent | f164a024d685eded1136cd790f655acfea3ace93 (diff) | |
| parent | 312d727024ac9e43d8989d411361cb1d0b50b9b5 (diff) | |
| download | tcl-bcc20b58f79b107e5877ba74855fd4f5b6f567df.zip tcl-bcc20b58f79b107e5877ba74855fd4f5b6f567df.tar.gz tcl-bcc20b58f79b107e5877ba74855fd4f5b6f567df.tar.bz2 | |
fix for perf bug detected by Kieran (https://groups.google.com/forum/?fromgroups#!topic/comp.lang.tcl/vfpI3bc-DkQ)
Diffstat (limited to 'generic/tclExecute.c')
| -rw-r--r-- | generic/tclExecute.c | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/generic/tclExecute.c b/generic/tclExecute.c index 7c645e7..8c87364 100644 --- a/generic/tclExecute.c +++ b/generic/tclExecute.c @@ -2142,11 +2142,6 @@ TEBCresume( CACHE_STACK_INFO(); if (result == TCL_OK) { -#ifndef TCL_COMPILE_DEBUG - if (*pc == INST_POP) { - NEXT_INST_V(1, cleanup, 0); - } -#endif /* * Push the call's object result and continue execution with the * next instruction. @@ -2155,8 +2150,6 @@ TEBCresume( TRACE_WITH_OBJ(("%u => ... after \"%.20s\": TCL_OK, result=", objc, cmdNameBuf), Tcl_GetObjResult(interp)); - objResultPtr = Tcl_GetObjResult(interp); - /* * Reset the interp's result to avoid possible duplications of * large objects [Bug 781585]. We do not call Tcl_ResetResult to @@ -2168,9 +2161,16 @@ TEBCresume( * the refCount it had in its role of iPtr->objResultPtr. */ + objResultPtr = Tcl_GetObjResult(interp); TclNewObj(objPtr); Tcl_IncrRefCount(objPtr); iPtr->objResultPtr = objPtr; +#ifndef TCL_COMPILE_DEBUG + if (*pc == INST_POP) { + TclDecrRefCount(objResultPtr); + NEXT_INST_V(1, cleanup, 0); + } +#endif NEXT_INST_V(0, cleanup, -1); } |