diff options
| author | dgp <dgp@users.sourceforge.net> | 2004-10-06 14:59:00 (GMT) |
|---|---|---|
| committer | dgp <dgp@users.sourceforge.net> | 2004-10-06 14:59:00 (GMT) |
| commit | 604e737b0d1ae40d2f45da85bb5dd7cbf096cad7 (patch) | |
| tree | 71a0e0114969e45230d047cb6fb0374e8f243c37 /generic/tclFCmd.c | |
| parent | e6efab5e75a4359cf171db3cde79672fd14ecfbc (diff) | |
| download | tcl-604e737b0d1ae40d2f45da85bb5dd7cbf096cad7.zip tcl-604e737b0d1ae40d2f45da85bb5dd7cbf096cad7.tar.gz tcl-604e737b0d1ae40d2f45da85bb5dd7cbf096cad7.tar.bz2 | |
* generic/tclBasic.c:
* generic/tclBinary.c:
* generic/tclCmdAH.c:
* generic/tclCmdIL.c:
* generic/tclCmdMZ.c:
* generic/tclCompExpr.c:
* generic/tclDictObj.c:
* generic/tclEncoding.c:
* generic/tclExecute.c:
* generic/tclFCmd.c:
* generic/tclHistory.c:
* generic/tclIndexObj.c:
* generic/tclInterp.c:
It is a poor practice to directly set or append to the value
of the objResult of an interp, because that value might be
shared, and in that circumstance a Tcl_Panic() will be the
result. Searched for example of this practice and replaced
with safer alternatives, often using the Tcl_AppendResult()
routine that dkf just rehabilitated.
Diffstat (limited to 'generic/tclFCmd.c')
| -rw-r--r-- | generic/tclFCmd.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/generic/tclFCmd.c b/generic/tclFCmd.c index 3d0bb95..17959fc 100644 --- a/generic/tclFCmd.c +++ b/generic/tclFCmd.c @@ -9,7 +9,7 @@ * See the file "license.terms" for information on usage and redistribution * of this file, and for a DISCLAIMER OF ALL WARRANTIES. * - * RCS: @(#) $Id: tclFCmd.c,v 1.27 2004/10/06 13:09:43 dkf Exp $ + * RCS: @(#) $Id: tclFCmd.c,v 1.28 2004/10/06 14:59:02 dgp Exp $ */ #include "tclInt.h" @@ -936,9 +936,8 @@ TclFileAttrsCmd(interp, objc, objv) * There was an error, probably that the filePtr is * not accepted by any filesystem */ - Tcl_AppendStringsToObj(Tcl_GetObjResult(interp), - "could not read \"", Tcl_GetString(filePtr), - "\": ", Tcl_PosixError(interp), + Tcl_AppendResult(interp, "could not read \"", + Tcl_GetString(filePtr), "\": ", Tcl_PosixError(interp), (char *) NULL); return TCL_ERROR; } |