diff options
| author | das <das> | 2004-11-11 01:18:07 (GMT) |
|---|---|---|
| committer | das <das> | 2004-11-11 01:18:07 (GMT) |
| commit | a0d4eac5974045d55b361a5e2ff674fffac3eb54 (patch) | |
| tree | b7ff7195c99b973bfa4111030d0ac0a9404feb6f /generic/tclListObj.c | |
| parent | 855a4dd4649f658cd37ce56e3f87cce584fbde47 (diff) | |
| download | tcl-a0d4eac5974045d55b361a5e2ff674fffac3eb54.zip tcl-a0d4eac5974045d55b361a5e2ff674fffac3eb54.tar.gz tcl-a0d4eac5974045d55b361a5e2ff674fffac3eb54.tar.bz2 | |
* generic/tclListObj.c (Tcl_ListObjReplace): use memmove() instead
of manual copy loop to shift list elements. Decreases time spent in
Tcl_ListObjReplace() from 5.2% to 1.7% of overall runtime of
tclbench on a ppc 7455 (i.e. 200% speed increase). [Patch 1064243]
* generic/tclHash.c: hoisted some constant pointer dereferences out
of loops to eliminate redundant loads that the gcc optimizer didn't
deal with. Decreases time spend in Tcl_FindHashEntry() by 10% over a
full run of the tcl testuite on a ppc 7455. [Patch 1064243]
Diffstat (limited to 'generic/tclListObj.c')
| -rw-r--r-- | generic/tclListObj.c | 16 |
1 files changed, 4 insertions, 12 deletions
diff --git a/generic/tclListObj.c b/generic/tclListObj.c index cdd8cb9..446a67e 100644 --- a/generic/tclListObj.c +++ b/generic/tclListObj.c @@ -11,7 +11,7 @@ * See the file "license.terms" for information on usage and redistribution * of this file, and for a DISCLAIMER OF ALL WARRANTIES. * - * RCS: @(#) $Id: tclListObj.c,v 1.13 2002/01/07 23:09:13 dgp Exp $ + * RCS: @(#) $Id: tclListObj.c,v 1.13.4.1 2004/11/11 01:18:07 das Exp $ */ #include "tclInt.h" @@ -680,17 +680,9 @@ Tcl_ListObjReplace(interp, listPtr, first, count, objc, objv) if ((numAfterLast > 0) && (shift != 0)) { Tcl_Obj **src, **dst; - if (shift < 0) { - for (src = elemPtrs + start, dst = src + shift; - numAfterLast > 0; numAfterLast--, src++, dst++) { - *dst = *src; - } - } else { - for (src = elemPtrs + numElems - 1, dst = src + shift; - numAfterLast > 0; numAfterLast--, src--, dst--) { - *dst = *src; - } - } + src = elemPtrs + start; dst = src + shift; + memmove((VOID*) dst, (VOID*) src, + (size_t) (numAfterLast * sizeof(Tcl_Obj*))); } /* |