diff options
author | dgp <dgp@noemail.net> | 2010-03-29 21:57:33 (GMT) |
---|---|---|
committer | dgp <dgp@noemail.net> | 2010-03-29 21:57:33 (GMT) |
commit | 3ec72336f6b6d3b047903b671fe96922b70e003a (patch) | |
tree | 797731259de846223c51b5e5170468b9964f4098 /generic/tclStringObj.c | |
parent | ec2217a83718b4d78cf3d5b0a2a3a9ae0b987dbf (diff) | |
download | tcl-3ec72336f6b6d3b047903b671fe96922b70e003a.zip tcl-3ec72336f6b6d3b047903b671fe96922b70e003a.tar.gz tcl-3ec72336f6b6d3b047903b671fe96922b70e003a.tar.bz2 |
* generic/tclStringObj.c: Fix array overrun in test format-1.12
caught by valgrind testing.
FossilOrigin-Name: 8775fff1dc44b6e080cabaffc15b47d49a16189a
Diffstat (limited to 'generic/tclStringObj.c')
-rw-r--r-- | generic/tclStringObj.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/generic/tclStringObj.c b/generic/tclStringObj.c index ffa51f8..ab6a600 100644 --- a/generic/tclStringObj.c +++ b/generic/tclStringObj.c @@ -33,7 +33,7 @@ * See the file "license.terms" for information on usage and redistribution of * this file, and for a DISCLAIMER OF ALL WARRANTIES. * - * RCS: @(#) $Id: tclStringObj.c,v 1.70.2.19 2010/01/18 09:50:57 dkf Exp $ */ + * RCS: @(#) $Id: tclStringObj.c,v 1.70.2.20 2010/03/29 21:57:33 dgp Exp $ */ #include "tclInt.h" #include "tommath.h" @@ -2275,7 +2275,7 @@ Tcl_AppendFormatToObj( int digitOffset; if (useBig && big.used) { - if ((size_t) shift < + if (index < big.used && (size_t) shift < CHAR_BIT*sizeof(Tcl_WideUInt) - DIGIT_BIT) { bits |= (((Tcl_WideUInt)big.dp[index++]) <<shift); shift += DIGIT_BIT; |