summaryrefslogtreecommitdiffstats
path: root/generic/tclStringObj.c
diff options
context:
space:
mode:
authorjan.nijtmans <nijtmans@users.sourceforge.net>2025-02-06 22:21:00 (GMT)
committerjan.nijtmans <nijtmans@users.sourceforge.net>2025-02-06 22:21:00 (GMT)
commit9e6350deb8b550923293abba2e18582483d56356 (patch)
treea34ac6b04affc54301d6f953cf5953c0210906fd /generic/tclStringObj.c
parent1350860121c216d4de16b531a9e615e303ccbc78 (diff)
downloadtcl-9e6350deb8b550923293abba2e18582483d56356.zip
tcl-9e6350deb8b550923293abba2e18582483d56356.tar.gz
tcl-9e6350deb8b550923293abba2e18582483d56356.tar.bz2
Change implementation, based on community feedback
Diffstat (limited to 'generic/tclStringObj.c')
-rw-r--r--generic/tclStringObj.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/generic/tclStringObj.c b/generic/tclStringObj.c
index 3204a24..0381e88 100644
--- a/generic/tclStringObj.c
+++ b/generic/tclStringObj.c
@@ -1390,7 +1390,7 @@ Tcl_AppendObjToObj(
}
if (TclIsPureByteArray(appendObjPtr)
- && (TclIsPureByteArray(objPtr) || Tcl_IsEmpty(objPtr))) {
+ && (TclIsPureByteArray(objPtr) || objPtr->bytes == &tclEmptyString)) {
/*
* Both bytearray objects are pure, so the second internal bytearray value
* can be appended to the first, with no need to modify the "bytes" field.
@@ -4384,10 +4384,10 @@ Tcl_IsEmpty(
Tcl_Obj *objPtr)
{
if (objPtr == NULL) {
- return -1;
+ Tcl_Panic("%s: objPtr is NULL", "Tcl_IsEmpty");
}
- if (objPtr->bytes && !objPtr->length) {
- return 1;
+ if (objPtr->bytes) {
+ return !objPtr->length;
}
if (TclHasInternalRep(objPtr, &tclDictType)) {
/* Since "dict" doesn't have a lengthProc */