diff options
| author | jan.nijtmans <nijtmans@users.sourceforge.net> | 2017-06-28 13:32:16 (GMT) |
|---|---|---|
| committer | jan.nijtmans <nijtmans@users.sourceforge.net> | 2017-06-28 13:32:16 (GMT) |
| commit | 073ff3c5fe40eeac93ae5508b647a7019006f431 (patch) | |
| tree | 4c8927c5cedcda53ca2f5d1b53fa6cdd6b812911 /generic/tclStringObj.c | |
| parent | 2223757a3583e4541ae5814fc6e7059e6048e480 (diff) | |
| download | tcl-073ff3c5fe40eeac93ae5508b647a7019006f431.zip tcl-073ff3c5fe40eeac93ae5508b647a7019006f431.tar.gz tcl-073ff3c5fe40eeac93ae5508b647a7019006f431.tar.bz2 | |
Eliminate use of (expensive) Tcl_UtfToUpper() from "format": Just generate the expected uppercase characters right away from the start. No change in functionality, just code optimization.
Diffstat (limited to 'generic/tclStringObj.c')
| -rw-r--r-- | generic/tclStringObj.c | 19 |
1 files changed, 9 insertions, 10 deletions
diff --git a/generic/tclStringObj.c b/generic/tclStringObj.c index 4a3b6f1..c84b500 100644 --- a/generic/tclStringObj.c +++ b/generic/tclStringObj.c @@ -2027,8 +2027,11 @@ Tcl_AppendFormatToObj( segmentLimit -= 1; precision--; break; - case 'x': case 'X': + Tcl_AppendToObj(segment, "0X", 2); + segmentLimit -= 2; + break; + case 'x': Tcl_AppendToObj(segment, "0x", 2); segmentLimit -= 2; break; @@ -2192,7 +2195,11 @@ Tcl_AppendFormatToObj( } digitOffset = (int) (bits % base); if (digitOffset > 9) { - bytes[numDigits] = 'a' + digitOffset - 10; + if (ch == 'X') { + bytes[numDigits] = 'A' + digitOffset - 10; + } else { + bytes[numDigits] = 'a' + digitOffset - 10; + } } else { bytes[numDigits] = '0' + digitOffset; } @@ -2314,14 +2321,6 @@ Tcl_AppendFormatToObj( goto error; } - switch (ch) { - case 'E': - case 'G': - case 'X': { - Tcl_SetObjLength(segment, Tcl_UtfToUpper(TclGetString(segment))); - } - } - if (width>0 && numChars<0) { numChars = Tcl_GetCharLength(segment); } |