diff options
| author | jan.nijtmans <nijtmans@users.sourceforge.net> | 2024-04-11 12:35:07 (GMT) |
|---|---|---|
| committer | jan.nijtmans <nijtmans@users.sourceforge.net> | 2024-04-11 12:35:07 (GMT) |
| commit | 2943a2ce12be16a91b9d90058cc0ea8ec707e5e2 (patch) | |
| tree | a046e1fa7bfba10d49ad3d2829fc79ebd52b2f29 /generic/tclTest.c | |
| parent | 0dbb43436b849bbbc8c3f8f055e01d80936c206b (diff) | |
| download | tcl-2943a2ce12be16a91b9d90058cc0ea8ec707e5e2.zip tcl-2943a2ce12be16a91b9d90058cc0ea8ec707e5e2.tar.gz tcl-2943a2ce12be16a91b9d90058cc0ea8ec707e5e2.tar.bz2 | |
Use Tcl_NewBooleanObj for booleans; we should say what we mean. Fix sentinels and type-casts.
Diffstat (limited to 'generic/tclTest.c')
| -rw-r--r-- | generic/tclTest.c | 18 |
1 files changed, 7 insertions, 11 deletions
diff --git a/generic/tclTest.c b/generic/tclTest.c index 692034b..1f35fd7 100644 --- a/generic/tclTest.c +++ b/generic/tclTest.c @@ -599,8 +599,8 @@ Tcltest_Init( Tcl_CreateCommand(interp, "testtranslatefilename", TesttranslatefilenameCmd, NULL, NULL); Tcl_CreateCommand(interp, "testupvar", TestupvarCmd, NULL, NULL); - Tcl_CreateMathFunc(interp, "T1", 0, NULL, TestMathFunc, (ClientData) 123); - Tcl_CreateMathFunc(interp, "T2", 0, NULL, TestMathFunc, (ClientData) 345); + Tcl_CreateMathFunc(interp, "T1", 0, NULL, TestMathFunc, (ClientData)123); + Tcl_CreateMathFunc(interp, "T2", 0, NULL, TestMathFunc, (ClientData)345); Tcl_CreateCommand(interp, "testmainthread", TestmainthreadCmd, NULL, NULL); Tcl_CreateCommand(interp, "testsetmainloop", TestsetmainloopCmd, @@ -985,7 +985,7 @@ TestcmdinfoCmd( return TCL_ERROR; } if (strcmp(argv[1], "create") == 0) { - Tcl_CreateCommand(interp, argv[2], CmdProc1, (ClientData) "original", + Tcl_CreateCommand(interp, argv[2], CmdProc1, (ClientData)"original", CmdDelProc1); } else if (strcmp(argv[1], "delete") == 0) { Tcl_DStringInit(&delString); @@ -1022,16 +1022,12 @@ TestcmdinfoCmd( } } else if (strcmp(argv[1], "modify") == 0) { info.proc = CmdProc2; - info.clientData = (ClientData) "new_command_data"; + info.clientData = (ClientData)"new_command_data"; info.objProc = NULL; info.objClientData = NULL; info.deleteProc = CmdDelProc2; - info.deleteData = (ClientData) "new_delete_data"; - if (Tcl_SetCommandInfo(interp, argv[2], &info) == 0) { - Tcl_SetObjResult(interp, Tcl_NewIntObj(0)); - } else { - Tcl_SetObjResult(interp, Tcl_NewIntObj(1)); - } + info.deleteData = (ClientData)"new_delete_data"; + Tcl_SetObjResult(interp, Tcl_NewBooleanObj(Tcl_SetCommandInfo(interp, argv[2], &info))); } else { Tcl_AppendResult(interp, "bad option \"", argv[1], "\": must be create, delete, get, or modify", NULL); @@ -1115,7 +1111,7 @@ TestcmdtokenCmd( } if (strcmp(argv[1], "create") == 0) { token = Tcl_CreateCommand(interp, argv[2], CmdProc1, - (ClientData) "original", NULL); + (ClientData)"original", NULL); snprintf(buf, sizeof(buf), "%p", (void *)token); Tcl_SetResult(interp, buf, TCL_VOLATILE); } else if (strcmp(argv[1], "name") == 0) { |