summaryrefslogtreecommitdiffstats
path: root/generic
diff options
context:
space:
mode:
authorsebres <sebres@users.sourceforge.net>2018-05-08 10:16:26 (GMT)
committersebres <sebres@users.sourceforge.net>2018-05-08 10:16:26 (GMT)
commit47e9dbdc37939a6e874afd15d6586864649f23c7 (patch)
tree7ad5a08eaddeac63299223546fe2f9d651a91292 /generic
parent8fd1568405890e88c8efda4776fdff92e570b1f1 (diff)
downloadtcl-47e9dbdc37939a6e874afd15d6586864649f23c7.zip
tcl-47e9dbdc37939a6e874afd15d6586864649f23c7.tar.gz
tcl-47e9dbdc37939a6e874afd15d6586864649f23c7.tar.bz2
prevents UB/segfault by unexpected return-code (not -1/0/1) and avoid warnings like:
tclCmdMZ.c:2815:15: warning: `s1` may be used uninitialized in this function [-Wmaybe-uninitialized] s1len = Tcl_NumUtfChars(s1, s1len); ^~~~~~~~~~~~~~~~~~~~~~~~~~
Diffstat (limited to 'generic')
-rw-r--r--generic/tclCmdMZ.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/generic/tclCmdMZ.c b/generic/tclCmdMZ.c
index bc798b7..8530719 100644
--- a/generic/tclCmdMZ.c
+++ b/generic/tclCmdMZ.c
@@ -2772,6 +2772,7 @@ int TclStringCmp (
match = -1;
goto matchdone;
case 1:
+ default: /* avoid warn: `s2` may be used uninitialized */
match = 0;
goto matchdone;
}
@@ -2786,6 +2787,7 @@ int TclStringCmp (
match = 1;
goto matchdone;
case 1:
+ default: /* avoid warn: `s1` may be used uninitialized */
match = 0;
goto matchdone;
}