diff options
| author | dgp <dgp@users.sourceforge.net> | 2013-03-11 12:55:29 (GMT) |
|---|---|---|
| committer | dgp <dgp@users.sourceforge.net> | 2013-03-11 12:55:29 (GMT) |
| commit | df4d161b0f8447292465330d03550426006fd13c (patch) | |
| tree | c0d4f0ded6d161132b16a0b6ec9e31db28a0b8a9 /generic | |
| parent | a1f9566f74e6769c201e4040540880eb58e0767c (diff) | |
| parent | 53d74314391e46506521ca790914b8610611c095 (diff) | |
| download | tcl-df4d161b0f8447292465330d03550426006fd13c.zip tcl-df4d161b0f8447292465330d03550426006fd13c.tar.gz tcl-df4d161b0f8447292465330d03550426006fd13c.tar.bz2 | |
3607246,3607372 Unbalanced refcounts of literals in the global literal table.
Diffstat (limited to 'generic')
| -rw-r--r-- | generic/tclCompile.c | 2 | ||||
| -rw-r--r-- | generic/tclLiteral.c | 9 |
2 files changed, 8 insertions, 3 deletions
diff --git a/generic/tclCompile.c b/generic/tclCompile.c index 5427759..0e98385 100644 --- a/generic/tclCompile.c +++ b/generic/tclCompile.c @@ -2596,7 +2596,7 @@ TclInitByteCodeObj( codePtr->objArrayPtr[i] = Tcl_NewStringObj(bytes, numBytes); Tcl_IncrRefCount(codePtr->objArrayPtr[i]); - Tcl_DecrRefCount(objPtr); + TclReleaseLiteral((Tcl_Interp *)iPtr, objPtr); } else { codePtr->objArrayPtr[i] = fetched; } diff --git a/generic/tclLiteral.c b/generic/tclLiteral.c index ce258cf..11da6f8 100644 --- a/generic/tclLiteral.c +++ b/generic/tclLiteral.c @@ -1010,8 +1010,13 @@ TclInvalidateCmdLiteral( Tcl_Obj *literalObjPtr = TclCreateLiteral(iPtr, (char *) name, strlen(name), -1, NULL, nsPtr, 0, NULL); - if (literalObjPtr != NULL && literalObjPtr->typePtr == &tclCmdNameType) { - TclFreeIntRep(literalObjPtr); + if (literalObjPtr != NULL) { + if (literalObjPtr->typePtr == &tclCmdNameType) { + TclFreeIntRep(literalObjPtr); + } + /* Balance the refcount effects of TclCreateLiteral() above */ + Tcl_IncrRefCount(literalObjPtr); + TclReleaseLiteral(interp, literalObjPtr); } } |