diff options
author | andreask <andreask> | 2013-01-22 19:24:25 (GMT) |
---|---|---|
committer | andreask <andreask> | 2013-01-22 19:24:25 (GMT) |
commit | 6d8a36d84d2843681302604a082e2f787c3c3674 (patch) | |
tree | 9d3b4ee05189203cf7ce94b4b2a6d2d911aaa18d /tests/async.test | |
parent | 296aebbd6ee092a25741684fa37ee31ef5a3e222 (diff) | |
download | tcl-6d8a36d84d2843681302604a082e2f787c3c3674.zip tcl-6d8a36d84d2843681302604a082e2f787c3c3674.tar.gz tcl-6d8a36d84d2843681302604a082e2f787c3c3674.tar.bz2 |
Contribution by Patrick Fradin <patrick.fradin@planar.com>
Quoting his mail:
<pre>
==========================================================
Hi Jeff,
I spent some of my time to contribute to the TclTk community ! I'm in
late for Christmas gift but like we said in French : "Mieux vaut tard
que jamais". ;-)
I've use TclDevKit 5.3.0 tclchecker to analyse TclTk code in Tcl and
Tk library directories (library, tools and tests) to correct a lot of
warnings and few errors. (encapsulate some expr, use 'chan xxx'
instead of fconfigure, fileevent...)
I've made some improvements too :
Examples :
- Use 'lassign' instead of many 'lindex' of 'foreach/break' loop.
- Use 'in' or 'ni' operators instead of 'lsearch -exact' or to
factorise some eq/ne && / || tests.
- Use 'eq' or 'ne' to tests strings instead of '==' or '!='.
- Use 'unset -nocomplain' to avoid 'catch {unset...}'.
- Remove some useless catch around 'destroy' calls.
- Use expand {*} instead of 'eval'. Don't touch a lot of code because
I don't know all structs and lists. I think it could be a greater
improvement to reduce 'eval' calls.
Due to previous experience, I dot not change any indentation ! ;-)
==========================================================
</pre>
Diffstat (limited to 'tests/async.test')
-rw-r--r-- | tests/async.test | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/async.test b/tests/async.test index cb67cc2..03cacd3 100644 --- a/tests/async.test +++ b/tests/async.test @@ -11,7 +11,7 @@ # See the file "license.terms" for information on usage and redistribution # of this file, and for a DISCLAIMER OF ALL WARRANTIES. -if {[lsearch [namespace children] ::tcltest] == -1} { +if {"::tcltest" ni [namespace children]} { package require tcltest namespace import -force ::tcltest::* } |