summaryrefslogtreecommitdiffstats
path: root/tests
diff options
context:
space:
mode:
authorandreas_kupries <akupries@shaw.ca>2006-09-28 20:54:45 (GMT)
committerandreas_kupries <akupries@shaw.ca>2006-09-28 20:54:45 (GMT)
commit858a806396de6a90554a6ebd0ce288b554f61ac7 (patch)
treeebfbd2f782bca8a075cfad1ed8604686266384db /tests
parent341cfa533b51784f8cb9183ec8e2ed6fe6a26e32 (diff)
downloadtcl-858a806396de6a90554a6ebd0ce288b554f61ac7.zip
tcl-858a806396de6a90554a6ebd0ce288b554f61ac7.tar.gz
tcl-858a806396de6a90554a6ebd0ce288b554f61ac7.tar.bz2
* generic/tclPkg.c (CompareVersions): Bugfix. Check string lengths
* tests/pkg.test: before comparison. The shorter string is the smaller number. Added testcases as well. Interestingly all existing test cases for vcompare compared numbers of the same length with each other. See [SF Tcl Bug 1563836].
Diffstat (limited to 'tests')
-rw-r--r--tests/pkg.test6
1 files changed, 4 insertions, 2 deletions
diff --git a/tests/pkg.test b/tests/pkg.test
index ee1c839..2bf1ebe 100644
--- a/tests/pkg.test
+++ b/tests/pkg.test
@@ -11,7 +11,7 @@
# See the file "license.terms" for information on usage and redistribution
# of this file, and for a DISCLAIMER OF ALL WARRANTIES.
#
-# RCS: @(#) $Id: pkg.test,v 1.18 2006/09/27 20:22:40 andreas_kupries Exp $
+# RCS: @(#) $Id: pkg.test,v 1.19 2006/09/28 20:54:46 andreas_kupries Exp $
if {[lsearch [namespace children] ::tcltest] == -1} {
package require tcltest 2
@@ -946,6 +946,9 @@ foreach {r p vs vc} {
8.5.0 8.6a0 1 -1
8.5.0 8.6b0 1 -1
8.5.0 8.6.0 1 -1
+ 10 8 0 1
+ 8 10 0 -1
+ 0.0.1.2 0.1.2 1 -1
} {
test package-vsatisfies-1.$n {package vsatisfies} {
package vsatisfies $p $r
@@ -962,7 +965,6 @@ test package-vcompare-2.0 {package vcompare at 32bit boundary} {
package vcompare [expr {1<<31}] [expr {(1<<31)-1}]
} 1
-
set n 0
foreach {required provided satisfied} {
8.5a0- 8.5a5 1