diff options
author | Miguel Sofer <miguel.sofer@gmail.com> | 2005-11-14 00:41:05 (GMT) |
---|---|---|
committer | Miguel Sofer <miguel.sofer@gmail.com> | 2005-11-14 00:41:05 (GMT) |
commit | 9264d5ca1bd013c78fc5f822303ce4c03bde8c74 (patch) | |
tree | 6ca36e542384ebbf3ca170a55c48aae2d07c3394 /tests | |
parent | d6c73ab77833ab9488ab9930031dd0851a931cb4 (diff) | |
download | tcl-9264d5ca1bd013c78fc5f822303ce4c03bde8c74.zip tcl-9264d5ca1bd013c78fc5f822303ce4c03bde8c74.tar.gz tcl-9264d5ca1bd013c78fc5f822303ce4c03bde8c74.tar.bz2 |
* generic/tclInt.h:
* generic/tclNamesp.c:
* tests/namespace.test: fix for bugs #1354540 and #1355942. The
new tests 7.3-6 and the modified 51.13 fail due to the unrelated
[Bug 1355342]
* tests/trace.test: added tests 20.13-16 for [Bug 1355342]
Diffstat (limited to 'tests')
-rw-r--r-- | tests/namespace.test | 42 | ||||
-rw-r--r-- | tests/trace.test | 24 |
2 files changed, 60 insertions, 6 deletions
diff --git a/tests/namespace.test b/tests/namespace.test index 947beb6..ede0e00 100644 --- a/tests/namespace.test +++ b/tests/namespace.test @@ -11,7 +11,7 @@ # See the file "license.terms" for information on usage and redistribution # of this file, and for a DISCLAIMER OF ALL WARRANTIES. # -# RCS: @(#) $Id: namespace.test,v 1.46 2005/07/05 17:33:07 dgp Exp $ +# RCS: @(#) $Id: namespace.test,v 1.47 2005/11/14 00:41:05 msofer Exp $ if {[lsearch [namespace children] ::tcltest] == -1} { package require tcltest 2 @@ -133,6 +133,37 @@ test namespace-7.2 {Tcl_DeleteNamespace, no active call frames in ns} { } list [test_ns_2::p] [namespace delete test_ns_2] } {::test_ns_2 {}} +test namespace-7.3 {recursive Tcl_DeleteNamespace, active call frames in ns} { + namespace eval test_ns_2 { + set x 1 + trace add variable x unset "namespace delete [namespace current];#" + namespace delete [namespace current] + } +} {} +test namespace-7.4 {recursive Tcl_DeleteNamespace, active call frames in ns} { + # Currently fails due to [Bug 1355342] + namespace eval test_ns_2 { + proc x {} {} + trace add command x delete "namespace delete [namespace current];#" + namespace delete [namespace current] + } +} {} +test namespace-7.5 {recursive Tcl_DeleteNamespace, no active call frames in ns} { + namespace eval test_ns_2 { + set x 1 + trace add variable x unset "namespace delete [namespace current];#" + } + namespace delete test_ns_2 +} {} +test namespace-7.6 {recursive Tcl_DeleteNamespace, active call frames in ns} { + # Currently fails due to [Bug 1355342] + namespace eval test_ns_2 { + proc x {} {} + trace add command x delete "namespace delete [namespace current];#" + } + namespace delete test_ns_2 +} {} + test namespace-8.1 {TclTeardownNamespace, delete global namespace} { catch {interp delete test_interp} @@ -2278,8 +2309,9 @@ test namespace-51.12 {name resolution path control} -body { catch {namespace delete ::test_ns_3} catch {namespace delete ::test_ns_4} } -# Fails right now due to unrelated bug... -test namespace-51.13 {name resolution path control} -constraints knownBug -body { + +test namespace-51.13 {name resolution path control} -body { + # Currently fails due to [Bug 1355342] set ::result {} namespace eval ::test_ns_1 { proc foo {} {lappend ::result 1} @@ -2302,8 +2334,8 @@ test namespace-51.13 {name resolution path control} -constraints knownBug -body } bar } - # Should the result be "2 {} {2 3 1 1}" instead? -} -result {2 {} {2 3 2 1}} -cleanup { + # Should the result be "2 {} {2 3 2 1}" instead? +} -result {2 {} {2 3 1 1}} -cleanup { catch {namespace delete ::test_ns_1} catch {namespace delete ::test_ns_2} catch {namespace delete ::test_ns_3} diff --git a/tests/trace.test b/tests/trace.test index befb0c8..7009503 100644 --- a/tests/trace.test +++ b/tests/trace.test @@ -11,7 +11,7 @@ # See the file "license.terms" for information on usage and redistribution # of this file, and for a DISCLAIMER OF ALL WARRANTIES. # -# RCS: @(#) $Id: trace.test,v 1.45 2005/11/07 10:17:59 msofer Exp $ +# RCS: @(#) $Id: trace.test,v 1.46 2005/11/14 00:41:06 msofer Exp $ if {[lsearch [namespace children] ::tcltest] == -1} { package require tcltest @@ -1484,6 +1484,28 @@ test trace-20.12 {delete trace renames command} { list [info commands foo] [info commands bar] [info commands someothername] } {{} {} {}} +test trace-20.13 {rename trace discards result [Bug 1355342]} { + proc foo {} {} + trace add command foo rename {set w Aha!;#} + list [rename foo bar] [rename bar {}] +} {{} {}} +test trace-20.14 {rename trace discards error result [Bug 1355342]} { + proc foo {} {} + trace add command foo rename {error} + list [rename foo bar] [rename bar {}] +} {{} {}} +test trace-20.15 {delete trace discards result [Bug 1355342]} { + proc foo {} {} + trace add command foo delete {set w Aha!;#} + rename foo {} +} {} +test trace-20.16 {delete trace discards error result [Bug 1355342]} { + proc foo {} {} + trace add command foo delete {error} + rename foo {} +} {} + + proc foo {b} { set a $b } |