Fix comment in tclOO.decls: tclOOStubLib.c is not generated by "make genstubs".

In pkgooa.c, check whether the internal TclOO stub table is initialized correctly as well, some internal simplifications and improved comments.

1 files changed, 16 insertions, 32 deletions

diff --git a/unix/dltest/pkgooa.c b/unix/dltest/pkgooa.c
index c0c1605..7b14ca0 100644
--- a/unix/dltest/pkgooa.c
+++ b/unix/dltest/pkgooa.c
@@ -11,24 +11,8 @@
  */
 
 #undef STATIC_BUILD
-#include "tclOO.h"
+#include "tclOOInt.h"
 #include <string.h>
-
-/*
- * TCL_STORAGE_CLASS is set unconditionally to DLLEXPORT because the
- * Pkgooa_Init declaration is in the source file itself, which is only
- * accessed when we are building a library.
- */
-#undef TCL_STORAGE_CLASS
-#define TCL_STORAGE_CLASS DLLEXPORT
-
-/*
- * Prototypes for procedures defined later in this file:
- */
-
-static int    Pkgooa_StubsOKObjCmd(ClientData clientData,
-		Tcl_Interp *interp, int objc, Tcl_Obj *const objv[]);
-
 
 /*
  *----------------------------------------------------------------------
@@ -80,26 +64,22 @@ Pkgooa_StubsOKObjCmd(
  *----------------------------------------------------------------------
  */
 
-static Tcl_Object copyObjectInstance(Tcl_Interp *interp,
-		Tcl_Object source, const char *name, const char *nameSpace)
-{
-	Tcl_Object result;
-	result = Tcl_CopyObjectInstance(interp, source, name, nameSpace);
-	if (result == NULL) {
-        Tcl_AppendResult(interp, "ERROR: copy failed.");
-	}
-	return result;
-}
-
 static TclOOStubs stubsCopy = {
     TCL_STUB_MAGIC,
     NULL,
-    copyObjectInstance
-    /* more entries here, but those are not
-     * needed for this test-case. */
+    /* It doesn't really matter what implementation of
+     * Tcl_CopyObjectInstance is put in the "pseudo"
+     * stub table, since the test-case never actually
+     * calls this function. All that matters is that it's
+     * a function with a different memory address than
+     * the real Tcl_CopyObjectInstance function in Tcl. */
+    (Tcl_Object (*) (Tcl_Interp *, Tcl_Object, const char *,
+	    const char *t)) Pkgooa_StubsOKObjCmd
+    /* More entries could be here, but those are not used
+     * for this test-case. So, being NULL is OK. */
 };
 
-EXTERN int
+extern DLLEXPORT int
 Pkgooa_Init(
     Tcl_Interp *interp)		/* Interpreter in which the package is to be
 				 * made available. */
@@ -129,6 +109,10 @@ Pkgooa_Init(
 	Tcl_AppendResult(interp, "TclOO stubs are not inialized");
 	return TCL_ERROR;
     }
+    if (tclOOIntStubsPtr == NULL) {
+	Tcl_AppendResult(interp, "TclOO internal stubs are not inialized");
+	return TCL_ERROR;
+    }
 
     /* Test case for Bug [f51efe99a7].
      *