diff options
Diffstat (limited to 'generic/tclCmdAH.c')
| -rw-r--r-- | generic/tclCmdAH.c | 3795 | 
1 files changed, 2171 insertions, 1624 deletions
| diff --git a/generic/tclCmdAH.c b/generic/tclCmdAH.c index c928224..d90a747 100644 --- a/generic/tclCmdAH.c +++ b/generic/tclCmdAH.c @@ -1,53 +1,109 @@ -/*  +/*   * tclCmdAH.c --   * - *	This file contains the top-level command routines for most of - *	the Tcl built-in commands whose names begin with the letters - *	A to H. + *	This file contains the top-level command routines for most of the Tcl + *	built-in commands whose names begin with the letters A to H.   *   * Copyright (c) 1987-1993 The Regents of the University of California.   * Copyright (c) 1994-1997 Sun Microsystems, Inc.   * - * See the file "license.terms" for information on usage and redistribution - * of this file, and for a DISCLAIMER OF ALL WARRANTIES. - * - * RCS: @(#) $Id: tclCmdAH.c,v 1.12 2000/01/21 02:25:26 hobbs Exp $ + * See the file "license.terms" for information on usage and redistribution of + * this file, and for a DISCLAIMER OF ALL WARRANTIES.   */  #include "tclInt.h" -#include "tclPort.h"  #include <locale.h> -typedef int (StatProc)_ANSI_ARGS_((CONST char *path, struct stat *buf)); +/* + * The state structure used by [foreach]. Note that the actual structure has + * all its working arrays appended afterwards so they can be allocated and + * freed in a single step. + */ + +struct ForeachState { +    Tcl_Obj *bodyPtr;		/* The script body of the command. */ +    int bodyIdx;		/* The argument index of the body. */ +    int j, maxj;		/* Number of loop iterations. */ +    int numLists;		/* Count of value lists. */ +    int *index;			/* Array of value list indices. */ +    int *varcList;		/* # loop variables per list. */ +    Tcl_Obj ***varvList;	/* Array of var name lists. */ +    Tcl_Obj **vCopyList;	/* Copies of var name list arguments. */ +    int *argcList;		/* Array of value list sizes. */ +    Tcl_Obj ***argvList;	/* Array of value lists. */ +    Tcl_Obj **aCopyList;	/* Copies of value list arguments. */ +    Tcl_Obj *resultList;	/* List of result values from the loop body, +				 * or NULL if we're not collecting them +				 * ([lmap] vs [foreach]). */ +};  /*   * Prototypes for local procedures defined in this file:   */ -static int		CheckAccess _ANSI_ARGS_((Tcl_Interp *interp, -			    Tcl_Obj *objPtr, int mode)); -static int		GetStatBuf _ANSI_ARGS_((Tcl_Interp *interp, -			    Tcl_Obj *objPtr, StatProc *statProc, -			    struct stat *statPtr)); -static char *		GetTypeFromMode _ANSI_ARGS_((int mode)); -static int		SplitPath _ANSI_ARGS_((Tcl_Interp *interp, -			    Tcl_Obj *objPtr, int *argcPtr, char ***argvPtr)); -static int		StoreStatData _ANSI_ARGS_((Tcl_Interp *interp, -			    char *varName, struct stat *statPtr)); -static char **		StringifyObjects _ANSI_ARGS_((int objc, -			    Tcl_Obj *CONST objv[])); +static int		CheckAccess(Tcl_Interp *interp, Tcl_Obj *pathPtr, +			    int mode); +static int		EncodingDirsObjCmd(ClientData dummy, +			    Tcl_Interp *interp, int objc, +			    Tcl_Obj *const objv[]); +static inline int	ForeachAssignments(Tcl_Interp *interp, +			    struct ForeachState *statePtr); +static inline void	ForeachCleanup(Tcl_Interp *interp, +			    struct ForeachState *statePtr); +static int		GetStatBuf(Tcl_Interp *interp, Tcl_Obj *pathPtr, +			    Tcl_FSStatProc *statProc, Tcl_StatBuf *statPtr); +static const char *	GetTypeFromMode(int mode); +static int		StoreStatData(Tcl_Interp *interp, Tcl_Obj *varName, +			    Tcl_StatBuf *statPtr); +static inline int	EachloopCmd(Tcl_Interp *interp, int collect, +			    int objc, Tcl_Obj *const objv[]); +static Tcl_NRPostProc	CatchObjCmdCallback; +static Tcl_NRPostProc	ExprCallback; +static Tcl_NRPostProc	ForSetupCallback; +static Tcl_NRPostProc	ForCondCallback; +static Tcl_NRPostProc	ForNextCallback; +static Tcl_NRPostProc	ForPostNextCallback; +static Tcl_NRPostProc	ForeachLoopStep; +static Tcl_NRPostProc	EvalCmdErrMsg; + +static Tcl_ObjCmdProc	BadFileSubcommand; +static Tcl_ObjCmdProc FileAttrAccessTimeCmd; +static Tcl_ObjCmdProc FileAttrIsDirectoryCmd; +static Tcl_ObjCmdProc FileAttrIsExecutableCmd; +static Tcl_ObjCmdProc FileAttrIsExistingCmd; +static Tcl_ObjCmdProc FileAttrIsFileCmd; +static Tcl_ObjCmdProc FileAttrIsOwnedCmd; +static Tcl_ObjCmdProc FileAttrIsReadableCmd; +static Tcl_ObjCmdProc FileAttrIsWritableCmd; +static Tcl_ObjCmdProc FileAttrLinkStatCmd; +static Tcl_ObjCmdProc FileAttrModifyTimeCmd; +static Tcl_ObjCmdProc FileAttrSizeCmd; +static Tcl_ObjCmdProc FileAttrStatCmd; +static Tcl_ObjCmdProc FileAttrTypeCmd; +static Tcl_ObjCmdProc FilesystemSeparatorCmd; +static Tcl_ObjCmdProc FilesystemVolumesCmd; +static Tcl_ObjCmdProc PathDirNameCmd; +static Tcl_ObjCmdProc PathExtensionCmd; +static Tcl_ObjCmdProc PathFilesystemCmd; +static Tcl_ObjCmdProc PathJoinCmd; +static Tcl_ObjCmdProc PathNativeNameCmd; +static Tcl_ObjCmdProc PathNormalizeCmd; +static Tcl_ObjCmdProc PathRootNameCmd; +static Tcl_ObjCmdProc PathSplitCmd; +static Tcl_ObjCmdProc PathTailCmd; +static Tcl_ObjCmdProc PathTypeCmd;  /*   *----------------------------------------------------------------------   *   * Tcl_BreakObjCmd --   * - *	This procedure is invoked to process the "break" Tcl command. - *	See the user documentation for details on what it does. + *	This procedure is invoked to process the "break" Tcl command. See the + *	user documentation for details on what it does.   * - *	With the bytecode compiler, this procedure is only called when - *	a command name is computed at runtime, and is "break" or the name - *	to which "break" was renamed: e.g., "set z break; $z" + *	With the bytecode compiler, this procedure is only called when a + *	command name is computed at runtime, and is "break" or the name to + *	which "break" was renamed: e.g., "set z break; $z"   *   * Results:   *	A standard Tcl result. @@ -60,11 +116,11 @@ static char **		StringifyObjects _ANSI_ARGS_((int objc,  	/* ARGSUSED */  int -Tcl_BreakObjCmd(dummy, interp, objc, objv) -    ClientData dummy;			/* Not used. */ -    Tcl_Interp *interp;			/* Current interpreter. */ -    int objc;				/* Number of arguments. */ -    Tcl_Obj *CONST objv[];		/* Argument objects. */ +Tcl_BreakObjCmd( +    ClientData dummy,		/* Not used. */ +    Tcl_Interp *interp,		/* Current interpreter. */ +    int objc,			/* Number of arguments. */ +    Tcl_Obj *const objv[])	/* Argument objects. */  {      if (objc != 1) {  	Tcl_WrongNumArgs(interp, 1, objv, NULL); @@ -78,8 +134,9 @@ Tcl_BreakObjCmd(dummy, interp, objc, objv)   *   * Tcl_CaseObjCmd --   * - *	This procedure is invoked to process the "case" Tcl command. - *	See the user documentation for details on what it does. + *	This procedure is invoked to process the "case" Tcl command. See the + *	user documentation for details on what it does. THIS COMMAND IS + *	OBSOLETE AND DEPRECATED. SLATED FOR REMOVAL IN TCL 9.0.   *   * Results:   *	A standard Tcl object result. @@ -92,29 +149,28 @@ Tcl_BreakObjCmd(dummy, interp, objc, objv)  	/* ARGSUSED */  int -Tcl_CaseObjCmd(dummy, interp, objc, objv) -    ClientData dummy;		/* Not used. */ -    Tcl_Interp *interp;		/* Current interpreter. */ -    int objc;			/* Number of arguments. */ -    Tcl_Obj *CONST objv[];	/* Argument objects. */ +Tcl_CaseObjCmd( +    ClientData dummy,		/* Not used. */ +    Tcl_Interp *interp,		/* Current interpreter. */ +    int objc,			/* Number of arguments. */ +    Tcl_Obj *const objv[])	/* Argument objects. */  {      register int i; -    int body, result; -    char *string, *arg; -    int caseObjc; -    Tcl_Obj *CONST *caseObjv; +    int body, result, caseObjc; +    const char *stringPtr, *arg; +    Tcl_Obj *const *caseObjv;      Tcl_Obj *armPtr;      if (objc < 3) {  	Tcl_WrongNumArgs(interp, 1, objv, -		"string ?in? patList body ... ?default body?"); +		"string ?in? ?pattern body ...? ?default body?");  	return TCL_ERROR;      } -    string = Tcl_GetString(objv[1]); +    stringPtr = TclGetString(objv[1]);      body = -1; -    arg = Tcl_GetString(objv[2]); +    arg = TclGetString(objv[2]);      if (strcmp(arg, "in") == 0) {  	i = 3;      } else { @@ -124,38 +180,37 @@ Tcl_CaseObjCmd(dummy, interp, objc, objv)      caseObjv = objv + i;      /* -     * If all of the pattern/command pairs are lumped into a single -     * argument, split them out again. +     * If all of the pattern/command pairs are lumped into a single argument, +     * split them out again.       */      if (caseObjc == 1) {  	Tcl_Obj **newObjv; -	 -	Tcl_ListObjGetElements(interp, caseObjv[0], &caseObjc, &newObjv); + +	TclListObjGetElements(interp, caseObjv[0], &caseObjc, &newObjv);  	caseObjv = newObjv;      }      for (i = 0;  i < caseObjc;  i += 2) {  	int patObjc, j; -	char **patObjv; -	char *pat; -	unsigned char *p; +	const char **patObjv; +	const char *pat, *p; -	if (i == (caseObjc - 1)) { +	if (i == caseObjc-1) {  	    Tcl_ResetResult(interp); -	    Tcl_AppendToObj(Tcl_GetObjResult(interp), -	            "extra case pattern with no body", -1); +	    Tcl_SetObjResult(interp, Tcl_NewStringObj( +		    "extra case pattern with no body", -1));  	    return TCL_ERROR;  	}  	/* -	 * Check for special case of single pattern (no list) with -	 * no backslash sequences. +	 * Check for special case of single pattern (no list) with no +	 * backslash sequences.  	 */ -	pat = Tcl_GetString(caseObjv[i]); -	for (p = (unsigned char *) pat; *p != '\0'; p++) { -	    if (isspace(*p) || (*p == '\\')) {	/* INTL: ISO space, UCHAR */ +	pat = TclGetString(caseObjv[i]); +	for (p = pat; *p != '\0'; p++) { +	    if (TclIsSpaceProc(*p) || (*p == '\\')) {  		break;  	    }  	} @@ -163,17 +218,16 @@ Tcl_CaseObjCmd(dummy, interp, objc, objv)  	    if ((*pat == 'd') && (strcmp(pat, "default") == 0)) {  		body = i + 1;  	    } -	    if (Tcl_StringMatch(string, pat)) { +	    if (Tcl_StringMatch(stringPtr, pat)) {  		body = i + 1;  		goto match;  	    }  	    continue;  	} -  	/* -	 * Break up pattern lists, then check each of the patterns -	 * in the list. +	 * Break up pattern lists, then check each of the patterns in the +	 * list.  	 */  	result = Tcl_SplitList(interp, pat, &patObjc, &patObjv); @@ -181,29 +235,25 @@ Tcl_CaseObjCmd(dummy, interp, objc, objv)  	    return result;  	}  	for (j = 0; j < patObjc; j++) { -	    if (Tcl_StringMatch(string, patObjv[j])) { +	    if (Tcl_StringMatch(stringPtr, patObjv[j])) {  		body = i + 1;  		break;  	    }  	} -	ckfree((char *) patObjv); +	ckfree(patObjv);  	if (j < patObjc) {  	    break;  	}      } -    match: +  match:      if (body != -1) {  	armPtr = caseObjv[body - 1];  	result = Tcl_EvalObjEx(interp, caseObjv[body], 0);  	if (result == TCL_ERROR) { -	    char msg[100 + TCL_INTEGER_SPACE]; -	     -	    arg = Tcl_GetString(armPtr); -	    sprintf(msg, -		    "\n    (\"%.50s\" arm line %d)", arg, -	            interp->errorLine); -	    Tcl_AddObjErrorInfo(interp, msg, -1); +	    Tcl_AppendObjToErrorInfo(interp, Tcl_ObjPrintf( +		    "\n    (\"%.50s\" arm line %d)", +		    TclGetString(armPtr), Tcl_GetErrorLine(interp)));  	}  	return result;      } @@ -220,7 +270,7 @@ Tcl_CaseObjCmd(dummy, interp, objc, objv)   *   * Tcl_CatchObjCmd --   * - *	This object-based procedure is invoked to process the "catch" Tcl  + *	This object-based procedure is invoked to process the "catch" Tcl   *	command. See the user documentation for details on what it does.   *   * Results: @@ -234,51 +284,90 @@ Tcl_CaseObjCmd(dummy, interp, objc, objv)  	/* ARGSUSED */  int -Tcl_CatchObjCmd(dummy, interp, objc, objv) -    ClientData dummy;		/* Not used. */ -    Tcl_Interp *interp;		/* Current interpreter. */ -    int objc;			/* Number of arguments. */ -    Tcl_Obj *CONST objv[];	/* Argument objects. */ +Tcl_CatchObjCmd( +    ClientData dummy,		/* Not used. */ +    Tcl_Interp *interp,		/* Current interpreter. */ +    int objc,			/* Number of arguments. */ +    Tcl_Obj *const objv[])	/* Argument objects. */ +{ +    return Tcl_NRCallObjProc(interp, TclNRCatchObjCmd, dummy, objc, objv); +} + +int +TclNRCatchObjCmd( +    ClientData dummy,		/* Not used. */ +    Tcl_Interp *interp,		/* Current interpreter. */ +    int objc,			/* Number of arguments. */ +    Tcl_Obj *const objv[])	/* Argument objects. */  {      Tcl_Obj *varNamePtr = NULL; -    int result; +    Tcl_Obj *optionVarNamePtr = NULL; +    Interp *iPtr = (Interp *) interp; -    if ((objc != 2) && (objc != 3)) { -	Tcl_WrongNumArgs(interp, 1, objv, "command ?varName?"); +    if ((objc < 2) || (objc > 4)) { +	Tcl_WrongNumArgs(interp, 1, objv, +		"script ?resultVarName? ?optionVarName?");  	return TCL_ERROR;      } +    if (objc >= 3) { +	varNamePtr = objv[2]; +    } +    if (objc == 4) { +	optionVarNamePtr = objv[3]; +    } + +    TclNRAddCallback(interp, CatchObjCmdCallback, INT2PTR(objc), +	    varNamePtr, optionVarNamePtr, NULL); +      /* -     * Save a pointer to the variable name object, if any, in case the -     * Tcl_EvalObj reallocates the bytecode interpreter's evaluation -     * stack rendering objv invalid. +     * TIP #280. Make invoking context available to caught script.       */ -     -    if (objc == 3) { -	varNamePtr = objv[2]; + +    return TclNREvalObjEx(interp, objv[1], 0, iPtr->cmdFramePtr, 1); +} + +static int +CatchObjCmdCallback( +    ClientData data[], +    Tcl_Interp *interp, +    int result) +{ +    Interp *iPtr = (Interp *) interp; +    int objc = PTR2INT(data[0]); +    Tcl_Obj *varNamePtr = data[1]; +    Tcl_Obj *optionVarNamePtr = data[2]; +    int rewind = iPtr->execEnvPtr->rewind; + +    /* +     * We disable catch in interpreters where the limit has been exceeded. +     */ + +    if (rewind || Tcl_LimitExceeded(interp)) { +	Tcl_AppendObjToErrorInfo(interp, Tcl_ObjPrintf( +		"\n    (\"catch\" body line %d)", Tcl_GetErrorLine(interp))); +	return TCL_ERROR;      } -    result = Tcl_EvalObjEx(interp, objv[1], 0); -     -    if (objc == 3) { -	if (Tcl_ObjSetVar2(interp, varNamePtr, NULL, -		Tcl_GetObjResult(interp), 0) == NULL) { -	    Tcl_ResetResult(interp); -	    Tcl_AppendToObj(Tcl_GetObjResult(interp),   -	            "couldn't save command result in variable", -1); +    if (objc >= 3) { +	if (NULL == Tcl_ObjSetVar2(interp, varNamePtr, NULL, +		Tcl_GetObjResult(interp), TCL_LEAVE_ERR_MSG)) {  	    return TCL_ERROR;  	}      } +    if (objc == 4) { +	Tcl_Obj *options = Tcl_GetReturnOptions(interp, result); -    /* -     * Set the interpreter's object result to an integer object holding the -     * integer Tcl_EvalObj result. Note that we don't bother generating a -     * string representation. We reset the interpreter's object result -     * to an unshared empty object and then set it to be an integer object. -     */ +	if (NULL == Tcl_ObjSetVar2(interp, optionVarNamePtr, NULL, +		options, TCL_LEAVE_ERR_MSG)) { +	    /* Do not decrRefCount 'options', it was already done by +	     * Tcl_ObjSetVar2 */ +	    return TCL_ERROR; +	} +    }      Tcl_ResetResult(interp); -    Tcl_SetIntObj(Tcl_GetObjResult(interp), result); +    Tcl_SetObjResult(interp, Tcl_NewIntObj(result));      return TCL_OK;  } @@ -287,8 +376,8 @@ Tcl_CatchObjCmd(dummy, interp, objc, objv)   *   * Tcl_CdObjCmd --   * - *	This procedure is invoked to process the "cd" Tcl command. - *	See the user documentation for details on what it does. + *	This procedure is invoked to process the "cd" Tcl command. See the + *	user documentation for details on what it does.   *   * Results:   *	A standard Tcl result. @@ -301,14 +390,13 @@ Tcl_CatchObjCmd(dummy, interp, objc, objv)  	/* ARGSUSED */  int -Tcl_CdObjCmd(dummy, interp, objc, objv) -    ClientData dummy;		/* Not used. */ -    Tcl_Interp *interp;		/* Current interpreter. */ -    int objc;			/* Number of arguments. */ -    Tcl_Obj *CONST objv[];	/* Argument objects. */ +Tcl_CdObjCmd( +    ClientData dummy,		/* Not used. */ +    Tcl_Interp *interp,		/* Current interpreter. */ +    int objc,			/* Number of arguments. */ +    Tcl_Obj *const objv[])	/* Argument objects. */  { -    char *dirName; -    Tcl_DString ds; +    Tcl_Obj *dir;      int result;      if (objc > 2) { @@ -317,23 +405,26 @@ Tcl_CdObjCmd(dummy, interp, objc, objv)      }      if (objc == 2) { -	dirName = Tcl_GetString(objv[1]); +	dir = objv[1];      } else { -	dirName = "~"; +	TclNewLiteralStringObj(dir, "~"); +	Tcl_IncrRefCount(dir);      } -    if (Tcl_TranslateFileName(interp, dirName, &ds) == NULL) { -	return TCL_ERROR; +    if (Tcl_FSConvertToPathType(interp, dir) != TCL_OK) { +	result = TCL_ERROR; +    } else { +	result = Tcl_FSChdir(dir); +	if (result != TCL_OK) { +	    Tcl_SetObjResult(interp, Tcl_ObjPrintf( +		    "couldn't change working directory to \"%s\": %s", +		    TclGetString(dir), Tcl_PosixError(interp))); +	    result = TCL_ERROR; +	}      } - -    result = Tcl_Chdir(Tcl_DStringValue(&ds)); -    Tcl_DStringFree(&ds); - -    if (result != 0) { -	Tcl_AppendResult(interp, "couldn't change working directory to \"", -		dirName, "\": ", Tcl_PosixError(interp), (char *) NULL); -	return TCL_ERROR; +    if (objc != 2) { +	Tcl_DecrRefCount(dir);      } -    return TCL_OK; +    return result;  }  /* @@ -355,11 +446,11 @@ Tcl_CdObjCmd(dummy, interp, objc, objv)  	/* ARGSUSED */  int -Tcl_ConcatObjCmd(dummy, interp, objc, objv) -    ClientData dummy;		/* Not used. */ -    Tcl_Interp *interp;		/* Current interpreter. */ -    int objc;			/* Number of arguments. */ -    Tcl_Obj *CONST objv[];	/* Argument objects. */ +Tcl_ConcatObjCmd( +    ClientData dummy,		/* Not used. */ +    Tcl_Interp *interp,		/* Current interpreter. */ +    int objc,			/* Number of arguments. */ +    Tcl_Obj *const objv[])	/* Argument objects. */  {      if (objc >= 2) {  	Tcl_SetObjResult(interp, Tcl_ConcatObj(objc-1, objv+1)); @@ -370,14 +461,14 @@ Tcl_ConcatObjCmd(dummy, interp, objc, objv)  /*   *----------------------------------------------------------------------   * - * Tcl_ContinueObjCmd - + * Tcl_ContinueObjCmd --   * - *	This procedure is invoked to process the "continue" Tcl command. - *	See the user documentation for details on what it does. + *	This procedure is invoked to process the "continue" Tcl command. See + *	the user documentation for details on what it does.   * - *	With the bytecode compiler, this procedure is only called when - *	a command name is computed at runtime, and is "continue" or the name - *	to which "continue" was renamed: e.g., "set z continue; $z" + *	With the bytecode compiler, this procedure is only called when a + *	command name is computed at runtime, and is "continue" or the name to + *	which "continue" was renamed: e.g., "set z continue; $z"   *   * Results:   *	A standard Tcl result. @@ -390,11 +481,11 @@ Tcl_ConcatObjCmd(dummy, interp, objc, objv)  	/* ARGSUSED */  int -Tcl_ContinueObjCmd(dummy, interp, objc, objv) -    ClientData dummy;			/* Not used. */ -    Tcl_Interp *interp;			/* Current interpreter. */ -    int objc;				/* Number of arguments. */ -    Tcl_Obj *CONST objv[];		/* Argument objects. */ +Tcl_ContinueObjCmd( +    ClientData dummy,		/* Not used. */ +    Tcl_Interp *interp,		/* Current interpreter. */ +    int objc,			/* Number of arguments. */ +    Tcl_Obj *const objv[])	/* Argument objects. */  {      if (objc != 1) {  	Tcl_WrongNumArgs(interp, 1, objv, NULL); @@ -420,29 +511,25 @@ Tcl_ContinueObjCmd(dummy, interp, objc, objv)   */  int -Tcl_EncodingObjCmd(dummy, interp, objc, objv) -    ClientData dummy;		/* Not used. */ -    Tcl_Interp *interp;		/* Current interpreter. */ -    int objc;			/* Number of arguments. */ -    Tcl_Obj *CONST objv[];	/* Argument objects. */ -{ -    int index, length; -    Tcl_Encoding encoding; -    char *string; -    Tcl_DString ds; -    Tcl_Obj *resultPtr; +Tcl_EncodingObjCmd( +    ClientData dummy,		/* Not used. */ +    Tcl_Interp *interp,		/* Current interpreter. */ +    int objc,			/* Number of arguments. */ +    Tcl_Obj *const objv[])	/* Argument objects. */ +{ +    int index; -    static char *optionStrings[] = { -	"convertfrom", "convertto", "names", "system", +    static const char *const optionStrings[] = { +	"convertfrom", "convertto", "dirs", "names", "system",  	NULL      };      enum options { -	ENC_CONVERTFROM, ENC_CONVERTTO, ENC_NAMES, ENC_SYSTEM +	ENC_CONVERTFROM, ENC_CONVERTTO, ENC_DIRS, ENC_NAMES, ENC_SYSTEM      };      if (objc < 2) { -    	Tcl_WrongNumArgs(interp, 1, objv, "option ?arg ...?"); -        return TCL_ERROR; +	Tcl_WrongNumArgs(interp, 1, objv, "option ?arg ...?"); +	return TCL_ERROR;      }      if (Tcl_GetIndexFromObj(interp, objv[1], optionStrings, "option", 0,  	    &index) != TCL_OK) { @@ -450,80 +537,78 @@ Tcl_EncodingObjCmd(dummy, interp, objc, objv)      }      switch ((enum options) index) { -	case ENC_CONVERTTO: -	case ENC_CONVERTFROM: { -	    char *name; -	    Tcl_Obj *data; -	    if (objc == 3) { -		name = NULL; -		data = objv[2]; -	    } else if (objc == 4) { -		name = Tcl_GetString(objv[2]); -		data = objv[3]; -	    } else { -		Tcl_WrongNumArgs(interp, 2, objv, "?encoding? data"); -		return TCL_ERROR; -	    } -	     -	    encoding = Tcl_GetEncoding(interp, name); -	    if (!encoding) { +    case ENC_CONVERTTO: +    case ENC_CONVERTFROM: { +	Tcl_Obj *data; +	Tcl_DString ds; +	Tcl_Encoding encoding; +	int length; +	const char *stringPtr; + +	if (objc == 3) { +	    encoding = Tcl_GetEncoding(interp, NULL); +	    data = objv[2]; +	} else if (objc == 4) { +	    if (Tcl_GetEncodingFromObj(interp, objv[2], &encoding) != TCL_OK) {  		return TCL_ERROR;  	    } +	    data = objv[3]; +	} else { +	    Tcl_WrongNumArgs(interp, 2, objv, "?encoding? data"); +	    return TCL_ERROR; +	} -	    if ((enum options) index == ENC_CONVERTFROM) { -		/* -		 * Treat the string as binary data. -		 */ +	if ((enum options) index == ENC_CONVERTFROM) { +	    /* +	     * Treat the string as binary data. +	     */ -		string = (char *) Tcl_GetByteArrayFromObj(data, &length); -		Tcl_ExternalToUtfDString(encoding, string, length, &ds); +	    stringPtr = (char *) Tcl_GetByteArrayFromObj(data, &length); +	    Tcl_ExternalToUtfDString(encoding, stringPtr, length, &ds); -		/* -		 * Note that we cannot use Tcl_DStringResult here because -		 * it will truncate the string at the first null byte. -		 */ +	    /* +	     * Note that we cannot use Tcl_DStringResult here because it will +	     * truncate the string at the first null byte. +	     */ -		Tcl_SetStringObj(Tcl_GetObjResult(interp), -			Tcl_DStringValue(&ds), Tcl_DStringLength(&ds)); -		Tcl_DStringFree(&ds); -	    } else { -		/* -		 * Store the result as binary data. -		 */ - -		string = Tcl_GetStringFromObj(data, &length); -		Tcl_UtfToExternalDString(encoding, string, length, &ds); -		resultPtr = Tcl_GetObjResult(interp); -		Tcl_SetByteArrayObj(resultPtr,  -			(unsigned char *) Tcl_DStringValue(&ds), -			Tcl_DStringLength(&ds)); -		Tcl_DStringFree(&ds); -	    } +	    Tcl_SetObjResult(interp, TclDStringToObj(&ds)); +	} else { +	    /* +	     * Store the result as binary data. +	     */ -	    Tcl_FreeEncoding(encoding); -	    break; +	    stringPtr = TclGetStringFromObj(data, &length); +	    Tcl_UtfToExternalDString(encoding, stringPtr, length, &ds); +	    Tcl_SetObjResult(interp, Tcl_NewByteArrayObj( +		    (unsigned char *) Tcl_DStringValue(&ds), +		    Tcl_DStringLength(&ds))); +	    Tcl_DStringFree(&ds);  	} -	case ENC_NAMES: { -	    if (objc > 2) { -		Tcl_WrongNumArgs(interp, 2, objv, NULL); -		return TCL_ERROR; -	    } -	    Tcl_GetEncodingNames(interp); -	    break; + +	Tcl_FreeEncoding(encoding); +	break; +    } +    case ENC_DIRS: +	return EncodingDirsObjCmd(dummy, interp, objc, objv); +    case ENC_NAMES: +	if (objc > 2) { +	    Tcl_WrongNumArgs(interp, 2, objv, NULL); +	    return TCL_ERROR;  	} -	case ENC_SYSTEM: { -	    if (objc > 3) { -		Tcl_WrongNumArgs(interp, 2, objv, "?encoding?"); -		return TCL_ERROR; -	    } -	    if (objc == 2) { -	        Tcl_SetResult(interp, Tcl_GetEncodingName(NULL), TCL_STATIC); -	    } else { -	        return Tcl_SetSystemEncoding(interp, -			Tcl_GetStringFromObj(objv[2], NULL)); -	    } -	    break; +	Tcl_GetEncodingNames(interp); +	break; +    case ENC_SYSTEM: +	if (objc > 3) { +	    Tcl_WrongNumArgs(interp, 2, objv, "?encoding?"); +	    return TCL_ERROR; +	} +	if (objc == 2) { +	    Tcl_SetObjResult(interp, Tcl_NewStringObj( +		    Tcl_GetEncodingName(NULL), -1)); +	} else { +	    return Tcl_SetSystemEncoding(interp, TclGetString(objv[2]));  	} +	break;      }      return TCL_OK;  } @@ -531,10 +616,57 @@ Tcl_EncodingObjCmd(dummy, interp, objc, objv)  /*   *----------------------------------------------------------------------   * + * EncodingDirsObjCmd -- + * + *	This command manipulates the encoding search path. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	Can set the encoding search path. + * + *---------------------------------------------------------------------- + */ + +int +EncodingDirsObjCmd( +    ClientData dummy,		/* Not used. */ +    Tcl_Interp *interp,		/* Current interpreter. */ +    int objc,			/* Number of arguments. */ +    Tcl_Obj *const objv[])	/* Argument objects. */ +{ +    Tcl_Obj *dirListObj; + +    if (objc > 3) { +	Tcl_WrongNumArgs(interp, 2, objv, "?dirList?"); +	return TCL_ERROR; +    } +    if (objc == 2) { +	Tcl_SetObjResult(interp, Tcl_GetEncodingSearchPath()); +	return TCL_OK; +    } + +    dirListObj = objv[2]; +    if (Tcl_SetEncodingSearchPath(dirListObj) == TCL_ERROR) { +	Tcl_SetObjResult(interp, Tcl_ObjPrintf( +		"expected directory list but got \"%s\"", +		TclGetString(dirListObj))); +	Tcl_SetErrorCode(interp, "TCL", "OPERATION", "ENCODING", "BADPATH", +		NULL); +	return TCL_ERROR; +    } +    Tcl_SetObjResult(interp, dirListObj); +    return TCL_OK; +} + +/* + *---------------------------------------------------------------------- + *   * Tcl_ErrorObjCmd --   * - *	This procedure is invoked to process the "error" Tcl command. - *	See the user documentation for details on what it does. + *	This procedure is invoked to process the "error" Tcl command. See the + *	user documentation for details on what it does.   *   * Results:   *	A standard Tcl object result. @@ -547,36 +679,35 @@ Tcl_EncodingObjCmd(dummy, interp, objc, objv)  	/* ARGSUSED */  int -Tcl_ErrorObjCmd(dummy, interp, objc, objv) -    ClientData dummy;		/* Not used. */ -    Tcl_Interp *interp;		/* Current interpreter. */ -    int objc;			/* Number of arguments. */ -    Tcl_Obj *CONST objv[];	/* Argument objects. */ +Tcl_ErrorObjCmd( +    ClientData dummy,		/* Not used. */ +    Tcl_Interp *interp,		/* Current interpreter. */ +    int objc,			/* Number of arguments. */ +    Tcl_Obj *const objv[])	/* Argument objects. */  { -    Interp *iPtr = (Interp *) interp; -    char *info; -    int infoLen; +    Tcl_Obj *options, *optName;      if ((objc < 2) || (objc > 4)) {  	Tcl_WrongNumArgs(interp, 1, objv, "message ?errorInfo? ?errorCode?");  	return TCL_ERROR;      } -     -    if (objc >= 3) {		/* process the optional info argument */ -	info = Tcl_GetStringFromObj(objv[2], &infoLen); -	if (*info != 0) { -	    Tcl_AddObjErrorInfo(interp, info, infoLen); -	    iPtr->flags |= ERR_ALREADY_LOGGED; -	} + +    TclNewLiteralStringObj(options, "-code error -level 0"); + +    if (objc >= 3) {		/* Process the optional info argument */ +	TclNewLiteralStringObj(optName, "-errorinfo"); +	Tcl_ListObjAppendElement(NULL, options, optName); +	Tcl_ListObjAppendElement(NULL, options, objv[2]);      } -     -    if (objc == 4) { -	Tcl_SetVar2Ex(interp, "errorCode", NULL, objv[3], TCL_GLOBAL_ONLY); -	iPtr->flags |= ERROR_CODE_SET; + +    if (objc >= 4) {		/* Process the optional code argument */ +	TclNewLiteralStringObj(optName, "-errorcode"); +	Tcl_ListObjAppendElement(NULL, options, optName); +	Tcl_ListObjAppendElement(NULL, options, objv[3]);      } -     +      Tcl_SetObjResult(interp, objv[1]); -    return TCL_ERROR; +    return Tcl_SetReturnOptions(interp, options);  }  /* @@ -584,7 +715,7 @@ Tcl_ErrorObjCmd(dummy, interp, objc, objv)   *   * Tcl_EvalObjCmd --   * - *	This object-based procedure is invoked to process the "eval" Tcl  + *	This object-based procedure is invoked to process the "eval" Tcl   *	command. See the user documentation for details on what it does.   *   * Results: @@ -597,39 +728,69 @@ Tcl_ErrorObjCmd(dummy, interp, objc, objv)   */  	/* ARGSUSED */ +static int +EvalCmdErrMsg( +    ClientData data[], +    Tcl_Interp *interp, +    int result) +{ +    if (result == TCL_ERROR) { +	Tcl_AppendObjToErrorInfo(interp, Tcl_ObjPrintf( +		"\n    (\"eval\" body line %d)", Tcl_GetErrorLine(interp))); +    } +    return result; +} +  int -Tcl_EvalObjCmd(dummy, interp, objc, objv) -    ClientData dummy;		/* Not used. */ -    Tcl_Interp *interp;		/* Current interpreter. */ -    int objc;			/* Number of arguments. */ -    Tcl_Obj *CONST objv[];	/* Argument objects. */ +Tcl_EvalObjCmd( +    ClientData dummy,		/* Not used. */ +    Tcl_Interp *interp,		/* Current interpreter. */ +    int objc,			/* Number of arguments. */ +    Tcl_Obj *const objv[])	/* Argument objects. */ +{ +    return Tcl_NRCallObjProc(interp, TclNREvalObjCmd, dummy, objc, objv);     +} + +int +TclNREvalObjCmd( +    ClientData dummy,		/* Not used. */ +    Tcl_Interp *interp,		/* Current interpreter. */ +    int objc,			/* Number of arguments. */ +    Tcl_Obj *const objv[])	/* Argument objects. */  { -    int result;      register Tcl_Obj *objPtr; +    Interp *iPtr = (Interp *) interp; +    CmdFrame *invoker = NULL; +    int word = 0;      if (objc < 2) {  	Tcl_WrongNumArgs(interp, 1, objv, "arg ?arg ...?");  	return TCL_ERROR;      } -     +      if (objc == 2) { -	result = Tcl_EvalObjEx(interp, objv[1], TCL_EVAL_DIRECT); +	/* +	 * TIP #280. Make argument location available to eval'd script. +	 */ + +	invoker = iPtr->cmdFramePtr; +	word = 1; +	objPtr = objv[1]; +	TclArgumentGet(interp, objPtr, &invoker, &word);      } else {  	/*  	 * More than one argument: concatenate them together with spaces -	 * between, then evaluate the result.  Tcl_EvalObjEx will delete -	 * the object when it decrements its refcount after eval'ing it. +	 * between, then evaluate the result. Tcl_EvalObjEx will delete the +	 * object when it decrements its refcount after eval'ing it. +	 * +	 * TIP #280. Make invoking context available to eval'd script, done +	 * with the default values.  	 */ -    	objPtr = Tcl_ConcatObj(objc-1, objv+1); -	result = Tcl_EvalObjEx(interp, objPtr, TCL_EVAL_DIRECT); -    } -    if (result == TCL_ERROR) { -	char msg[32 + TCL_INTEGER_SPACE]; -	sprintf(msg, "\n    (\"eval\" body line %d)", interp->errorLine); -	Tcl_AddObjErrorInfo(interp, msg, -1); +	objPtr = Tcl_ConcatObj(objc-1, objv+1);      } -    return result; +    TclNRAddCallback(interp, EvalCmdErrMsg, NULL, NULL, NULL, NULL); +    return TclNREvalObjEx(interp, objPtr, 0, invoker, word);  }  /* @@ -637,8 +798,8 @@ Tcl_EvalObjCmd(dummy, interp, objc, objv)   *   * Tcl_ExitObjCmd --   * - *	This procedure is invoked to process the "exit" Tcl command. - *	See the user documentation for details on what it does. + *	This procedure is invoked to process the "exit" Tcl command. See the + *	user documentation for details on what it does.   *   * Results:   *	A standard Tcl object result. @@ -651,11 +812,11 @@ Tcl_EvalObjCmd(dummy, interp, objc, objv)  	/* ARGSUSED */  int -Tcl_ExitObjCmd(dummy, interp, objc, objv) -    ClientData dummy;		/* Not used. */ -    Tcl_Interp *interp;		/* Current interpreter. */ -    int objc;			/* Number of arguments. */ -    Tcl_Obj *CONST objv[];	/* Argument objects. */ +Tcl_ExitObjCmd( +    ClientData dummy,		/* Not used. */ +    Tcl_Interp *interp,		/* Current interpreter. */ +    int objc,			/* Number of arguments. */ +    Tcl_Obj *const objv[])	/* Argument objects. */  {      int value; @@ -663,7 +824,7 @@ Tcl_ExitObjCmd(dummy, interp, objc, objv)  	Tcl_WrongNumArgs(interp, 1, objv, "?returnCode?");  	return TCL_ERROR;      } -     +      if (objc == 1) {  	value = 0;      } else if (Tcl_GetIntFromObj(interp, objv[1], &value) != TCL_OK) { @@ -671,7 +832,7 @@ Tcl_ExitObjCmd(dummy, interp, objc, objv)      }      Tcl_Exit(value);      /*NOTREACHED*/ -    return TCL_OK;			/* Better not ever reach this! */ +    return TCL_OK;		/* Better not ever reach this! */  }  /* @@ -683,8 +844,8 @@ Tcl_ExitObjCmd(dummy, interp, objc, objv)   *	command. See the user documentation for details on what it does.   *   *	With the bytecode compiler, this procedure is called in two - *	circumstances: 1) to execute expr commands that are too complicated - *	or too unsafe to try compiling directly into an inline sequence of + *	circumstances: 1) to execute expr commands that are too complicated or + *	too unsafe to try compiling directly into an inline sequence of   *	instructions, and 2) to execute commands where the command name is   *	computed at runtime and is "expr" or the name to which "expr" was   *	renamed (e.g., "set z expr; $z 2+3") @@ -700,697 +861,1323 @@ Tcl_ExitObjCmd(dummy, interp, objc, objv)  	/* ARGSUSED */  int -Tcl_ExprObjCmd(dummy, interp, objc, objv) -    ClientData dummy;		/* Not used. */ -    Tcl_Interp *interp;		/* Current interpreter. */ -    int objc;			/* Number of arguments. */ -    Tcl_Obj *CONST objv[];	/* Argument objects. */ -{	  -    register Tcl_Obj *objPtr; -    Tcl_Obj *resultPtr; -    register char *bytes; -    int length, i, result; +Tcl_ExprObjCmd( +    ClientData dummy,		/* Not used. */ +    Tcl_Interp *interp,		/* Current interpreter. */ +    int objc,			/* Number of arguments. */ +    Tcl_Obj *const objv[])	/* Argument objects. */ +{ +    return Tcl_NRCallObjProc(interp, TclNRExprObjCmd, dummy, objc, objv); +} + +int +TclNRExprObjCmd( +    ClientData dummy,		/* Not used. */ +    Tcl_Interp *interp,		/* Current interpreter. */ +    int objc,			/* Number of arguments. */ +    Tcl_Obj *const objv[])	/* Argument objects. */ +{ +    Tcl_Obj *resultPtr, *objPtr;      if (objc < 2) {  	Tcl_WrongNumArgs(interp, 1, objv, "arg ?arg ...?");  	return TCL_ERROR;      } +    TclNewObj(resultPtr); +    Tcl_IncrRefCount(resultPtr);      if (objc == 2) { -	result = Tcl_ExprObj(interp, objv[1], &resultPtr); -	if (result == TCL_OK) { -	    Tcl_SetObjResult(interp, resultPtr); -	    Tcl_DecrRefCount(resultPtr);  /* done with the result object */ -	} -	return result; +	objPtr = objv[1]; +	TclNRAddCallback(interp, ExprCallback, resultPtr, NULL, NULL, NULL); +    } else { +	objPtr = Tcl_ConcatObj(objc-1, objv+1); +	TclNRAddCallback(interp, ExprCallback, resultPtr, objPtr, NULL, NULL);      } -    /* -     * Create a new object holding the concatenated argument strings. -     */ +    return Tcl_NRExprObj(interp, objPtr, resultPtr); +} -    bytes = Tcl_GetStringFromObj(objv[1], &length); -    objPtr = Tcl_NewStringObj(bytes, length); -    Tcl_IncrRefCount(objPtr); -    for (i = 2;  i < objc;  i++) { -	Tcl_AppendToObj(objPtr, " ", 1); -	bytes = Tcl_GetStringFromObj(objv[i], &length); -	Tcl_AppendToObj(objPtr, bytes, length); -    } +static int +ExprCallback( +    ClientData data[], +    Tcl_Interp *interp, +    int result) +{ +    Tcl_Obj *resultPtr = data[0]; +    Tcl_Obj *objPtr = data[1]; -    /* -     * Evaluate the concatenated string object. -     */ +    if (objPtr != NULL) { +	Tcl_DecrRefCount(objPtr); +    } -    result = Tcl_ExprObj(interp, objPtr, &resultPtr);      if (result == TCL_OK) {  	Tcl_SetObjResult(interp, resultPtr); -	Tcl_DecrRefCount(resultPtr);  /* done with the result object */      } +    Tcl_DecrRefCount(resultPtr); +    return result; +} + +/* + *---------------------------------------------------------------------- + * + * TclInitFileCmd -- + * + *	This function builds the "file" Tcl command ensemble. See the user + *	documentation for details on what that ensemble does. + * + *	PLEASE NOTE THAT THIS FAILS WITH FILENAMES AND PATHS WITH EMBEDDED + *	NULLS. With the object-based Tcl_FS APIs, the above NOTE may no longer + *	be true. In any case this assertion should be tested. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	See the user documentation. + * + *---------------------------------------------------------------------- + */ +Tcl_Command +TclInitFileCmd( +    Tcl_Interp *interp) +{      /* -     * Free allocated resources. +     * Note that most subcommands are unsafe because either they manipulate +     * the native filesystem or because they reveal information about the +     * native filesystem.       */ -     -    Tcl_DecrRefCount(objPtr); -    return result; + +    static const EnsembleImplMap initMap[] = { +	{"atime",	FileAttrAccessTimeCmd,	TclCompileBasic1Or2ArgCmd, NULL, NULL, 0}, +	{"attributes",	TclFileAttrsCmd,	NULL, NULL, NULL, 0}, +	{"channels",	TclChannelNamesCmd,	TclCompileBasic0Or1ArgCmd, NULL, NULL, 0}, +	{"copy",	TclFileCopyCmd,		NULL, NULL, NULL, 0}, +	{"delete",	TclFileDeleteCmd,	TclCompileBasicMin0ArgCmd, NULL, NULL, 0}, +	{"dirname",	PathDirNameCmd,		TclCompileBasic1ArgCmd, NULL, NULL, 0}, +	{"executable",	FileAttrIsExecutableCmd, TclCompileBasic1ArgCmd, NULL, NULL, 0}, +	{"exists",	FileAttrIsExistingCmd,	TclCompileBasic1ArgCmd, NULL, NULL, 0}, +	{"extension",	PathExtensionCmd,	TclCompileBasic1ArgCmd, NULL, NULL, 0}, +	{"isdirectory",	FileAttrIsDirectoryCmd,	TclCompileBasic1ArgCmd, NULL, NULL, 0}, +	{"isfile",	FileAttrIsFileCmd,	TclCompileBasic1ArgCmd, NULL, NULL, 0}, +	{"join",	PathJoinCmd,		TclCompileBasicMin1ArgCmd, NULL, NULL, 0}, +	{"link",	TclFileLinkCmd,		TclCompileBasic1To3ArgCmd, NULL, NULL, 0}, +	{"lstat",	FileAttrLinkStatCmd,	TclCompileBasic2ArgCmd, NULL, NULL, 0}, +	{"mtime",	FileAttrModifyTimeCmd,	TclCompileBasic1Or2ArgCmd, NULL, NULL, 0}, +	{"mkdir",	TclFileMakeDirsCmd,	TclCompileBasicMin0ArgCmd, NULL, NULL, 0}, +	{"nativename",	PathNativeNameCmd,	TclCompileBasic1ArgCmd, NULL, NULL, 0}, +	{"normalize",	PathNormalizeCmd,	TclCompileBasic1ArgCmd, NULL, NULL, 0}, +	{"owned",	FileAttrIsOwnedCmd,	TclCompileBasic1ArgCmd, NULL, NULL, 0}, +	{"pathtype",	PathTypeCmd,		TclCompileBasic1ArgCmd, NULL, NULL, 0}, +	{"readable",	FileAttrIsReadableCmd,	TclCompileBasic1ArgCmd, NULL, NULL, 0}, +	{"readlink",	TclFileReadLinkCmd,	TclCompileBasic1ArgCmd, NULL, NULL, 0}, +	{"rename",	TclFileRenameCmd,	NULL, NULL, NULL, 0}, +	{"rootname",	PathRootNameCmd,	TclCompileBasic1ArgCmd, NULL, NULL, 0}, +	{"separator",	FilesystemSeparatorCmd,	TclCompileBasic0Or1ArgCmd, NULL, NULL, 0}, +	{"size",	FileAttrSizeCmd,	TclCompileBasic1ArgCmd, NULL, NULL, 0}, +	{"split",	PathSplitCmd,		TclCompileBasic1ArgCmd, NULL, NULL, 0}, +	{"stat",	FileAttrStatCmd,	TclCompileBasic2ArgCmd, NULL, NULL, 0}, +	{"system",	PathFilesystemCmd,	TclCompileBasic0Or1ArgCmd, NULL, NULL, 0}, +	{"tail",	PathTailCmd,		TclCompileBasic1ArgCmd, NULL, NULL, 0}, +	{"tempfile",	TclFileTemporaryCmd,	TclCompileBasic0To2ArgCmd, NULL, NULL, 0}, +	{"type",	FileAttrTypeCmd,	TclCompileBasic1ArgCmd, NULL, NULL, 0}, +	{"volumes",	FilesystemVolumesCmd,	TclCompileBasic0ArgCmd, NULL, NULL, 0}, +	{"writable",	FileAttrIsWritableCmd,	TclCompileBasic1ArgCmd, NULL, NULL, 0}, +	{NULL, NULL, NULL, NULL, NULL, 0} +    }; +    return TclMakeEnsemble(interp, "file", initMap);  }  /*   *----------------------------------------------------------------------   * - * Tcl_FileObjCmd -- + * TclMakeFileCommandSafe --   * - *	This procedure is invoked to process the "file" Tcl command. - *	See the user documentation for details on what it does. - *	PLEASE NOTE THAT THIS FAILS WITH FILENAMES AND PATHS WITH - *	EMBEDDED NULLS, WHICH COULD THEORETICALLY HAPPEN ON A MAC. + *	This function hides the unsafe subcommands of the "file" Tcl command + *	ensemble. It must only be called from TclHideUnsafeCommands.   *   * Results:   *	A standard Tcl result.   *   * Side effects: - *	See the user documentation. + *	Adds commands to the table of hidden commands.   *   *----------------------------------------------------------------------   */ -	/* ARGSUSED */  int -Tcl_FileObjCmd(dummy, interp, objc, objv) -    ClientData dummy;		/* Not used. */ -    Tcl_Interp *interp;		/* Current interpreter. */ -    int objc;			/* Number of arguments. */ -    Tcl_Obj *CONST objv[];	/* Argument objects. */ +TclMakeFileCommandSafe( +    Tcl_Interp *interp)  { -    Tcl_Obj *resultPtr; -    int index; +    static const struct { +	const char *cmdName; +	int unsafe; +    } unsafeInfo[] = { +	{"atime",	 1}, +	{"attributes",	 1}, +	{"channels",	 0}, +	{"copy",	 1}, +	{"delete",	 1}, +	{"dirname",	 1}, +	{"executable",	 1}, +	{"exists",	 1}, +	{"extension",	 1}, +	{"isdirectory",	 1}, +	{"isfile",	 1}, +	{"join",	 0}, +	{"link",	 1}, +	{"lstat",	 1}, +	{"mtime",	 1}, +	{"mkdir",	 1}, +	{"nativename",	 1}, +	{"normalize",	 1}, +	{"owned",	 1}, +	{"pathtype",	 0}, +	{"readable",	 1}, +	{"readlink",	 1}, +	{"rename",	 1}, +	{"rootname",	 1}, +	{"separator",	 0}, +	{"size",	 1}, +	{"split",	 0}, +	{"stat",	 1}, +	{"system",	 0}, +	{"tail",	 1}, +	{"tempfile",	 1}, +	{"type",	 1}, +	{"volumes",	 1}, +	{"writable",	 1}, +	{NULL, 0} +    }; +    int i; +    Tcl_DString oldBuf, newBuf; +    Tcl_DStringInit(&oldBuf); +    TclDStringAppendLiteral(&oldBuf, "::tcl::file::"); +    Tcl_DStringInit(&newBuf); +    TclDStringAppendLiteral(&newBuf, "tcl:file:"); +    for (i=0 ; unsafeInfo[i].cmdName != NULL ; i++) { +	if (unsafeInfo[i].unsafe) { +	    const char *oldName, *newName; + +	    Tcl_DStringSetLength(&oldBuf, 13); +	    oldName = Tcl_DStringAppend(&oldBuf, unsafeInfo[i].cmdName, -1); +	    Tcl_DStringSetLength(&newBuf, 9); +	    newName = Tcl_DStringAppend(&newBuf, unsafeInfo[i].cmdName, -1); +	    if (TclRenameCommand(interp, oldName, "___tmp") != TCL_OK +		    || Tcl_HideCommand(interp, "___tmp", newName) != TCL_OK) { +		Tcl_Panic("problem making 'file %s' safe: %s", +			unsafeInfo[i].cmdName, +			Tcl_GetString(Tcl_GetObjResult(interp))); +	    } +	    Tcl_CreateObjCommand(interp, oldName, BadFileSubcommand, +		    (ClientData) unsafeInfo[i].cmdName, NULL); +	} +    } +    Tcl_DStringFree(&oldBuf); +    Tcl_DStringFree(&newBuf); + +    /* +     * Ugh. The [file] command is now actually safe, but it is assumed by +     * scripts that it is not, which messes up security policies. [Bug +     * 3211758] +     */ + +    if (Tcl_HideCommand(interp, "file", "file") != TCL_OK) { +	Tcl_Panic("problem making 'file' safe: %s", +		Tcl_GetString(Tcl_GetObjResult(interp))); +    } +    return TCL_OK; +} +  /* - * This list of constants should match the fileOption string array below. + *---------------------------------------------------------------------- + * + * BadFileSubcommand -- + * + *	Command used to act as a backstop implementation when subcommands of + *	"file" are unsafe (the real implementations of the subcommands are + *	hidden). The clientData is always the full official subcommand name. + * + * Results: + *	A standard Tcl result (always a TCL_ERROR). + * + * Side effects: + *	None. + * + *----------------------------------------------------------------------   */ -    static char *fileOptions[] = { -	"atime",	"attributes",	"channels",	"copy", -	"delete", -	"dirname",	"executable",	"exists",	"extension", -	"isdirectory",	"isfile",	"join",		"lstat", -	"mtime",	"mkdir",	"nativename",	"owned", -	"pathtype",	"readable",	"readlink",	"rename", -	"rootname",	"size",		"split",	"stat", -	"tail",		"type",		"volumes",	"writable", -	(char *) NULL -    }; -    enum options { -	FILE_ATIME,	FILE_ATTRIBUTES, FILE_CHANNELS,	FILE_COPY, -	FILE_DELETE, -	FILE_DIRNAME,	FILE_EXECUTABLE, FILE_EXISTS,	FILE_EXTENSION, -	FILE_ISDIRECTORY, FILE_ISFILE,	FILE_JOIN,	FILE_LSTAT, -	FILE_MTIME,	FILE_MKDIR,	FILE_NATIVENAME, FILE_OWNED, -	FILE_PATHTYPE,	FILE_READABLE,	FILE_READLINK,	FILE_RENAME, -	FILE_ROOTNAME,	FILE_SIZE,	FILE_SPLIT,	FILE_STAT, -	FILE_TAIL,	FILE_TYPE,	FILE_VOLUMES,	FILE_WRITABLE -    }; +static int +BadFileSubcommand( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    const char *subcommandName = (const char *) clientData; -    if (objc < 2) { -    	Tcl_WrongNumArgs(interp, 1, objv, "option ?arg ...?"); -        return TCL_ERROR; +    Tcl_SetObjResult(interp, Tcl_ObjPrintf( +	    "not allowed to invoke subcommand %s of file", subcommandName)); +    Tcl_SetErrorCode(interp, "TCL", "SAFE", "SUBCOMMAND", NULL); +    return TCL_ERROR; +} + +/* + *---------------------------------------------------------------------- + * + * FileAttrAccessTimeCmd -- + * + *	This function is invoked to process the "file atime" Tcl command. See + *	the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	May update the access time on the file, if requested by the user. + * + *---------------------------------------------------------------------- + */ + +static int +FileAttrAccessTimeCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    Tcl_StatBuf buf; +    struct utimbuf tval; + +    if (objc < 2 || objc > 3) { +	Tcl_WrongNumArgs(interp, 1, objv, "name ?time?"); +	return TCL_ERROR;      } -    if (Tcl_GetIndexFromObj(interp, objv[1], fileOptions, "option", 0, -	    &index) != TCL_OK) { -    	return TCL_ERROR; +    if (GetStatBuf(interp, objv[1], Tcl_FSStat, &buf) != TCL_OK) { +	return TCL_ERROR;      } +    if (objc == 3) { +	/* +	 * Need separate variable for reading longs from an object on 64-bit +	 * platforms. [Bug 698146] +	 */ -    resultPtr = Tcl_GetObjResult(interp); -    switch ((enum options) index) { -    	case FILE_ATIME: { -	    struct stat buf; -	    char *fileName; -	    struct utimbuf tval; +	long newTime; -	    if ((objc < 3) || (objc > 4)) { -		Tcl_WrongNumArgs(interp, 2, objv, "name ?time?"); -		return TCL_ERROR; -	    } -	    if (GetStatBuf(interp, objv[2], TclStat, &buf) != TCL_OK) { -		return TCL_ERROR; -	    } -	    if (objc == 4) { -		if (Tcl_GetLongFromObj(interp, objv[3], -			(long*)(&buf.st_atime)) != TCL_OK) { -		    return TCL_ERROR; -		} -		tval.actime = buf.st_atime; -		tval.modtime = buf.st_mtime; -		fileName = Tcl_GetString(objv[2]); -		if (utime(fileName, &tval) != 0) { -		    Tcl_AppendStringsToObj(resultPtr, -			    "could not set access time for file \"", -			    fileName, "\": ", -			    Tcl_PosixError(interp), (char *) NULL); -		    return TCL_ERROR; -		} -		/* -		 * Do another stat to ensure that the we return the -		 * new recognized atime - hopefully the same as the -		 * one we sent in.  However, fs's like FAT don't -		 * even know what atime is. -		 */ -		if (GetStatBuf(interp, objv[2], TclStat, &buf) != TCL_OK) { -		    return TCL_ERROR; -		} -	    } -	    Tcl_SetLongObj(resultPtr, (long) buf.st_atime); -	    return TCL_OK; -	} -	case FILE_ATTRIBUTES: { -            return TclFileAttrsCmd(interp, objc, objv); +	if (TclGetLongFromObj(interp, objv[2], &newTime) != TCL_OK) { +	    return TCL_ERROR;  	} -	case FILE_CHANNELS: { -	    if ((objc < 2) || (objc > 3)) { -		Tcl_WrongNumArgs(interp, 2, objv, "?pattern?"); -		return TCL_ERROR; -	    } -	    return Tcl_GetChannelNamesEx(interp, -		    ((objc == 2) ? NULL : Tcl_GetString(objv[2]))); + +	tval.actime = newTime; +	tval.modtime = buf.st_mtime; + +	if (Tcl_FSUtime(objv[1], &tval) != 0) { +	    Tcl_SetObjResult(interp, Tcl_ObjPrintf( +		    "could not set access time for file \"%s\": %s", +		    TclGetString(objv[1]), Tcl_PosixError(interp))); +	    return TCL_ERROR;  	} -	case FILE_COPY: { -	    int result; -	    char **argv; -	    argv = StringifyObjects(objc, objv); -	    result = TclFileCopyCmd(interp, objc, argv); -	    ckfree((char *) argv); -	    return result; -	}	     -	case FILE_DELETE: { -	    int result; -	    char **argv; - -	    argv = StringifyObjects(objc, objv); -	    result = TclFileDeleteCmd(interp, objc, argv); -	    ckfree((char *) argv); -	    return result; +	/* +	 * Do another stat to ensure that the we return the new recognized +	 * atime - hopefully the same as the one we sent in. However, fs's +	 * like FAT don't even know what atime is. +	 */ + +	if (GetStatBuf(interp, objv[1], Tcl_FSStat, &buf) != TCL_OK) { +	    return TCL_ERROR;  	} -    	case FILE_DIRNAME: { -    	    int argc; -	    char **argv; +    } -	    if (objc != 3) { -		goto only3Args; -	    } -	    if (SplitPath(interp, objv[2], &argc, &argv) != TCL_OK) { -		return TCL_ERROR; -	    } +    Tcl_SetObjResult(interp, Tcl_NewLongObj((long) buf.st_atime)); +    return TCL_OK; +} + +/* + *---------------------------------------------------------------------- + * + * FileAttrModifyTimeCmd -- + * + *	This function is invoked to process the "file mtime" Tcl command. See + *	the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	May update the modification time on the file, if requested by the + *	user. + * + *---------------------------------------------------------------------- + */ -	    /* -	     * Return all but the last component.  If there is only one -	     * component, return it if the path was non-relative, otherwise -	     * return the current directory. -	     */ +static int +FileAttrModifyTimeCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    Tcl_StatBuf buf; +    struct utimbuf tval; -	    if (argc > 1) { -		Tcl_DString ds; - -		Tcl_DStringInit(&ds); -	    	Tcl_JoinPath(argc - 1, argv, &ds); -	    	Tcl_SetStringObj(resultPtr, Tcl_DStringValue(&ds), -			Tcl_DStringLength(&ds)); -		Tcl_DStringFree(&ds); -	    } else if ((argc == 0) -		    || (Tcl_GetPathType(argv[0]) == TCL_PATH_RELATIVE)) { -		Tcl_SetStringObj(resultPtr, -			((tclPlatform == TCL_PLATFORM_MAC) ? ":" : "."), 1); -	    } else { -	    	Tcl_SetStringObj(resultPtr, argv[0], -1); -	    } -	    ckfree((char *) argv); -	    return TCL_OK; -	} -	case FILE_EXECUTABLE: { -	    if (objc != 3) { -		goto only3Args; -	    } -	    return CheckAccess(interp, objv[2], X_OK); -	} -	case FILE_EXISTS: { -	    if (objc != 3) { -		goto only3Args; -	    } -	    return CheckAccess(interp, objv[2], F_OK); -	} -	case FILE_EXTENSION: { -	    char *fileName, *extension; -	    if (objc != 3) { -	    	goto only3Args; -	    } -	    fileName = Tcl_GetString(objv[2]); -	    extension = TclGetExtension(fileName); -	    if (extension != NULL) { -	    	Tcl_SetStringObj(resultPtr, extension, -1); -	    } -	    return TCL_OK; -	} -    	case FILE_ISDIRECTORY: { -	    int value; -	    struct stat buf; +    if (objc < 2 || objc > 3) { +	Tcl_WrongNumArgs(interp, 1, objv, "name ?time?"); +	return TCL_ERROR; +    } +    if (GetStatBuf(interp, objv[1], Tcl_FSStat, &buf) != TCL_OK) { +	return TCL_ERROR; +    } +    if (objc == 3) { +	/* +	 * Need separate variable for reading longs from an object on 64-bit +	 * platforms. [Bug 698146] +	 */ -	    if (objc != 3) { -		goto only3Args; -	    } -	    value = 0; -	    if (GetStatBuf(NULL, objv[2], TclStat, &buf) == TCL_OK) { -		value = S_ISDIR(buf.st_mode); -	    } -	    Tcl_SetBooleanObj(resultPtr, value); -	    return TCL_OK; -	} -    	case FILE_ISFILE: { -	    int value; -	    struct stat buf; -	     -    	    if (objc != 3) { -    	    	goto only3Args; -    	    } -	    value = 0; -	    if (GetStatBuf(NULL, objv[2], TclStat, &buf) == TCL_OK) { -		value = S_ISREG(buf.st_mode); -	    } -	    Tcl_SetBooleanObj(resultPtr, value); -	    return TCL_OK; -	} -	case FILE_JOIN: { -	    char **argv; -	    Tcl_DString ds; +	long newTime; -	    if (objc < 3) { -		Tcl_WrongNumArgs(interp, 2, objv, "name ?name ...?"); -		return TCL_ERROR; -	    } -	    argv = StringifyObjects(objc - 2, objv + 2); -	    Tcl_DStringInit(&ds); -	    Tcl_JoinPath(objc - 2, argv, &ds); -	    Tcl_SetStringObj(resultPtr, Tcl_DStringValue(&ds), -		    Tcl_DStringLength(&ds)); -	    Tcl_DStringFree(&ds); -	    ckfree((char *) argv); -	    return TCL_OK; -	} -    	case FILE_LSTAT: { -	    char *varName; -	    struct stat buf; - -    	    if (objc != 4) { -    	    	Tcl_WrongNumArgs(interp, 2, objv, "name varName"); -    	    	return TCL_ERROR; -    	    } -	    if (GetStatBuf(interp, objv[2], TclpLstat, &buf) != TCL_OK) { -		return TCL_ERROR; -	    } -	    varName = Tcl_GetString(objv[3]); -	    return StoreStatData(interp, varName, &buf); +	if (TclGetLongFromObj(interp, objv[2], &newTime) != TCL_OK) { +	    return TCL_ERROR;  	} -	case FILE_MTIME: { -	    struct stat buf; -	    char *fileName; -	    struct utimbuf tval; -	    if ((objc < 3) || (objc > 4)) { -		Tcl_WrongNumArgs(interp, 2, objv, "name ?time?"); -		return TCL_ERROR; -	    } -	    if (GetStatBuf(interp, objv[2], TclStat, &buf) != TCL_OK) { -		return TCL_ERROR; -	    } -	    if (objc == 4) { -		if (Tcl_GetLongFromObj(interp, objv[3], -			(long*)(&buf.st_mtime)) != TCL_OK) { -		    return TCL_ERROR; -		} -		tval.actime = buf.st_atime; -		tval.modtime = buf.st_mtime; -		fileName = Tcl_GetString(objv[2]); -		if (utime(fileName, &tval) != 0) { -		    Tcl_AppendStringsToObj(resultPtr, -			    "could not set modification time for file \"", -			    fileName, "\": ", -			    Tcl_PosixError(interp), (char *) NULL); -		    return TCL_ERROR; -		} -		/* -		 * Do another stat to ensure that the we return the -		 * new recognized atime - hopefully the same as the -		 * one we sent in.  However, fs's like FAT don't -		 * even know what atime is. -		 */ -		if (GetStatBuf(interp, objv[2], TclStat, &buf) != TCL_OK) { -		    return TCL_ERROR; -		} -	    } -	    Tcl_SetLongObj(resultPtr, (long) buf.st_mtime); -	    return TCL_OK; -	} -	case FILE_MKDIR: { -	    char **argv; -	    int result; +	tval.actime = buf.st_atime; +	tval.modtime = newTime; -	    if (objc < 3) { -		Tcl_WrongNumArgs(interp, 2, objv, "name ?name ...?"); -		return TCL_ERROR; -	    } -	    argv = StringifyObjects(objc, objv); -	    result = TclFileMakeDirsCmd(interp, objc, argv); -	    ckfree((char *) argv); -	    return result; +	if (Tcl_FSUtime(objv[1], &tval) != 0) { +	    Tcl_SetObjResult(interp, Tcl_ObjPrintf( +		    "could not set modification time for file \"%s\": %s", +		    TclGetString(objv[1]), Tcl_PosixError(interp))); +	    return TCL_ERROR;  	} -	case FILE_NATIVENAME: { -	    char *fileName; -	    Tcl_DString ds; -	    if (objc != 3) { -		goto only3Args; -	    } -	    fileName = Tcl_GetString(objv[2]); -	    fileName = Tcl_TranslateFileName(interp, fileName, &ds); -	    if (fileName == NULL) { -		return TCL_ERROR; -	    } -	    Tcl_SetStringObj(resultPtr, fileName, Tcl_DStringLength(&ds)); -	    Tcl_DStringFree(&ds); -	    return TCL_OK; +	/* +	 * Do another stat to ensure that the we return the new recognized +	 * mtime - hopefully the same as the one we sent in. +	 */ + +	if (GetStatBuf(interp, objv[1], Tcl_FSStat, &buf) != TCL_OK) { +	    return TCL_ERROR;  	} -	case FILE_OWNED: { -	    int value; -	    struct stat buf; -	     -	    if (objc != 3) { -		goto only3Args; -	    } -	    value = 0; -	    if (GetStatBuf(NULL, objv[2], TclStat, &buf) == TCL_OK) { -		/* -		 * For Windows and Macintosh, there are no user ids  -		 * associated with a file, so we always return 1. -		 */ - -#if (defined(__WIN32__) || defined(MAC_TCL)) -		value = 1; +    } + +    Tcl_SetObjResult(interp, Tcl_NewLongObj((long) buf.st_mtime)); +    return TCL_OK; +} + +/* + *---------------------------------------------------------------------- + * + * FileAttrLinkStatCmd -- + * + *	This function is invoked to process the "file lstat" Tcl command. See + *	the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	Writes to an array named by the user. + * + *---------------------------------------------------------------------- + */ + +static int +FileAttrLinkStatCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    Tcl_StatBuf buf; + +    if (objc != 3) { +	Tcl_WrongNumArgs(interp, 1, objv, "name varName"); +	return TCL_ERROR; +    } +    if (GetStatBuf(interp, objv[1], Tcl_FSLstat, &buf) != TCL_OK) { +	return TCL_ERROR; +    } +    return StoreStatData(interp, objv[2], &buf); +} + +/* + *---------------------------------------------------------------------- + * + * FileAttrStatCmd -- + * + *	This function is invoked to process the "file stat" Tcl command. See + *	the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	Writes to an array named by the user. + * + *---------------------------------------------------------------------- + */ + +static int +FileAttrStatCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    Tcl_StatBuf buf; + +    if (objc != 3) { +	Tcl_WrongNumArgs(interp, 1, objv, "name varName"); +	return TCL_ERROR; +    } +    if (GetStatBuf(interp, objv[1], Tcl_FSStat, &buf) != TCL_OK) { +	return TCL_ERROR; +    } +    return StoreStatData(interp, objv[2], &buf); +} + +/* + *---------------------------------------------------------------------- + * + * FileAttrTypeCmd -- + * + *	This function is invoked to process the "file type" Tcl command. See + *	the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	None. + * + *---------------------------------------------------------------------- + */ + +static int +FileAttrTypeCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    Tcl_StatBuf buf; + +    if (objc != 2) { +	Tcl_WrongNumArgs(interp, 1, objv, "name"); +	return TCL_ERROR; +    } +    if (GetStatBuf(interp, objv[1], Tcl_FSLstat, &buf) != TCL_OK) { +	return TCL_ERROR; +    } +    Tcl_SetObjResult(interp, Tcl_NewStringObj( +	    GetTypeFromMode((unsigned short) buf.st_mode), -1)); +    return TCL_OK; +} + +/* + *---------------------------------------------------------------------- + * + * FileAttrSizeCmd -- + * + *	This function is invoked to process the "file size" Tcl command. See + *	the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	None. + * + *---------------------------------------------------------------------- + */ + +static int +FileAttrSizeCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    Tcl_StatBuf buf; + +    if (objc != 2) { +	Tcl_WrongNumArgs(interp, 1, objv, "name"); +	return TCL_ERROR; +    } +    if (GetStatBuf(interp, objv[1], Tcl_FSStat, &buf) != TCL_OK) { +	return TCL_ERROR; +    } +    Tcl_SetObjResult(interp, Tcl_NewWideIntObj((Tcl_WideInt) buf.st_size)); +    return TCL_OK; +} + +/* + *---------------------------------------------------------------------- + * + * FileAttrIsDirectoryCmd -- + * + *	This function is invoked to process the "file isdirectory" Tcl + *	command. See the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	None. + * + *---------------------------------------------------------------------- + */ + +static int +FileAttrIsDirectoryCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    Tcl_StatBuf buf; +    int value = 0; + +    if (objc != 2) { +	Tcl_WrongNumArgs(interp, 1, objv, "name"); +	return TCL_ERROR; +    } +    if (GetStatBuf(NULL, objv[1], Tcl_FSStat, &buf) == TCL_OK) { +	value = S_ISDIR(buf.st_mode); +    } +    Tcl_SetObjResult(interp, Tcl_NewBooleanObj(value)); +    return TCL_OK; +} + +/* + *---------------------------------------------------------------------- + * + * FileAttrIsExecutableCmd -- + * + *	This function is invoked to process the "file executable" Tcl command. + *	See the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	None. + * + *---------------------------------------------------------------------- + */ + +static int +FileAttrIsExecutableCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    if (objc != 2) { +	Tcl_WrongNumArgs(interp, 1, objv, "name"); +	return TCL_ERROR; +    } +    return CheckAccess(interp, objv[1], X_OK); +} + +/* + *---------------------------------------------------------------------- + * + * FileAttrIsExistingCmd -- + * + *	This function is invoked to process the "file exists" Tcl command. See + *	the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	None. + * + *---------------------------------------------------------------------- + */ + +static int +FileAttrIsExistingCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    if (objc != 2) { +	Tcl_WrongNumArgs(interp, 1, objv, "name"); +	return TCL_ERROR; +    } +    return CheckAccess(interp, objv[1], F_OK); +} + +/* + *---------------------------------------------------------------------- + * + * FileAttrIsFileCmd -- + * + *	This function is invoked to process the "file isfile" Tcl command. See + *	the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	None. + * + *---------------------------------------------------------------------- + */ + +static int +FileAttrIsFileCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    Tcl_StatBuf buf; +    int value = 0; + +    if (objc != 2) { +	Tcl_WrongNumArgs(interp, 1, objv, "name"); +	return TCL_ERROR; +    } +    if (GetStatBuf(NULL, objv[1], Tcl_FSStat, &buf) == TCL_OK) { +	value = S_ISREG(buf.st_mode); +    } +    Tcl_SetObjResult(interp, Tcl_NewBooleanObj(value)); +    return TCL_OK; +} + +/* + *---------------------------------------------------------------------- + * + * FileAttrIsOwnedCmd -- + * + *	This function is invoked to process the "file owned" Tcl command. See + *	the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	None. + * + *---------------------------------------------------------------------- + */ + +static int +FileAttrIsOwnedCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    Tcl_StatBuf buf; +    int value = 0; + +    if (objc != 2) { +	Tcl_WrongNumArgs(interp, 1, objv, "name"); +	return TCL_ERROR; +    } +    if (GetStatBuf(NULL, objv[1], Tcl_FSStat, &buf) == TCL_OK) { +	/* +	 * For Windows, there are no user ids associated with a file, so we +	 * always return 1. +	 * +	 * TODO: use GetSecurityInfo to get the real owner of the file and +	 * test for equivalence to the current user. +	 */ + +#if defined(_WIN32) || defined(__CYGWIN__) +	value = 1;  #else -		value = (geteuid() == buf.st_uid); +	value = (geteuid() == buf.st_uid);  #endif -	    }	     -	    Tcl_SetBooleanObj(resultPtr, value); -	    return TCL_OK; -	} -	case FILE_PATHTYPE: { -	    char *fileName; +    } +    Tcl_SetObjResult(interp, Tcl_NewBooleanObj(value)); +    return TCL_OK; +} + +/* + *---------------------------------------------------------------------- + * + * FileAttrIsReadableCmd -- + * + *	This function is invoked to process the "file readable" Tcl command. + *	See the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	None. + * + *---------------------------------------------------------------------- + */ -	    if (objc != 3) { -		goto only3Args; -	    } -	    fileName = Tcl_GetString(objv[2]); -	    switch (Tcl_GetPathType(fileName)) { -	    	case TCL_PATH_ABSOLUTE: -	    	    Tcl_SetStringObj(resultPtr, "absolute", -1); -		    break; -	    	case TCL_PATH_RELATIVE: -	    	    Tcl_SetStringObj(resultPtr, "relative", -1); -	    	    break; -	    	case TCL_PATH_VOLUME_RELATIVE: -		    Tcl_SetStringObj(resultPtr, "volumerelative", -1); -		    break; -	    } -	    return TCL_OK; -	} -    	case FILE_READABLE: { -	    if (objc != 3) { -		goto only3Args; -	    } -	    return CheckAccess(interp, objv[2], R_OK); -	} -	case FILE_READLINK: { -	    char *fileName, *contents; -	    Tcl_DString name, link; -		 -	    if (objc != 3) { -		goto only3Args; -	    } -	     -	    fileName = Tcl_GetString(objv[2]); -	    fileName = Tcl_TranslateFileName(interp, fileName, &name); -	    if (fileName == NULL) { -		return TCL_ERROR; -	    } +static int +FileAttrIsReadableCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    if (objc != 2) { +	Tcl_WrongNumArgs(interp, 1, objv, "name"); +	return TCL_ERROR; +    } +    return CheckAccess(interp, objv[1], R_OK); +} + +/* + *---------------------------------------------------------------------- + * + * FileAttrIsWritableCmd -- + * + *	This function is invoked to process the "file writable" Tcl command. + *	See the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	None. + * + *---------------------------------------------------------------------- + */ -	    /* -	     * If S_IFLNK isn't defined it means that the machine doesn't -	     * support symbolic links, so the file can't possibly be a -	     * symbolic link.  Generate an EINVAL error, which is what -	     * happens on machines that do support symbolic links when -	     * you invoke readlink on a file that isn't a symbolic link. -	     */ +static int +FileAttrIsWritableCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    if (objc != 2) { +	Tcl_WrongNumArgs(interp, 1, objv, "name"); +	return TCL_ERROR; +    } +    return CheckAccess(interp, objv[1], W_OK); +} + +/* + *---------------------------------------------------------------------- + * + * PathDirNameCmd -- + * + *	This function is invoked to process the "file dirname" Tcl command. + *	See the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	None. + * + *---------------------------------------------------------------------- + */ -#ifndef S_IFLNK -	    contents = NULL; -	    errno = EINVAL; -#else -	    contents = TclpReadlink(fileName, &link); -#endif /* S_IFLNK */ - -	    Tcl_DStringFree(&name); -	    if (contents == NULL) { -	    	Tcl_AppendResult(interp, "could not readlink \"",  -	    		Tcl_GetString(objv[2]), "\": ",  -	    		Tcl_PosixError(interp), (char *) NULL); -	    	return TCL_ERROR; -	    } -	    Tcl_DStringResult(interp, &link); -	    return TCL_OK; -	} -	case FILE_RENAME: { -	    int result; -	    char **argv; +static int +PathDirNameCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    Tcl_Obj *dirPtr; -	    argv = StringifyObjects(objc, objv); -	    result = TclFileRenameCmd(interp, objc, argv); -	    ckfree((char *) argv); -	    return result; -	} -	case FILE_ROOTNAME: { -	    int length; -	    char *fileName, *extension; -	     -	    if (objc != 3) { -		goto only3Args; -	    } -	    fileName = Tcl_GetStringFromObj(objv[2], &length); -	    extension = TclGetExtension(fileName); -	    if (extension == NULL) { -	    	Tcl_SetObjResult(interp, objv[2]); -	    } else { -	        Tcl_SetStringObj(resultPtr, fileName, -			(int) (length - strlen(extension))); -	    } -	    return TCL_OK; -	} -	case FILE_SIZE: { -	    struct stat buf; -	     -	    if (objc != 3) { -		goto only3Args; -	    } -	    if (GetStatBuf(interp, objv[2], TclStat, &buf) != TCL_OK) { -		return TCL_ERROR; -	    } -	    Tcl_SetLongObj(resultPtr, (long) buf.st_size); -	    return TCL_OK; -	} -	case FILE_SPLIT: { -	    int i, argc; -	    char **argv; -	    char *fileName; -	    Tcl_Obj *objPtr; -	     -	    if (objc != 3) { -		goto only3Args; -	    } -	    fileName = Tcl_GetString(objv[2]); -	    Tcl_SplitPath(fileName, &argc, &argv); -	    for (i = 0; i < argc; i++) { -		objPtr = Tcl_NewStringObj(argv[i], -1); -		Tcl_ListObjAppendElement(NULL, resultPtr, objPtr); -	    } -	    ckfree((char *) argv); -	    return TCL_OK; -	} -	case FILE_STAT: { -	    char *varName; -	    struct stat buf; -	     -	    if (objc != 4) { -	    	Tcl_WrongNumArgs(interp, 1, objv, "stat name varName"); -		return TCL_ERROR; -	    } -	    if (GetStatBuf(interp, objv[2], TclStat, &buf) != TCL_OK) { -		return TCL_ERROR; -	    } -	    varName = Tcl_GetString(objv[3]); -	    return StoreStatData(interp, varName, &buf); -	} -    	case FILE_TAIL: { -	    int argc; -	    char **argv; +    if (objc != 2) { +	Tcl_WrongNumArgs(interp, 1, objv, "name"); +	return TCL_ERROR; +    } +    dirPtr = TclPathPart(interp, objv[1], TCL_PATH_DIRNAME); +    if (dirPtr == NULL) { +	return TCL_ERROR; +    } +    Tcl_SetObjResult(interp, dirPtr); +    Tcl_DecrRefCount(dirPtr); +    return TCL_OK; +} + +/* + *---------------------------------------------------------------------- + * + * PathExtensionCmd -- + * + *	This function is invoked to process the "file extension" Tcl command. + *	See the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	None. + * + *---------------------------------------------------------------------- + */ -	    if (objc != 3) { -		goto only3Args; -	    } -	    if (SplitPath(interp, objv[2], &argc, &argv) != TCL_OK) { -		return TCL_ERROR; -	    } +static int +PathExtensionCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    Tcl_Obj *dirPtr; -	    /* -	     * Return the last component, unless it is the only component, -	     * and it is the root of an absolute path. -	     */ +    if (objc != 2) { +	Tcl_WrongNumArgs(interp, 1, objv, "name"); +	return TCL_ERROR; +    } +    dirPtr = TclPathPart(interp, objv[1], TCL_PATH_EXTENSION); +    if (dirPtr == NULL) { +	return TCL_ERROR; +    } +    Tcl_SetObjResult(interp, dirPtr); +    Tcl_DecrRefCount(dirPtr); +    return TCL_OK; +} + +/* + *---------------------------------------------------------------------- + * + * PathRootNameCmd -- + * + *	This function is invoked to process the "file root" Tcl command. See + *	the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	None. + * + *---------------------------------------------------------------------- + */ -	    if (argc > 0) { -	    	if ((argc > 1) -		    	|| (Tcl_GetPathType(argv[0]) == TCL_PATH_RELATIVE)) { -		    Tcl_SetStringObj(resultPtr, argv[argc - 1], -1); -	    	} -	    } -	    ckfree((char *) argv); -	    return TCL_OK; -	} -	case FILE_TYPE: { -	    struct stat buf; +static int +PathRootNameCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    Tcl_Obj *dirPtr; -	    if (objc != 3) { -	    	goto only3Args; -	    } -	    if (GetStatBuf(interp, objv[2], TclpLstat, &buf) != TCL_OK) { -		return TCL_ERROR; -	    } -	    Tcl_SetStringObj(resultPtr,  -		    GetTypeFromMode((unsigned short) buf.st_mode), -1); -	    return TCL_OK; -	} -	case FILE_VOLUMES: { -	    if (objc != 2) { -		Tcl_WrongNumArgs(interp, 2, objv, NULL); -		return TCL_ERROR; -	    } -	    return TclpListVolumes(interp); -	} -	case FILE_WRITABLE: { -	    if (objc != 3) { -	    	goto only3Args; -	    } -	    return CheckAccess(interp, objv[2], W_OK); -	} +    if (objc != 2) { +	Tcl_WrongNumArgs(interp, 1, objv, "name"); +	return TCL_ERROR;      } +    dirPtr = TclPathPart(interp, objv[1], TCL_PATH_ROOT); +    if (dirPtr == NULL) { +	return TCL_ERROR; +    } +    Tcl_SetObjResult(interp, dirPtr); +    Tcl_DecrRefCount(dirPtr); +    return TCL_OK; +} + +/* + *---------------------------------------------------------------------- + * + * PathTailCmd -- + * + *	This function is invoked to process the "file tail" Tcl command. See + *	the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	None. + * + *---------------------------------------------------------------------- + */ -    only3Args: -    Tcl_WrongNumArgs(interp, 2, objv, "name"); -    return TCL_ERROR; +static int +PathTailCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    Tcl_Obj *dirPtr; + +    if (objc != 2) { +	Tcl_WrongNumArgs(interp, 1, objv, "name"); +	return TCL_ERROR; +    } +    dirPtr = TclPathPart(interp, objv[1], TCL_PATH_TAIL); +    if (dirPtr == NULL) { +	return TCL_ERROR; +    } +    Tcl_SetObjResult(interp, dirPtr); +    Tcl_DecrRefCount(dirPtr); +    return TCL_OK;  }  /* - *--------------------------------------------------------------------------- + *----------------------------------------------------------------------   * - * SplitPath -- + * PathFilesystemCmd --   * - *	Utility procedure used by Tcl_FileObjCmd() to split a path. - *	Differs from standard Tcl_SplitPath in its handling of home - *	directories; Tcl_SplitPath preserves the "~" while this - *	procedure computes the actual full path name. + *	This function is invoked to process the "file system" Tcl command. See + *	the user documentation for details on what it does.   *   * Results: - *	The return value is TCL_OK if the path could be split, TCL_ERROR - *	otherwise.  If TCL_ERROR was returned, an error message is left - *	in interp.  If TCL_OK was returned, *argvPtr is set to a newly - *	allocated array of strings that represent the individual - *	directories in the specified path, and *argcPtr is filled with - *	the length of that array. + *	A standard Tcl result.   *   * Side effects: - *	Memory allocated.  The caller must eventually free this memory - *	by calling ckfree() on *argvPtr. + *	None.   * - *--------------------------------------------------------------------------- + *---------------------------------------------------------------------- + */ + +static int +PathFilesystemCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    Tcl_Obj *fsInfo; + +    if (objc != 2) { +	Tcl_WrongNumArgs(interp, 1, objv, "name"); +	return TCL_ERROR; +    } +    fsInfo = Tcl_FSFileSystemInfo(objv[1]); +    if (fsInfo == NULL) { +	Tcl_SetObjResult(interp, Tcl_NewStringObj("unrecognised path", -1)); +	Tcl_SetErrorCode(interp, "TCL", "LOOKUP", "FILESYSTEM", +		Tcl_GetString(objv[1]), NULL); +	return TCL_ERROR; +    } +    Tcl_SetObjResult(interp, fsInfo); +    return TCL_OK; +} + +/* + *---------------------------------------------------------------------- + * + * PathJoinCmd -- + * + *	This function is invoked to process the "file join" Tcl command. See + *	the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	None. + * + *----------------------------------------------------------------------   */  static int -SplitPath(interp, objPtr, argcPtr, argvPtr) -    Tcl_Interp *interp;		/* Interp for error return.  May be NULL. */ -    Tcl_Obj *objPtr;		/* Path to be split. */ -    int *argcPtr;		/* Filled with length of following array. */ -    char ***argvPtr;		/* Filled with array of strings representing -				 * the elements of the specified path. */ +PathJoinCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[])  { -    char *fileName; +    if (objc < 2) { +	Tcl_WrongNumArgs(interp, 1, objv, "name ?name ...?"); +	return TCL_ERROR; +    } +    Tcl_SetObjResult(interp, TclJoinPath(objc - 1, objv + 1)); +    return TCL_OK; +} + +/* + *---------------------------------------------------------------------- + * + * PathNativeNameCmd -- + * + *	This function is invoked to process the "file nativename" Tcl command. + *	See the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	None. + * + *---------------------------------------------------------------------- + */ -    fileName = Tcl_GetString(objPtr); +static int +PathNativeNameCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    Tcl_DString ds; -    /* -     * If there is only one element, and it starts with a tilde, -     * perform tilde substitution and resplit the path. -     */ +    if (objc != 2) { +	Tcl_WrongNumArgs(interp, 1, objv, "name"); +	return TCL_ERROR; +    } +    if (Tcl_TranslateFileName(interp, TclGetString(objv[1]), &ds) == NULL) { +	return TCL_ERROR; +    } +    Tcl_SetObjResult(interp, TclDStringToObj(&ds)); +    return TCL_OK; +} + +/* + *---------------------------------------------------------------------- + * + * PathNormalizeCmd -- + * + *	This function is invoked to process the "file normalize" Tcl command. + *	See the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	None. + * + *---------------------------------------------------------------------- + */ -    Tcl_SplitPath(fileName, argcPtr, argvPtr); -    if ((*argcPtr == 1) && (fileName[0] == '~')) { -	Tcl_DString ds; -	 -	ckfree((char *) *argvPtr); -	fileName = Tcl_TranslateFileName(interp, fileName, &ds); -	if (fileName == NULL) { +static int +PathNormalizeCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    Tcl_Obj *fileName; + +    if (objc != 2) { +	Tcl_WrongNumArgs(interp, 1, objv, "name"); +	return TCL_ERROR; +    } +    fileName = Tcl_FSGetNormalizedPath(interp, objv[1]); +    if (fileName == NULL) { +	return TCL_ERROR; +    } +    Tcl_SetObjResult(interp, fileName); +    return TCL_OK; +} + +/* + *---------------------------------------------------------------------- + * + * PathSplitCmd -- + * + *	This function is invoked to process the "file split" Tcl command. See + *	the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	None. + * + *---------------------------------------------------------------------- + */ + +static int +PathSplitCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    Tcl_Obj *res; + +    if (objc != 2) { +	Tcl_WrongNumArgs(interp, 1, objv, "name"); +	return TCL_ERROR; +    } +    res = Tcl_FSSplitPath(objv[1], NULL); +    if (res == NULL) { +	Tcl_SetObjResult(interp, Tcl_ObjPrintf( +		"could not read \"%s\": no such file or directory", +		TclGetString(objv[1]))); +	Tcl_SetErrorCode(interp, "TCL", "OPERATION", "PATHSPLIT", "NONESUCH", +		NULL); +	return TCL_ERROR; +    } +    Tcl_SetObjResult(interp, res); +    return TCL_OK; +} + +/* + *---------------------------------------------------------------------- + * + * PathTypeCmd -- + * + *	This function is invoked to process the "file pathtype" Tcl command. + *	See the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	None. + * + *---------------------------------------------------------------------- + */ + +static int +PathTypeCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    Tcl_Obj *typeName; + +    if (objc != 2) { +	Tcl_WrongNumArgs(interp, 1, objv, "name"); +	return TCL_ERROR; +    } +    switch (Tcl_FSGetPathType(objv[1])) { +    case TCL_PATH_ABSOLUTE: +	TclNewLiteralStringObj(typeName, "absolute"); +	break; +    case TCL_PATH_RELATIVE: +	TclNewLiteralStringObj(typeName, "relative"); +	break; +    case TCL_PATH_VOLUME_RELATIVE: +	TclNewLiteralStringObj(typeName, "volumerelative"); +	break; +    default: +	/* Should be unreachable */ +	return TCL_OK; +    } +    Tcl_SetObjResult(interp, typeName); +    return TCL_OK; +} + +/* + *---------------------------------------------------------------------- + * + * FilesystemSeparatorCmd -- + * + *	This function is invoked to process the "file separator" Tcl command. + *	See the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	None. + * + *---------------------------------------------------------------------- + */ + +static int +FilesystemSeparatorCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    if (objc < 1 || objc > 2) { +	Tcl_WrongNumArgs(interp, 1, objv, "?name?"); +	return TCL_ERROR; +    } +    if (objc == 1) { +	const char *separator = NULL; /* lint */ + +	switch (tclPlatform) { +	case TCL_PLATFORM_UNIX: +	    separator = "/"; +	    break; +	case TCL_PLATFORM_WINDOWS: +	    separator = "\\"; +	    break; +	} +	Tcl_SetObjResult(interp, Tcl_NewStringObj(separator, 1)); +    } else { +	Tcl_Obj *separatorObj = Tcl_FSPathSeparator(objv[1]); + +	if (separatorObj == NULL) { +	    Tcl_SetObjResult(interp, Tcl_NewStringObj( +		    "unrecognised path", -1)); +	    Tcl_SetErrorCode(interp, "TCL", "LOOKUP", "FILESYSTEM", +		    Tcl_GetString(objv[1]), NULL);  	    return TCL_ERROR;  	} -	Tcl_SplitPath(fileName, argcPtr, argvPtr); -	Tcl_DStringFree(&ds); +	Tcl_SetObjResult(interp, separatorObj);      }      return TCL_OK;  }  /* + *---------------------------------------------------------------------- + * + * FilesystemVolumesCmd -- + * + *	This function is invoked to process the "file volumes" Tcl command. + *	See the user documentation for details on what it does. + * + * Results: + *	A standard Tcl result. + * + * Side effects: + *	None. + * + *---------------------------------------------------------------------- + */ + +static int +FilesystemVolumesCmd( +    ClientData clientData, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    if (objc != 1) { +	Tcl_WrongNumArgs(interp, 1, objv, NULL); +	return TCL_ERROR; +    } +    Tcl_SetObjResult(interp, Tcl_FSListVolumes()); +    return TCL_OK; +} + +/*   *---------------------------------------------------------------------------   *   * CheckAccess --   * - *	Utility procedure used by Tcl_FileObjCmd() to query file - *	attributes available through the access() system call. + *	Utility procedure used by Tcl_FileObjCmd() to query file attributes + *	available through the access() system call.   *   * Results: - *	Always returns TCL_OK.  Sets interp's result to boolean true or - *	false depending on whether the file has the specified attribute. + *	Always returns TCL_OK. Sets interp's result to boolean true or false + *	depending on whether the file has the specified attribute.   *   * Side effects:   *	None.   *   *---------------------------------------------------------------------------   */ -   +  static int -CheckAccess(interp, objPtr, mode) -    Tcl_Interp *interp;		/* Interp for status return.  Must not be +CheckAccess( +    Tcl_Interp *interp,		/* Interp for status return. Must not be  				 * NULL. */ -    Tcl_Obj *objPtr;		/* Name of file to check. */ -    int mode;			/* Attribute to check; passed as argument to +    Tcl_Obj *pathPtr,		/* Name of file to check. */ +    int mode)			/* Attribute to check; passed as argument to  				 * access(). */  {      int value; -    char *fileName; -    Tcl_DString ds; -     -    fileName = Tcl_GetString(objPtr); -    fileName = Tcl_TranslateFileName(interp, fileName, &ds); -    if (fileName == NULL) { + +    if (Tcl_FSConvertToPathType(interp, pathPtr) != TCL_OK) {  	value = 0;      } else { -	value = (TclAccess(fileName, mode) == 0); -        Tcl_DStringFree(&ds); +	value = (Tcl_FSAccess(pathPtr, mode) == 0);      } -    Tcl_SetBooleanObj(Tcl_GetObjResult(interp), value); +    Tcl_SetObjResult(interp, Tcl_NewBooleanObj(value));      return TCL_OK;  } @@ -1400,14 +2187,14 @@ CheckAccess(interp, objPtr, mode)   *   * GetStatBuf --   * - *	Utility procedure used by Tcl_FileObjCmd() to query file - *	attributes available through the stat() or lstat() system call. + *	Utility procedure used by Tcl_FileObjCmd() to query file attributes + *	available through the stat() or lstat() system call.   *   * Results: - *	The return value is TCL_OK if the specified file exists and can - *	be stat'ed, TCL_ERROR otherwise.  If TCL_ERROR is returned, an - *	error message is left in interp's result.  If TCL_OK is returned, - *	*statPtr is filled with information about the specified file. + *	The return value is TCL_OK if the specified file exists and can be + *	stat'ed, TCL_ERROR otherwise. If TCL_ERROR is returned, an error + *	message is left in interp's result. If TCL_OK is returned, *statPtr is + *	filled with information about the specified file.   *   * Side effects:   *	None. @@ -1416,32 +2203,27 @@ CheckAccess(interp, objPtr, mode)   */  static int -GetStatBuf(interp, objPtr, statProc, statPtr) -    Tcl_Interp *interp;		/* Interp for error return.  May be NULL. */ -    Tcl_Obj *objPtr;		/* Path name to examine. */ -    StatProc *statProc;		/* Either stat() or lstat() depending on +GetStatBuf( +    Tcl_Interp *interp,		/* Interp for error return. May be NULL. */ +    Tcl_Obj *pathPtr,		/* Path name to examine. */ +    Tcl_FSStatProc *statProc,	/* Either stat() or lstat() depending on  				 * desired behavior. */ -    struct stat *statPtr;	/* Filled with info about file obtained by +    Tcl_StatBuf *statPtr)	/* Filled with info about file obtained by  				 * calling (*statProc)(). */  { -    char *fileName; -    Tcl_DString ds;      int status; -     -    fileName = Tcl_GetString(objPtr); -    fileName = Tcl_TranslateFileName(interp, fileName, &ds); -    if (fileName == NULL) { + +    if (Tcl_FSConvertToPathType(interp, pathPtr) != TCL_OK) {  	return TCL_ERROR;      } -    status = (*statProc)(Tcl_DStringValue(&ds), statPtr); -    Tcl_DStringFree(&ds); -     +    status = statProc(pathPtr, statPtr); +      if (status < 0) {  	if (interp != NULL) { -	    Tcl_AppendResult(interp, "could not read \"", -		    Tcl_GetString(objPtr), "\": ", -		    Tcl_PosixError(interp), (char *) NULL); +	    Tcl_SetObjResult(interp, Tcl_ObjPrintf( +		    "could not read \"%s\": %s", +		    TclGetString(pathPtr), Tcl_PosixError(interp)));  	}  	return TCL_ERROR;      } @@ -1453,13 +2235,13 @@ GetStatBuf(interp, objPtr, statProc, statPtr)   *   * StoreStatData --   * - *	This is a utility procedure that breaks out the fields of a - *	"stat" structure and stores them in textual form into the - *	elements of an associative array. + *	This is a utility procedure that breaks out the fields of a "stat" + *	structure and stores them in textual form into the elements of an + *	associative array.   *   * Results: - *	Returns a standard Tcl return value.  If an error occurs then - *	a message is left in interp's result. + *	Returns a standard Tcl return value. If an error occurs then a message + *	is left in interp's result.   *   * Side effects:   *	Elements of the associative array given by "varName" are modified. @@ -1468,70 +2250,59 @@ GetStatBuf(interp, objPtr, statProc, statPtr)   */  static int -StoreStatData(interp, varName, statPtr) -    Tcl_Interp *interp;			/* Interpreter for error reports. */ -    char *varName;			/* Name of associative array variable -					 * in which to store stat results. */ -    struct stat *statPtr;		/* Pointer to buffer containing -					 * stat data to store in varName. */ -{ -    char string[TCL_INTEGER_SPACE]; - -    TclFormatInt(string, (long) statPtr->st_dev); -    if (Tcl_SetVar2(interp, varName, "dev", string, TCL_LEAVE_ERR_MSG) -	    == NULL) { -	return TCL_ERROR; -    } -    TclFormatInt(string, (long) statPtr->st_ino); -    if (Tcl_SetVar2(interp, varName, "ino", string, TCL_LEAVE_ERR_MSG) -	    == NULL) { -	return TCL_ERROR; -    } -    TclFormatInt(string, (unsigned short) statPtr->st_mode); -    if (Tcl_SetVar2(interp, varName, "mode", string, TCL_LEAVE_ERR_MSG) -	    == NULL) { -	return TCL_ERROR; -    } -    TclFormatInt(string, (long) statPtr->st_nlink); -    if (Tcl_SetVar2(interp, varName, "nlink", string, TCL_LEAVE_ERR_MSG) -	    == NULL) { -	return TCL_ERROR; -    } -    TclFormatInt(string, (long) statPtr->st_uid); -    if (Tcl_SetVar2(interp, varName, "uid", string, TCL_LEAVE_ERR_MSG) -	    == NULL) { -	return TCL_ERROR; -    } -    TclFormatInt(string, (long) statPtr->st_gid); -    if (Tcl_SetVar2(interp, varName, "gid", string, TCL_LEAVE_ERR_MSG) -	    == NULL) { -	return TCL_ERROR; -    } -    sprintf(string, "%lu", (unsigned long) statPtr->st_size); -    if (Tcl_SetVar2(interp, varName, "size", string, TCL_LEAVE_ERR_MSG) -	    == NULL) { -	return TCL_ERROR; -    } -    TclFormatInt(string, (long) statPtr->st_atime); -    if (Tcl_SetVar2(interp, varName, "atime", string, TCL_LEAVE_ERR_MSG) -	    == NULL) { -	return TCL_ERROR; -    } -    TclFormatInt(string, (long) statPtr->st_mtime); -    if (Tcl_SetVar2(interp, varName, "mtime", string, TCL_LEAVE_ERR_MSG) -	    == NULL) { -	return TCL_ERROR; -    } -    TclFormatInt(string, (long) statPtr->st_ctime); -    if (Tcl_SetVar2(interp, varName, "ctime", string, TCL_LEAVE_ERR_MSG) -	    == NULL) { -	return TCL_ERROR; -    } -    if (Tcl_SetVar2(interp, varName, "type", -	    GetTypeFromMode((unsigned short) statPtr->st_mode),  -	    TCL_LEAVE_ERR_MSG) == NULL) { -	return TCL_ERROR; -    } +StoreStatData( +    Tcl_Interp *interp,		/* Interpreter for error reports. */ +    Tcl_Obj *varName,		/* Name of associative array variable in which +				 * to store stat results. */ +    Tcl_StatBuf *statPtr)	/* Pointer to buffer containing stat data to +				 * store in varName. */ +{ +    Tcl_Obj *field, *value; +    register unsigned short mode; + +    /* +     * Assume Tcl_ObjSetVar2() does not keep a copy of the field name! +     * +     * Might be a better idea to call Tcl_SetVar2Ex() instead, except we want +     * to have an object (i.e. possibly cached) array variable name but a +     * string element name, so no API exists. Messy. +     */ + +#define STORE_ARY(fieldName, object) \ +    TclNewLiteralStringObj(field, fieldName);				\ +    Tcl_IncrRefCount(field);						\ +    value = (object);							\ +    if (Tcl_ObjSetVar2(interp,varName,field,value,TCL_LEAVE_ERR_MSG)==NULL) { \ +	TclDecrRefCount(field);						\ +	return TCL_ERROR;						\ +    }									\ +    TclDecrRefCount(field); + +    /* +     * Watch out porters; the inode is meant to be an *unsigned* value, so the +     * cast might fail when there isn't a real arithmetic 'long long' type... +     */ + +    STORE_ARY("dev",	Tcl_NewLongObj((long)statPtr->st_dev)); +    STORE_ARY("ino",	Tcl_NewWideIntObj((Tcl_WideInt)statPtr->st_ino)); +    STORE_ARY("nlink",	Tcl_NewLongObj((long)statPtr->st_nlink)); +    STORE_ARY("uid",	Tcl_NewLongObj((long)statPtr->st_uid)); +    STORE_ARY("gid",	Tcl_NewLongObj((long)statPtr->st_gid)); +    STORE_ARY("size",	Tcl_NewWideIntObj((Tcl_WideInt)statPtr->st_size)); +#ifdef HAVE_STRUCT_STAT_ST_BLOCKS +    STORE_ARY("blocks",	Tcl_NewWideIntObj((Tcl_WideInt)statPtr->st_blocks)); +#endif +#ifdef HAVE_STRUCT_STAT_ST_BLKSIZE +    STORE_ARY("blksize", Tcl_NewLongObj((long)statPtr->st_blksize)); +#endif +    STORE_ARY("atime",	Tcl_NewLongObj((long)statPtr->st_atime)); +    STORE_ARY("mtime",	Tcl_NewLongObj((long)statPtr->st_mtime)); +    STORE_ARY("ctime",	Tcl_NewLongObj((long)statPtr->st_ctime)); +    mode = (unsigned short) statPtr->st_mode; +    STORE_ARY("mode",	Tcl_NewIntObj(mode)); +    STORE_ARY("type",	Tcl_NewStringObj(GetTypeFromMode(mode), -1)); +#undef STORE_ARY +      return TCL_OK;  } @@ -1540,8 +2311,7 @@ StoreStatData(interp, varName, statPtr)   *   * GetTypeFromMode --   * - *	Given a mode word, returns a string identifying the type of a - *	file. + *	Given a mode word, returns a string identifying the type of a file.   *   * Results:   *	A static text string giving the file type from mode. @@ -1552,9 +2322,9 @@ StoreStatData(interp, varName, statPtr)   *----------------------------------------------------------------------   */ -static char * -GetTypeFromMode(mode) -    int mode; +static const char * +GetTypeFromMode( +    int mode)  {      if (S_ISREG(mode)) {  	return "file"; @@ -1583,96 +2353,227 @@ GetTypeFromMode(mode)   *   * Tcl_ForObjCmd --   * - *      This procedure is invoked to process the "for" Tcl command. - *      See the user documentation for details on what it does. + *	This procedure is invoked to process the "for" Tcl command. See the + *	user documentation for details on what it does.   * - *	With the bytecode compiler, this procedure is only called when - *	a command name is computed at runtime, and is "for" or the name - *	to which "for" was renamed: e.g., + *	With the bytecode compiler, this procedure is only called when a + *	command name is computed at runtime, and is "for" or the name to which + *	"for" was renamed: e.g.,   *	"set z for; $z {set i 0} {$i<100} {incr i} {puts $i}"   *   * Results: - *      A standard Tcl result. + *	A standard Tcl result.   *   * Side effects: - *      See the user documentation. + *	See the user documentation. + * + * Notes: + *	This command is split into a lot of pieces so that it can avoid doing + *	reentrant TEBC calls. This makes things rather hard to follow, but + *	here's the plan: + * + *	NR:	---------------_\ + *	Direct:	Tcl_ForObjCmd -> TclNRForObjCmd + *					| + *				ForSetupCallback + *					| + *	[while] ------------> TclNRForIterCallback <---------. + *					|		     | + *				 ForCondCallback	     | + *					|		     | + *				 ForNextCallback ------------| + *					|		     | + *			       ForPostNextCallback	     | + *					|____________________|   *   *----------------------------------------------------------------------   */ -        /* ARGSUSED */ +	/* ARGSUSED */  int -Tcl_ForObjCmd(dummy, interp, objc, objv) -    ClientData dummy;                   /* Not used. */ -    Tcl_Interp *interp;                 /* Current interpreter. */ -    int objc;                           /* Number of arguments. */ -    Tcl_Obj *CONST objv[];	/* Argument objects. */ +Tcl_ForObjCmd( +    ClientData dummy,		/* Not used. */ +    Tcl_Interp *interp,		/* Current interpreter. */ +    int objc,			/* Number of arguments. */ +    Tcl_Obj *const objv[])	/* Argument objects. */  { -    int result, value; +    return Tcl_NRCallObjProc(interp, TclNRForObjCmd, dummy, objc, objv); +} + +int +TclNRForObjCmd( +    ClientData dummy,		/* Not used. */ +    Tcl_Interp *interp,		/* Current interpreter. */ +    int objc,			/* Number of arguments. */ +    Tcl_Obj *const objv[])	/* Argument objects. */ +{ +    Interp *iPtr = (Interp *) interp; +    ForIterData *iterPtr;      if (objc != 5) { -        Tcl_WrongNumArgs(interp, 1, objv, "start test next command"); -        return TCL_ERROR; +	Tcl_WrongNumArgs(interp, 1, objv, "start test next command"); +	return TCL_ERROR;      } -    result = Tcl_EvalObjEx(interp, objv[1], 0); +    TclSmallAllocEx(interp, sizeof(ForIterData), iterPtr); +    iterPtr->cond = objv[2]; +    iterPtr->body = objv[4]; +    iterPtr->next = objv[3]; +    iterPtr->msg  = "\n    (\"for\" body line %d)"; +    iterPtr->word = 4; + +    TclNRAddCallback(interp, ForSetupCallback, iterPtr, NULL, NULL, NULL); + +    /* +     * TIP #280. Make invoking context available to initial script. +     */ + +    return TclNREvalObjEx(interp, objv[1], 0, iPtr->cmdFramePtr, 1); +} + +static int +ForSetupCallback( +    ClientData data[], +    Tcl_Interp *interp, +    int result) +{ +    ForIterData *iterPtr = data[0]; +      if (result != TCL_OK) { -        if (result == TCL_ERROR) { -            Tcl_AddErrorInfo(interp, "\n    (\"for\" initial command)"); -        } -        return result; +	if (result == TCL_ERROR) { +	    Tcl_AddErrorInfo(interp, "\n    (\"for\" initial command)"); +	} +	TclSmallFreeEx(interp, iterPtr); +	return result;      } -    while (1) { +    TclNRAddCallback(interp, TclNRForIterCallback, iterPtr, NULL, NULL, NULL); +    return TCL_OK; +} + +int +TclNRForIterCallback( +    ClientData data[], +    Tcl_Interp *interp, +    int result) +{ +    ForIterData *iterPtr = data[0]; +    Tcl_Obj *boolObj; + +    switch (result) { +    case TCL_OK: +    case TCL_CONTINUE:  	/* -	 * We need to reset the result before passing it off to -	 * Tcl_ExprBooleanObj.  Otherwise, any error message will be appended -	 * to the result of the last evaluation. +	 * We need to reset the result before evaluating the expression. +	 * Otherwise, any error message will be appended to the result of the +	 * last evaluation.  	 */  	Tcl_ResetResult(interp); -        result = Tcl_ExprBooleanObj(interp, objv[2], &value); -        if (result != TCL_OK) { -            return result; -        } -        if (!value) { -            break; -        } -        result = Tcl_EvalObjEx(interp, objv[4], 0); -        if ((result != TCL_OK) && (result != TCL_CONTINUE)) { -            if (result == TCL_ERROR) { -                char msg[32 + TCL_INTEGER_SPACE]; - -                sprintf(msg, "\n    (\"for\" body line %d)",interp->errorLine); -                Tcl_AddErrorInfo(interp, msg); -            } -            break; -        } -        result = Tcl_EvalObjEx(interp, objv[3], 0); -	if (result == TCL_BREAK) { -            break; -        } else if (result != TCL_OK) { -            if (result == TCL_ERROR) { -                Tcl_AddErrorInfo(interp, "\n    (\"for\" loop-end command)"); -            } -            return result; -        } -    } -    if (result == TCL_BREAK) { -        result = TCL_OK; +	TclNewObj(boolObj); +	TclNRAddCallback(interp, ForCondCallback, iterPtr, boolObj, NULL, +		NULL); +	return Tcl_NRExprObj(interp, iterPtr->cond, boolObj); +    case TCL_BREAK: +	result = TCL_OK; +	Tcl_ResetResult(interp); +	break; +    case TCL_ERROR: +	Tcl_AppendObjToErrorInfo(interp, +		Tcl_ObjPrintf(iterPtr->msg, Tcl_GetErrorLine(interp)));      } -    if (result == TCL_OK) { -        Tcl_ResetResult(interp); +    TclSmallFreeEx(interp, iterPtr); +    return result; +} + +static int +ForCondCallback( +    ClientData data[], +    Tcl_Interp *interp, +    int result) +{ +    Interp *iPtr = (Interp *) interp; +    ForIterData *iterPtr = data[0]; +    Tcl_Obj *boolObj = data[1]; +    int value; + +    if (result != TCL_OK) { +	Tcl_DecrRefCount(boolObj); +	TclSmallFreeEx(interp, iterPtr); +	return result; +    } else if (Tcl_GetBooleanFromObj(interp, boolObj, &value) != TCL_OK) { +	Tcl_DecrRefCount(boolObj); +	TclSmallFreeEx(interp, iterPtr); +	return TCL_ERROR; +    } +    Tcl_DecrRefCount(boolObj); + +    if (value) { +	/* TIP #280. */ +	if (iterPtr->next) { +	    TclNRAddCallback(interp, ForNextCallback, iterPtr, NULL, NULL, +		    NULL); +	} else { +	    TclNRAddCallback(interp, TclNRForIterCallback, iterPtr, NULL, +		    NULL, NULL); +	} +	return TclNREvalObjEx(interp, iterPtr->body, 0, iPtr->cmdFramePtr, +		iterPtr->word);      } +    TclSmallFreeEx(interp, iterPtr); +    return result; +} + +static int +ForNextCallback( +    ClientData data[], +    Tcl_Interp *interp, +    int result) +{ +    Interp *iPtr = (Interp *) interp; +    ForIterData *iterPtr = data[0]; +    Tcl_Obj *next = iterPtr->next; + +    if ((result == TCL_OK) || (result == TCL_CONTINUE)) { +	TclNRAddCallback(interp, ForPostNextCallback, iterPtr, NULL, NULL, +		NULL); + +	/* +	 * TIP #280. Make invoking context available to next script. +	 */ + +	return TclNREvalObjEx(interp, next, 0, iPtr->cmdFramePtr, 3); +    } + +    TclNRAddCallback(interp, TclNRForIterCallback, iterPtr, NULL, NULL, NULL); +    return result; +} + +static int +ForPostNextCallback( +    ClientData data[], +    Tcl_Interp *interp, +    int result) +{ +    ForIterData *iterPtr = data[0]; + +    if ((result != TCL_BREAK) && (result != TCL_OK)) { +	if (result == TCL_ERROR) { +	    Tcl_AddErrorInfo(interp, "\n    (\"for\" loop-end command)"); +	    TclSmallFreeEx(interp, iterPtr); +	} +	return result; +    } +    TclNRAddCallback(interp, TclNRForIterCallback, iterPtr, NULL, NULL, NULL);      return result;  }  /*   *----------------------------------------------------------------------   * - * Tcl_ForeachObjCmd -- + * Tcl_ForeachObjCmd, TclNRForeachCmd, EachloopCmd --   *   *	This object-based procedure is invoked to process the "foreach" Tcl - *	command.  See the user documentation for details on what it does. + *	command. See the user documentation for details on what it does.   *   * Results:   *	A standard Tcl object result. @@ -1685,42 +2586,57 @@ Tcl_ForObjCmd(dummy, interp, objc, objv)  	/* ARGSUSED */  int -Tcl_ForeachObjCmd(dummy, interp, objc, objv) -    ClientData dummy;		/* Not used. */ -    Tcl_Interp *interp;		/* Current interpreter. */ -    int objc;			/* Number of arguments. */ -    Tcl_Obj *CONST objv[];	/* Argument objects. */ -{ -    int result = TCL_OK; -    int i;			/* i selects a value list */ -    int j, maxj;		/* Number of loop iterations */ -    int v;			/* v selects a loop variable */ -    int numLists;		/* Count of value lists */ -    Tcl_Obj *bodyPtr; +Tcl_ForeachObjCmd( +    ClientData dummy,		/* Not used. */ +    Tcl_Interp *interp,		/* Current interpreter. */ +    int objc,			/* Number of arguments. */ +    Tcl_Obj *const objv[])	/* Argument objects. */ +{ +    return Tcl_NRCallObjProc(interp, TclNRForeachCmd, dummy, objc, objv); +} -    /* -     * We copy the argument object pointers into a local array to avoid -     * the problem that "objv" might become invalid. It is a pointer into -     * the evaluation stack and that stack might be grown and reallocated -     * if the loop body requires a large amount of stack space. -     */ -     -#define NUM_ARGS 9 -    Tcl_Obj *(argObjStorage[NUM_ARGS]); -    Tcl_Obj **argObjv = argObjStorage; -     -#define STATIC_LIST_SIZE 4 -    int indexArray[STATIC_LIST_SIZE];	  /* Array of value list indices */ -    int varcListArray[STATIC_LIST_SIZE];  /* # loop variables per list */ -    Tcl_Obj **varvListArray[STATIC_LIST_SIZE]; /* Array of var name lists */ -    int argcListArray[STATIC_LIST_SIZE];  /* Array of value list sizes */ -    Tcl_Obj **argvListArray[STATIC_LIST_SIZE]; /* Array of value lists */ - -    int *index = indexArray; -    int *varcList = varcListArray; -    Tcl_Obj ***varvList = varvListArray; -    int *argcList = argcListArray; -    Tcl_Obj ***argvList = argvListArray; +int +TclNRForeachCmd( +    ClientData dummy, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    return EachloopCmd(interp, TCL_EACH_KEEP_NONE, objc, objv); +} + +int +Tcl_LmapObjCmd( +    ClientData dummy,		/* Not used. */ +    Tcl_Interp *interp,		/* Current interpreter. */ +    int objc,			/* Number of arguments. */ +    Tcl_Obj *const objv[])	/* Argument objects. */ +{ +    return Tcl_NRCallObjProc(interp, TclNRLmapCmd, dummy, objc, objv); +} + +int +TclNRLmapCmd( +    ClientData dummy, +    Tcl_Interp *interp, +    int objc, +    Tcl_Obj *const objv[]) +{ +    return EachloopCmd(interp, TCL_EACH_COLLECT, objc, objv); +} + +static inline int +EachloopCmd( +    Tcl_Interp *interp,		/* Our context for variables and script +				 * evaluation. */ +    int collect,		/* Select collecting or accumulating mode +				 * (TCL_EACH_*) */ +    int objc,			/* The arguments being passed in... */ +    Tcl_Obj *const objv[]) +{ +    int numLists = (objc-2) / 2; +    register struct ForeachState *statePtr; +    int i, j, result;      if (objc < 4 || (objc%2 != 0)) {  	Tcl_WrongNumArgs(interp, 1, objv, @@ -1729,659 +2645,290 @@ Tcl_ForeachObjCmd(dummy, interp, objc, objv)      }      /* -     * Create the object argument array "argObjv". Make sure argObjv is -     * large enough to hold the objc arguments. -     */ - -    if (objc > NUM_ARGS) { -	argObjv = (Tcl_Obj **) ckalloc(objc * sizeof(Tcl_Obj *)); -    } -    for (i = 0;  i < objc;  i++) { -	argObjv[i] = objv[i]; -    } - -    /*       * Manage numList parallel value lists. -     * argvList[i] is a value list counted by argcList[i] -     * varvList[i] is the list of variables associated with the value list -     * varcList[i] is the number of variables associated with the value list -     * index[i] is the current pointer into the value list argvList[i] +     * statePtr->argvList[i] is a value list counted by statePtr->argcList[i]; +     * statePtr->varvList[i] is the list of variables associated with the +     *		value list; +     * statePtr->varcList[i] is the number of variables associated with the +     *		value list; +     * statePtr->index[i] is the current pointer into the value list +     *		statePtr->argvList[i]. +     * +     * The setting up of all of these pointers is moderately messy, but allows +     * the rest of this code to be simple and for us to use a single memory +     * allocation for better performance.       */ -    numLists = (objc-2)/2; -    if (numLists > STATIC_LIST_SIZE) { -	index = (int *) ckalloc(numLists * sizeof(int)); -	varcList = (int *) ckalloc(numLists * sizeof(int)); -	varvList = (Tcl_Obj ***) ckalloc(numLists * sizeof(Tcl_Obj **)); -	argcList = (int *) ckalloc(numLists * sizeof(int)); -	argvList = (Tcl_Obj ***) ckalloc(numLists * sizeof(Tcl_Obj **)); -    } -    for (i = 0;  i < numLists;  i++) { -	index[i] = 0; -	varcList[i] = 0; -	varvList[i] = (Tcl_Obj **) NULL; -	argcList[i] = 0; -	argvList[i] = (Tcl_Obj **) NULL; +    statePtr = TclStackAlloc(interp, +	    sizeof(struct ForeachState) + 3 * numLists * sizeof(int) +	    + 2 * numLists * (sizeof(Tcl_Obj **) + sizeof(Tcl_Obj *))); +    memset(statePtr, 0, +	    sizeof(struct ForeachState) + 3 * numLists * sizeof(int) +	    + 2 * numLists * (sizeof(Tcl_Obj **) + sizeof(Tcl_Obj *))); +    statePtr->varvList = (Tcl_Obj ***) (statePtr + 1); +    statePtr->argvList = statePtr->varvList + numLists; +    statePtr->vCopyList = (Tcl_Obj **) (statePtr->argvList + numLists); +    statePtr->aCopyList = statePtr->vCopyList + numLists; +    statePtr->index = (int *) (statePtr->aCopyList + numLists); +    statePtr->varcList = statePtr->index + numLists; +    statePtr->argcList = statePtr->varcList + numLists; + +    statePtr->numLists = numLists; +    statePtr->bodyPtr = objv[objc - 1]; +    statePtr->bodyIdx = objc - 1; + +    if (collect == TCL_EACH_COLLECT) { +	statePtr->resultList = Tcl_NewListObj(0, NULL); +    } else { +	statePtr->resultList = NULL;      }      /* -     * Break up the value lists and variable lists into elements +     * Break up the value lists and variable lists into elements.       */ -    maxj = 0; -    for (i = 0;  i < numLists;  i++) { -	result = Tcl_ListObjGetElements(interp, argObjv[1+i*2], -	        &varcList[i], &varvList[i]); -	if (result != TCL_OK) { +    for (i=0 ; i<numLists ; i++) { +	statePtr->vCopyList[i] = TclListObjCopy(interp, objv[1+i*2]); +	if (statePtr->vCopyList[i] == NULL) { +	    result = TCL_ERROR;  	    goto done;  	} -	if (varcList[i] < 1) { -	    Tcl_AppendToObj(Tcl_GetObjResult(interp), -	            "foreach varlist is empty", -1); +	TclListObjGetElements(NULL, statePtr->vCopyList[i], +		&statePtr->varcList[i], &statePtr->varvList[i]); +	if (statePtr->varcList[i] < 1) { +	    Tcl_SetObjResult(interp, Tcl_ObjPrintf( +		    "%s varlist is empty", +		    (statePtr->resultList != NULL ? "lmap" : "foreach"))); +	    Tcl_SetErrorCode(interp, "TCL", "OPERATION", +		    (statePtr->resultList != NULL ? "LMAP" : "FOREACH"), +		    "NEEDVARS", NULL);  	    result = TCL_ERROR;  	    goto done;  	} -	 -	result = Tcl_ListObjGetElements(interp, argObjv[2+i*2], -	        &argcList[i], &argvList[i]); -	if (result != TCL_OK) { + +	statePtr->aCopyList[i] = TclListObjCopy(interp, objv[2+i*2]); +	if (statePtr->aCopyList[i] == NULL) { +	    result = TCL_ERROR;  	    goto done;  	} -	 -	j = argcList[i] / varcList[i]; -	if ((argcList[i] % varcList[i]) != 0) { +	TclListObjGetElements(NULL, statePtr->aCopyList[i], +		&statePtr->argcList[i], &statePtr->argvList[i]); + +	j = statePtr->argcList[i] / statePtr->varcList[i]; +	if ((statePtr->argcList[i] % statePtr->varcList[i]) != 0) {  	    j++;  	} -	if (j > maxj) { -	    maxj = j; +	if (j > statePtr->maxj) { +	    statePtr->maxj = j;  	}      }      /* -     * Iterate maxj times through the lists in parallel -     * If some value lists run out of values, set loop vars to "" +     * If there is any work to do, assign the variables and set things going +     * non-recursively.       */ -     -    bodyPtr = argObjv[objc-1]; -    for (j = 0;  j < maxj;  j++) { -	for (i = 0;  i < numLists;  i++) { -	    /* -	     * If a variable or value list object has been converted to -	     * another kind of Tcl object, convert it back to a list object -	     * and refetch the pointer to its element array. -	     */ -	    if (argObjv[1+i*2]->typePtr != &tclListType) { -		result = Tcl_ListObjGetElements(interp, argObjv[1+i*2], -		        &varcList[i], &varvList[i]); -		if (result != TCL_OK) { -		    panic("Tcl_ForeachObjCmd: could not reconvert variable list %d to a list object\n", i); -		} -	    } -	    if (argObjv[2+i*2]->typePtr != &tclListType) { -		result = Tcl_ListObjGetElements(interp, argObjv[2+i*2], -	                &argcList[i], &argvList[i]); -		if (result != TCL_OK) { -		    panic("Tcl_ForeachObjCmd: could not reconvert value list %d to a list object\n", i); -		} -	    } -	     -	    for (v = 0;  v < varcList[i];  v++) { -		int k = index[i]++; -		Tcl_Obj *valuePtr, *varValuePtr; -		int isEmptyObj = 0; -		 -		if (k < argcList[i]) { -		    valuePtr = argvList[i][k]; -		} else { -		    valuePtr = Tcl_NewObj(); /* empty string */ -		    isEmptyObj = 1; -		} -		varValuePtr = Tcl_ObjSetVar2(interp, varvList[i][v], -			NULL, valuePtr, 0); -		if (varValuePtr == NULL) { -		    if (isEmptyObj) { -			Tcl_DecrRefCount(valuePtr); -		    } -		    Tcl_ResetResult(interp); -		    Tcl_AppendStringsToObj(Tcl_GetObjResult(interp), -			"couldn't set loop variable: \"", -			Tcl_GetString(varvList[i][v]), "\"", (char *) NULL); -		    result = TCL_ERROR; -		    goto done; -		} - -	    } +    if (statePtr->maxj > 0) { +	result = ForeachAssignments(interp, statePtr); +	if (result == TCL_ERROR) { +	    goto done;  	} -	result = Tcl_EvalObjEx(interp, bodyPtr, 0); -	if (result != TCL_OK) { -	    if (result == TCL_CONTINUE) { -		result = TCL_OK; -	    } else if (result == TCL_BREAK) { -		result = TCL_OK; -		break; -	    } else if (result == TCL_ERROR) { -                char msg[32 + TCL_INTEGER_SPACE]; - -		sprintf(msg, "\n    (\"foreach\" body line %d)", -			interp->errorLine); -		Tcl_AddObjErrorInfo(interp, msg, -1); -		break; -	    } else { -		break; -	    } -	} -    } -    if (result == TCL_OK) { -	Tcl_ResetResult(interp); +	TclNRAddCallback(interp, ForeachLoopStep, statePtr, NULL, NULL, NULL); +	return TclNREvalObjEx(interp, objv[objc-1], 0, +		((Interp *) interp)->cmdFramePtr, objc-1);      } -    done: -    if (numLists > STATIC_LIST_SIZE) { -	ckfree((char *) index); -	ckfree((char *) varcList); -	ckfree((char *) argcList); -	ckfree((char *) varvList); -	ckfree((char *) argvList); -    } -    if (argObjv != argObjStorage) { -	ckfree((char *) argObjv); -    } +    /* +     * This cleanup stage is only used when an error occurs during setup or if +     * there is no work to do. +     */ + +    result = TCL_OK; +  done: +    ForeachCleanup(interp, statePtr);      return result; -#undef STATIC_LIST_SIZE -#undef NUM_ARGS  } - +  /* - *---------------------------------------------------------------------- - * - * Tcl_FormatObjCmd -- - * - *	This procedure is invoked to process the "format" Tcl command. - *	See the user documentation for details on what it does. - * - * Results: - *	A standard Tcl result. - * - * Side effects: - *	See the user documentation. - * - *---------------------------------------------------------------------- + * Post-body processing handler.   */ -	/* ARGSUSED */ -int -Tcl_FormatObjCmd(dummy, interp, objc, objv) -    ClientData dummy;    	/* Not used. */ -    Tcl_Interp *interp;		/* Current interpreter. */ -    int objc;			/* Number of arguments. */ -    Tcl_Obj *CONST objv[];	/* Argument objects. */ -{ -    char *format;		/* Used to read characters from the format -				 * string. */ -    int formatLen;              /* The length of the format string */ -    char *endPtr;		/* Points to the last char in format array */ -    char newFormat[40];		/* A new format specifier is generated here. */ -    int width;			/* Field width from field specifier, or 0 if -				 * no width given. */ -    int precision;		/* Field precision from field specifier, or 0 -				 * if no precision given. */ -    int size;			/* Number of bytes needed for result of -				 * conversion, based on type of conversion -				 * ("e", "s", etc.), width, and precision. */ -    int intValue;		/* Used to hold value to pass to sprintf, if -				 * it's a one-word integer or char value */ -    char *ptrValue = NULL;	/* Used to hold value to pass to sprintf, if -				 * it's a one-word value. */ -    double doubleValue;		/* Used to hold value to pass to sprintf if -				 * it's a double value. */ -    int whichValue;		/* Indicates which of intValue, ptrValue, -				 * or doubleValue has the value to pass to -				 * sprintf, according to the following -				 * definitions: */ -#   define INT_VALUE 0 -#   define CHAR_VALUE 1 -#   define PTR_VALUE 2 -#   define DOUBLE_VALUE 3 -#   define STRING_VALUE 4 -#   define MAX_FLOAT_SIZE 320 -     -    Tcl_Obj *resultPtr;  	/* Where result is stored finally. */ -    char staticBuf[MAX_FLOAT_SIZE + 1]; -                                /* A static buffer to copy the format results  -				 * into */ -    char *dst = staticBuf;      /* The buffer that sprintf writes into each -				 * time the format processes a specifier */ -    int dstSize = MAX_FLOAT_SIZE; -                                /* The size of the dst buffer */ -    int noPercent;		/* Special case for speed:  indicates there's -				 * no field specifier, just a string to copy.*/ -    int objIndex;		/* Index of argument to substitute next. */ -    int gotXpg = 0;		/* Non-zero means that an XPG3 %n$-style -				 * specifier has been seen. */ -    int gotSequential = 0;	/* Non-zero means that a regular sequential -				 * (non-XPG3) conversion specifier has been -				 * seen. */ -    int useShort;		/* Value to be printed is short (half word). */ -    char *end;			/* Used to locate end of numerical fields. */ -    int stringLen = 0;		/* Length of string in characters rather -				 * than bytes.  Used for %s substitution. */ -    int gotMinus;		/* Non-zero indicates that a minus flag has -				 * been seen in the current field. */ -    int gotPrecision;		/* Non-zero indicates that a precision has -				 * been set for the current field. */ -    int gotZero;		/* Non-zero indicates that a zero flag has -				 * been seen in the current field. */ +static int +ForeachLoopStep( +    ClientData data[], +    Tcl_Interp *interp, +    int result) +{ +    register struct ForeachState *statePtr = data[0];      /* -     * This procedure is a bit nasty.  The goal is to use sprintf to -     * do most of the dirty work.  There are several problems: -     * 1. this procedure can't trust its arguments. -     * 2. we must be able to provide a large enough result area to hold -     *    whatever's generated.  This is hard to estimate. -     * 3. there's no way to move the arguments from objv to the call -     *    to sprintf in a reasonable way.  This is particularly nasty -     *    because some of the arguments may be two-word values (doubles). -     * So, what happens here is to scan the format string one % group -     * at a time, making many individual calls to sprintf. +     * Process the result code from this run of the [foreach] body. Note that +     * this switch uses fallthroughs in several places. Maintainer aware!       */ -    if (objc < 2) { -        Tcl_WrongNumArgs(interp, 1, objv, "formatString ?arg arg ...?"); -	return TCL_ERROR; +    switch (result) { +    case TCL_CONTINUE: +	result = TCL_OK; +	break; +    case TCL_OK: +	if (statePtr->resultList != NULL) { +	    Tcl_ListObjAppendElement(interp, statePtr->resultList, +		    Tcl_GetObjResult(interp)); +	} +	break; +    case TCL_BREAK: +	result = TCL_OK; +	goto finish; +    case TCL_ERROR: +	Tcl_AppendObjToErrorInfo(interp, Tcl_ObjPrintf( +		"\n    (\"%s\" body line %d)", +		(statePtr->resultList != NULL ? "lmap" : "foreach"), +		Tcl_GetErrorLine(interp))); +    default: +	goto done;      } -    format = (char *) Tcl_GetStringFromObj(objv[1], &formatLen); -    endPtr = format + formatLen; -    resultPtr = Tcl_NewObj(); -    objIndex = 2; - -    while (format < endPtr) { -	register char *newPtr = newFormat; - -	width = precision = noPercent = useShort = 0; -	gotZero = gotMinus = gotPrecision = 0; -	whichValue = PTR_VALUE; +    /* +     * Test if there is work still to be done. If so, do the next round of +     * variable assignments, reschedule ourselves and run the body again. +     */ -	/* -	 * Get rid of any characters before the next field specifier. -	 */ -	if (*format != '%') { -	    ptrValue = format; -	    while ((*format != '%') && (format < endPtr)) { -		format++; -	    } -	    size = format - ptrValue; -	    noPercent = 1; -	    goto doField; +    if (statePtr->maxj > ++statePtr->j) { +	result = ForeachAssignments(interp, statePtr); +	if (result == TCL_ERROR) { +	    goto done;  	} -	if (format[1] == '%') { -	    ptrValue = format; -	    size = 1; -	    noPercent = 1; -	    format += 2; -	    goto doField; -	} +	TclNRAddCallback(interp, ForeachLoopStep, statePtr, NULL, NULL, NULL); +	return TclNREvalObjEx(interp, statePtr->bodyPtr, 0, +		((Interp *) interp)->cmdFramePtr, statePtr->bodyIdx); +    } -	/* -	 * Parse off a field specifier, compute how many characters -	 * will be needed to store the result, and substitute for -	 * "*" size specifiers. -	 */ -	*newPtr = '%'; -	newPtr++; -	format++; -	if (isdigit(UCHAR(*format))) { /* INTL: Tcl source. */ -	    int tmp; +    /* +     * We're done. Tidy up our work space and finish off. +     */ -	    /* -	     * Check for an XPG3-style %n$ specification.  Note: there -	     * must not be a mixture of XPG3 specs and non-XPG3 specs -	     * in the same format string. -	     */ +  finish: +    if (statePtr->resultList == NULL) { +	Tcl_ResetResult(interp); +    } else { +	Tcl_SetObjResult(interp, statePtr->resultList); +	statePtr->resultList = NULL;	/* Don't clean it up */ +    } -	    tmp = strtoul(format, &end, 10);	/* INTL: "C" locale. */ -	    if (*end != '$') { -		goto notXpg; -	    } -	    format = end+1; -	    gotXpg = 1; -	    if (gotSequential) { -		goto mixedXPG; -	    } -	    objIndex = tmp+1; -	    if ((objIndex < 2) || (objIndex >= objc)) { -		goto badIndex; -	    } -	    goto xpgCheckDone; -	} +  done: +    ForeachCleanup(interp, statePtr); +    return result; +} -	notXpg: -	gotSequential = 1; -	if (gotXpg) { -	    goto mixedXPG; -	} +/* + * Factored out code to do the assignments in [foreach]. + */ -	xpgCheckDone: -	while ((*format == '-') || (*format == '#') || (*format == '0') -		|| (*format == ' ') || (*format == '+')) { -	    if (*format == '-') { -		gotMinus = 1; -	    } -	    if (*format == '0') { -		/* -		 * This will be handled by sprintf for numbers, but we -		 * need to do the char/string ones ourselves -		 */ -		gotZero = 1; -	    } -	    *newPtr = *format; -	    newPtr++; -	    format++; -	} -	if (isdigit(UCHAR(*format))) { /* INTL: Tcl source. */ -	    width = strtoul(format, &end, 10);	/* INTL: Tcl source. */ -	    format = end; -	} else if (*format == '*') { -	    if (objIndex >= objc) { -		goto badIndex; -	    } -	    if (Tcl_GetIntFromObj(interp,	/* INTL: Tcl source. */ -		    objv[objIndex], &width) != TCL_OK) { -		goto fmtError; -	    } -	    if (width < 0) { -		width = -width; -		*newPtr = '-'; -		gotMinus = 1; -		newPtr++; -	    } -	    objIndex++; -	    format++; -	} -	if (width > 100000) { -	    /* -	     * Don't allow arbitrarily large widths:  could cause core -	     * dump when we try to allocate a zillion bytes of memory -	     * below. -	     */ +static inline int +ForeachAssignments( +    Tcl_Interp *interp, +    struct ForeachState *statePtr) +{ +    int i, v, k; +    Tcl_Obj *valuePtr, *varValuePtr; -	    width = 100000; -	} else if (width < 0) { -	    width = 0; -	} -	if (width != 0) { -	    TclFormatInt(newPtr, width);	/* INTL: printf format. */ -	    while (*newPtr != 0) { -		newPtr++; -	    } -	} -	if (*format == '.') { -	    *newPtr = '.'; -	    newPtr++; -	    format++; -	    gotPrecision = 1; -	} -	if (isdigit(UCHAR(*format))) { /* INTL: Tcl source. */ -	    precision = strtoul(format, &end, 10);  /* INTL: "C" locale. */ -	    format = end; -	} else if (*format == '*') { -	    if (objIndex >= objc) { -		goto badIndex; -	    } -	    if (Tcl_GetIntFromObj(interp,	/* INTL: Tcl source. */ -		    objv[objIndex], &precision) != TCL_OK) { -		goto fmtError; -	    } -	    objIndex++; -	    format++; -	} -	if (gotPrecision) { -	    TclFormatInt(newPtr, precision);	/* INTL: printf format. */ -	    while (*newPtr != 0) { -		newPtr++; -	    } -	} -	if (*format == 'l') { -	    format++; -	} else if (*format == 'h') { -	    useShort = 1; -	    *newPtr = 'h'; -	    newPtr++; -	    format++; -	} -	*newPtr = *format; -	newPtr++; -	*newPtr = 0; -	if (objIndex >= objc) { -	    goto badIndex; -	} -	switch (*format) { -	    case 'i': -		newPtr[-1] = 'd'; -	    case 'd': -	    case 'o': -	    case 'u': -	    case 'x': -	    case 'X': -		if (Tcl_GetIntFromObj(interp,	/* INTL: Tcl source. */ -			objv[objIndex], &intValue) != TCL_OK) { -		    goto fmtError; -		} -		whichValue = INT_VALUE; -		size = 40 + precision; -		break; -	    case 's': -		/* -		 * Compute the length of the string in characters and add -		 * any additional space required by the field width.  All of -		 * the extra characters will be spaces, so one byte per -		 * character is adequate. -		 */ - -		whichValue = STRING_VALUE; -		ptrValue = Tcl_GetStringFromObj(objv[objIndex], &size); -		stringLen = Tcl_NumUtfChars(ptrValue, size); -		if (gotPrecision && (precision < stringLen)) { -		    stringLen = precision; -		} -		size = Tcl_UtfAtIndex(ptrValue, stringLen) - ptrValue; -		if (width > stringLen) { -		    size += (width - stringLen); -		} -		break; -	    case 'c': -		if (Tcl_GetIntFromObj(interp,	/* INTL: Tcl source. */ -			objv[objIndex], &intValue) != TCL_OK) { -		    goto fmtError; -		} -		whichValue = CHAR_VALUE; -		size = width + TCL_UTF_MAX; -		break; -	    case 'e': -	    case 'E': -	    case 'f': -	    case 'g': -	    case 'G': -		if (Tcl_GetDoubleFromObj(interp, /* INTL: Tcl source. */ -			objv[objIndex], &doubleValue) != TCL_OK) { -		    goto fmtError; -		} -		whichValue = DOUBLE_VALUE; -		size = MAX_FLOAT_SIZE; -		if (precision > 10) { -		    size += precision; -		} -		break; -	    case 0: -		Tcl_SetResult(interp, -		        "format string ended in middle of field specifier", -			TCL_STATIC); -		goto fmtError; -	    default: { -		char buf[40]; -		sprintf(buf, "bad field specifier \"%c\"", *format); -		Tcl_SetResult(interp, buf, TCL_VOLATILE); -		goto fmtError; +    for (i=0 ; i<statePtr->numLists ; i++) { +	for (v=0 ; v<statePtr->varcList[i] ; v++) { +	    k = statePtr->index[i]++; + +	    if (k < statePtr->argcList[i]) { +		valuePtr = statePtr->argvList[i][k]; +	    } else { +		TclNewObj(valuePtr);	/* Empty string */  	    } -	} -	objIndex++; -	format++; -	/* -	 * Make sure that there's enough space to hold the formatted -	 * result, then format it. -	 */ +	    varValuePtr = Tcl_ObjSetVar2(interp, statePtr->varvList[i][v], +		    NULL, valuePtr, TCL_LEAVE_ERR_MSG); -	doField: -	if (width > size) { -	    size = width; -	} -	if (noPercent) { -	    Tcl_AppendToObj(resultPtr, ptrValue, size); -	} else { -	    if (size > dstSize) { -	        if (dst != staticBuf) { -		    ckfree(dst); -		} -		dst = (char *) ckalloc((unsigned) (size + 1)); -		dstSize = size; -	    } -	    switch (whichValue) { -		case DOUBLE_VALUE: { -		    sprintf(dst, newFormat, doubleValue); /* INTL: user locale. */ -		    break; -		} -		case INT_VALUE: { -		    if (useShort) { -			sprintf(dst, newFormat, (short) intValue); -		    } else { -			sprintf(dst, newFormat, intValue); -		    } -		    break; -		} -		case CHAR_VALUE: { -		    char *ptr; -		    char padChar = (gotZero ? '0' : ' '); -		    ptr = dst; -		    if (!gotMinus) { -			for ( ; --width > 0; ptr++) { -			    *ptr = padChar; -			} -		    } -		    ptr += Tcl_UniCharToUtf(intValue, ptr); -		    for ( ; --width > 0; ptr++) { -			*ptr = padChar; -		    } -		    *ptr = '\0'; -		    break; -		} -		case STRING_VALUE: { -		    char *ptr; -		    char padChar = (gotZero ? '0' : ' '); -		    int pad; - -		    ptr = dst; -		    if (width > stringLen) { -			pad = width - stringLen; -		    } else { -			pad = 0; -		    } - -		    if (!gotMinus) { -			while (pad > 0) { -			    *ptr++ = padChar; -			    pad--; -			} -		    } - -		    size = Tcl_UtfAtIndex(ptrValue, stringLen) - ptrValue;  -		    if (size) { -			memcpy(ptr, ptrValue, (size_t) size); -			ptr += size; -		    } -		    while (pad > 0) { -			*ptr++ = padChar; -			pad--; -		    } -		    *ptr = '\0'; -		    break; -		} -		default: { -		    sprintf(dst, newFormat, ptrValue); -		    break; -		} +	    if (varValuePtr == NULL) { +		Tcl_AppendObjToErrorInfo(interp, Tcl_ObjPrintf( +			"\n    (setting %s loop variable \"%s\")", +			(statePtr->resultList != NULL ? "lmap" : "foreach"), +			TclGetString(statePtr->varvList[i][v]))); +		return TCL_ERROR;  	    } -	    Tcl_AppendToObj(resultPtr, dst, -1);  	}      } -    Tcl_SetObjResult(interp, resultPtr); -    if(dst != staticBuf) { -        ckfree(dst); -    }      return TCL_OK; +} -    mixedXPG: -    Tcl_SetResult(interp,  -            "cannot mix \"%\" and \"%n$\" conversion specifiers", TCL_STATIC); -    goto fmtError; +/* + * Factored out code for cleaning up the state of the foreach. + */ -    badIndex: -    if (gotXpg) { -        Tcl_SetResult(interp,  -                "\"%n$\" argument index out of range", TCL_STATIC); -    } else { -        Tcl_SetResult(interp,  -                "not enough arguments for all format specifiers", TCL_STATIC); -    } +static inline void +ForeachCleanup( +    Tcl_Interp *interp, +    struct ForeachState *statePtr) +{ +    int i; -    fmtError: -    if(dst != staticBuf) { -        ckfree(dst); +    for (i=0 ; i<statePtr->numLists ; i++) { +	if (statePtr->vCopyList[i]) { +	    TclDecrRefCount(statePtr->vCopyList[i]); +	} +	if (statePtr->aCopyList[i]) { +	    TclDecrRefCount(statePtr->aCopyList[i]); +	}      } -    Tcl_DecrRefCount(resultPtr); -    return TCL_ERROR; +    if (statePtr->resultList != NULL) { +	TclDecrRefCount(statePtr->resultList); +    } +    TclStackFree(interp, statePtr);  }  /* - *--------------------------------------------------------------------------- + *----------------------------------------------------------------------   * - * StringifyObjects -- + * Tcl_FormatObjCmd --   * - *	Helper function to bridge the gap between an object-based procedure - *	and an older string-based procedure. - *  - *	Given an array of objects, allocate an array that consists of the - *	string representations of those objects. + *	This procedure is invoked to process the "format" Tcl command. See + *	the user documentation for details on what it does.   *   * Results: - *	The return value is a pointer to the newly allocated array of - *	strings.  Elements 0 to (objc-1) of the string array point to the - *	string representation of the corresponding element in the source - *	object array; element objc of the string array is NULL. + *	A standard Tcl result.   *   * Side effects: - *	Memory allocated.  The caller must eventually free this memory - *	by calling ckfree() on the return value. + *	See the user documentation.   * - *--------------------------------------------------------------------------- + *----------------------------------------------------------------------   */ -static char ** -StringifyObjects(objc, objv) -    int objc;			/* Number of arguments. */ -    Tcl_Obj *CONST objv[];	/* Argument objects. */ +	/* ARGSUSED */ +int +Tcl_FormatObjCmd( +    ClientData dummy,		/* Not used. */ +    Tcl_Interp *interp,		/* Current interpreter. */ +    int objc,			/* Number of arguments. */ +    Tcl_Obj *const objv[])	/* Argument objects. */  { -    int i; -    char **argv; -     -    argv = (char **) ckalloc((objc + 1) * sizeof(char *)); -    for (i = 0; i < objc; i++) { -    	argv[i] = Tcl_GetString(objv[i]); +    Tcl_Obj *resultPtr;		/* Where result is stored finally. */ + +    if (objc < 2) { +	Tcl_WrongNumArgs(interp, 1, objv, "formatString ?arg ...?"); +	return TCL_ERROR;      } -    argv[i] = NULL; -    return argv; + +    resultPtr = Tcl_Format(interp, TclGetString(objv[1]), objc-2, objv+2); +    if (resultPtr == NULL) { +	return TCL_ERROR; +    } +    Tcl_SetObjResult(interp, resultPtr); +    return TCL_OK;  } + +/* + * Local Variables: + * mode: c + * c-basic-offset: 4 + * fill-column: 78 + * End: + */ | 
