summaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* * generic/tclStringObj.c: Rewrite GrowStringBuffer() so that itdgp2009-02-182-16/+30
| | | | | | | | has parallel structure with GrowUnicodeBuffer(). The revision permits allocation attempts to continue all the way up to failure, with no gap. It also directly manipulates the String and Tcl_Obj internals instead of inefficiently operating via Tcl_*SetObjLength() with all of its extra protections and underdocumented special cases.
* * generic/tclStringObj.c: Another round of simplification ondgp2009-02-181-21/+21
| | | | the allocation macros.
* * generic/tclStringObj.c: Another round of simplification ondgp2009-02-182-29/+30
| | | | the allocation macros.
* * generic/tclStringObj.c: Pare back the length of the unicodedgp2009-02-172-12/+17
| | | | | | | | array in a non-extended String struct to one Tcl_UniChar, meant to hold the terminating NUL character. Non-empty unicode strings are then stored by extending the String struct by stringPtr->maxChars additional slots in that array with sizeof(Tcl_UniChar) bytes per slot. This revision makes the allocation macros much simpler.
* * generic/tclStringObj.c: Factor out common GrowUnicodeBuffer()dgp2009-02-172-44/+54
| | | | and solve overflow and growth algorithm fallbacks in it.
* * win/tcl.m4, win/configure: Check if cl groks _WIN64 already tohobbs2009-02-173-6/+189
| | | | | avoid CC manipulation that can screw up later configure checks. Use 'd'ebug runtime in 64-bit builds.
* * generic/tclStringObj.c: Factor out common GrowStringBuffer().dgp2009-02-173-152/+60
| | | | | | | | | | | * generic/tclStringObj.c: Convert Tcl_AppendStringsToObj into * tests/stringObj.test: a radically simpler implementation where we just loop over calls to Tcl_AppendToObj. This fixes [Bug 2597185]. It also creates a *** POTENTIAL INCOMPATIBILITY *** in that T_ASTO can now allocate more space than is strictly required, like all the other Tcl_Append* routines. The incompatibility was detected by test stringObj-6.5, which I've updated to reflect the new behavior.
* * generic/tclStringObj.c: Revise buffer growth implementationdgp2009-02-172-21/+46
| | | | | | | in ExtendStringRepWithUnicode. Use cheap checks to determine that no reallocation is necessary without cost of computing the precise number of bytes needed. Also make use of the string growth algortihm in the case of repeated appends.
* fix [Feature Request 2605263] use officialnijtmans2009-02-161-0/+2
| | | | zlib build.
* fix [Feature Request 2605263] use officialnijtmans2009-02-167-39/+156
| | | | zlib build.
* fix [Bug 2605232] tdbc doesn't build whennijtmans2009-02-162-2/+7
| | | | Tcl is compiled with --disable-shared.
* * generic/tclTestObj.c: Replace the [teststringobj ualloc] testingdgp2009-02-163-8/+11
| | | | | * tests/stringObj.test: command with [teststringobj maxchars] and update the tests.
* * generic/tclStringObj.c: Added protections from invalid memorydgp2009-02-164-7/+139
| | | | | | | * generic/tclTestObj.c: accesses when we append (some part of) * tests/stringObj.test: a Tcl_Obj to itself. Added the appendself and appendself2 subcommands to the [teststringobj] testing command and added tests to the test suite. [Bug 2603158]
* * generic/tclStringObj.c: Factor out duplicate code fromdgp2009-02-152-12/+7
| | | | Tcl_AppendObjToObj.
* * generic/tclStringObj.c: Replace the 'size_t uallocated' fielddgp2009-02-152-46/+49
| | | | | | | | of the String struct, storing the number of bytes allocated to store the Tcl_UniChar array, with an 'int maxChars' field, storing the number of Tcl_UniChars that may be stored in the allocated space. This reduces memory requirement a small bit, and makes some range checks simpler to code.
* * generic/tclStringObj.c: Removed limitation indgp2009-02-152-12/+16
| | | | | | | | Tcl_AppendObjToObj where the char length of the result was only computed if the appended string was all single byte characters. This limitation was in place to dodge a bug in Tcl_GetUniChar. With that bug gone, we can take advantage of always recording the length of append results when we know it.
* * generic/tclStringObj.c: Revisions so that we avoid creatingdgp2009-02-142-51/+84
| | | | | | | | | | | | the strange representation of an empty string with objPtr->bytes == NULL and stringPtr->hasUnicode == 0. Instead in the situations where that was being created, create a traditional two-legged stork representation (objPtr->bytes = tclEmptyStringRep and stringPtr->hasUnicode = 1). In the situations where the strange rep was treated differently, continue to do so by testing stringPtr->numChars == 0 to detect it. These changes make the code more conventional so easier for new maintainers to pick up. Also sets up further simplifications.
* * generic/tclTestObj.c: Revise updates to [teststringobj] so we don'tdgp2009-02-142-7/+10
| | | | get blocked by MODULE_SCOPE limits.
* Const correctness fixes in the debug build.dgp2009-02-141-5/+5
|
* Remove all "register" keywords.dgp2009-02-131-20/+20
|
* New utility routine UnicodeLength(), to compute the length of unicodedgp2009-02-132-23/+24
| | | | | buffer arguments when no length is passed in, with built-in overflow protection included. Update three callers to use it.
* * generic/tclStringObj.c: Rewrites of the routinesdgp2009-02-133-153/+134
| | | | | | | | | | | Tcl_GetCharLength, Tcl_GetUniChar, Tcl_GetUnicodeFromObj, Tcl_GetRange, and TclStringObjReverse to use the new macro, and to more simply and clearly split the cases depending on whether a valid unicode rep is present or needs to be created. * generic/tclInt.h: New macro TclNumUtfChars meant to be a faster replacement for a full Tcl_NumUtfChars() call when the string has all single-byte characters.
* * generic/tclStringObj.c: Simplified Tcl_GetCharLength bydgp2009-02-123-25/+37
| | | | | | * generic/tclTestObj.c: removing code that did nothing. Added early returns from Tcl_*SetObjLength when the desired length is already present; adapted test command to the change.
* * generic/tclStringObj.c: Re-implemented AppendUtfToUnicodeRepdgp2009-02-122-32/+56
| | | | | | so that we no longer pass through Tcl_DStrings which have their own sets of problems when lengths overflow the int range. Now AUTUR and FillUnicodeRep share a common core routine.
* Fix tricky point that meant it was next to impossible to extend [oo::define].dkf2009-02-123-5/+31
|
* Revise latest commit to better maintain stringPtr->numChars.dgp2009-02-121-8/+12
|
* * generic/tclStringObj.c: Re-implemented AppendUnicodeToUtfRepdgp2009-02-122-54/+84
| | | | | | so that we no longer pass through Tcl_DStrings which have their own sets of problems when lengths overflow the int range. Now AUTUR and UpdateStringOfString share a common core routine.
* Removed casts now unnecessary after type of stringPtr->allocated changed.dgp2009-02-111-5/+5
|
* * generic/tclStringObj.c: Changed type of the 'allocated' fielddgp2009-02-112-4/+5
| | | | | | * generic/tclTestObj.c: of the String struct (and the TestString counterpart) from size_t to int since only int values are ever stored in it.
* * generic/tclStringObj.c: Changed type of the 'allocated' fielddgp2009-02-113-3/+10
| | | | | of the String struct from size_t to int since only int values are ever stored in it.
* - eliminate some unnessary type castsnijtmans2009-02-1013-167/+133
| | | | | - some internal const decorations - spacing
* - eliminate some unnessary type castsnijtmans2009-02-1019-110/+134
| | | | | - some internal const decorations - spacing
* fix [tcl-Bug 2502365] Building of head on HPUX isnijtmans2009-02-103-10/+22
| | | | broken when using the native CC.
* Removed handling of (objPtr->bytes != NULL) from UpdateStringOfString,dgp2009-02-102-3/+3
| | | | which is only called when objPtr->bytes is NULL.
* Simplify Tcl_SetObjLength by removing unreachable code.dgp2009-02-102-10/+4
|
* Simplify SetStringFromAny() by removing unreachable and duplicate code.dgp2009-02-102-25/+14
|
* * generic/tclObj.c (Tcl_GetString): Added comments and validitydgp2009-02-103-12/+26
| | | | | | checks following the call to an UpdateStringProc. Simplify Tcl_AttemptSetObjLength by removing unreachable code.
* Convert all Tcl_InvalidateStringRep() calls into macros.dgp2009-02-102-7/+8
|
* * generic/tclStringObj.c: Reduce code duplication in Tcl_GetUnicode*.dgp2009-02-102-6/+5
| | | | Restrict AppendUtfToUtfRep to non-negative length appends.
* * generic/tclStringObj.c (Tcl_GetUnicode*): Reduce code duplication.dgp2009-02-102-25/+6
|
* formattingdgp2009-02-101-3/+4
|
* fix [Bug 2555129] const compilernijtmans2009-02-092-3/+7
| | | | warning (as error) in tclCompile.c
* Improve error messages. [Bug 2573172]dkf2009-02-072-181/+205
|
* Fix for [Bug 2544618]Joe Mistachkin2009-02-063-19/+26
|
* Simplify the implementation of some commands now that the underlying stringdkf2009-02-052-101/+65
| | | | API knows more about bytearrays.
* Add missing castdkf2009-02-051-2/+2
|
* Fix [Bug 2568434]dkf2009-02-053-40/+39
|
* More/better/cleaner handling of the bytearray special casing for string ops.dkf2009-02-052-17/+87
|
* Improve efficiency of Tcl_AppendObjToObj's bytearray handling.dkf2009-02-052-1/+37
|
* comment typodgp2009-02-041-2/+2
|