| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
to determine lexemes with single-byte representations.
|
|
|
|
|
| |
* generic/tclCompExpr.c: the fields of the OpCmdInfo and
* generic/tclCompile.h: TclOpCmdClientData structs.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
expression syntax errors are found when compiling expressions. With
this in place, convert TclCompileExpr to return void, since there's no
longer any need to report TCL_ERROR.
* generic/tclCompile.c: Update callers.
* generic/tclExecute.c:
* generic/tclCompCmds.c: New routine TclCompileSyntaxError()
* generic/tclCompile.h: to directly compile bytecodes that report a
* generic/tclCompile.c: syntax error, rather than (ab)use a call to
TclCompileReturnCmd. Also, undo the most recent commit that papered
over some issues with that (ab)use. New routine produces a new
opcode INST_SYNTAX, which is a minor variation of INST_RETURN_IMM.
Also a bit of constification.
|
|
|
|
|
| |
* generic/tclCompExpr.c: entries into TclFreeCompileEnv().
* generic/tclExecute.c: Update callers.
|
|
|
|
|
| |
in expressions to register with their intreps intact, even if that
means overwriting existing intreps in already registered literals.
|
|
|
|
|
|
| |
* tests/compExpr.test: to restore literal sharing. Preserve numeric
intreps when literals are created for the first time. Correct memleak
in ExecConstantExprTree() and add test for the leak.
|
|
|
|
| |
numeric when pre-compiling a constant expresion indicates an error.
|
|
|
|
| |
Label needs debug build exposure in TEBC.
|
|
|
|
|
|
|
|
| |
struct (again "free" due to alignment requirements) to mark those
subexpressions that are completely known at compile time. Enhanced
CompileExprTree() and its callers to precompute these constant
subexpressions at compile time. This resolves the issue raised
in [Bug 1564517].
|
| |
|
|
|
|
| |
eliminate duplication.
|
|
|
|
|
|
|
|
| |
OpNode mark field scheme of tree traversal. This eliminates the need
to use magic values in the left and right fields for that purpose.
Also stop abusing the left field within ParseExpr() to store the
number of arguments in a parsed function call. CompileExprTree() now
determines that for itself at compile time.
|
|
|
|
|
|
|
|
|
| |
* generic/tclCompExpr.c: Added a "mark" field to the OpNode
struct, which is used to guide tree traversal. This field costs
nothing since alignement requirements used the memory already.
Rewrote ConvertTreeToTokens() to use the new field, which permitted
consolidation of utility routines CopyTokens() and
GenerateTokensForLiteral().
|
| |
|
| |
|
|
|
|
|
|
| |
explain the operations of ParseExpr(), made significant revisions
to the code so it would be easier to explain, and in the process
made the code simpler and clearer as well.
|
|
|
|
|
|
| |
* tests/parseExpr.test: Several tests of syntax error messages
to check that when expression substrings are truncated they leave
visible the context relevant to the reported error.
|
| |
|
|
|
|
| |
common code for reporting syntax errors in LEAF elements.
|
|
|
|
|
|
|
|
|
|
|
| |
ParseExpr() to indicate whether the caller is Tcl_ParseExpr(), with an
end goal of filling a Tcl_Parse with Tcl_Tokens representing the
parsed expression, or TclCompileExpr() with the goal of compiling and
executing the expression. In the latter case, more aggressive
conversion of QUOTED and BRACED lexeme to literals is done. In the
former case, all such conversion is avoided, since Tcl_Token production
would revert it anyway. This enables simplifications to the
GenerateTokensForLiteral() routine as well.
|
|
|
|
| |
clarity and replaced some cryptic logic with more readable macros.
|
| |
|
|
|
|
|
|
|
|
| |
to be stored directly in the parse tree. There's no memory cost to
this addition, since that memory would have been lost to alignment
issues anyway. Also, converted precedence definitions and lookup
tables to use symbolic constants instead of raw number for improved
readability, and continued extending/improving/correcting comments.
|
| |
|
|
|
|
|
|
|
| |
gets inserted into the parse tree. Later tree traversal never reaches
it since its location in the tree is not variable. Starting and
stopping with the START lexeme (node 0) is sufficient. Also finished
lexeme code commentary.
|
|
|
|
| |
of the Tcl_Parse fields that indicate error conditions. [Bug 1749987]
|
| |
|
| |
|
|
|
|
| |
is now more expansion room to define more BINARY operators.
|
|
|
|
|
| |
* generic/tclEvent.c: of expr parsing and compiling, including the
* generic/tclInt.h: routine TclFinalizeCompilation().
|
|
|
|
|
|
| |
* generic/tclCompExpr.c: off the C stack and onto the Tcl stack.
* generic/tclCompile.c: This is a rather large struct (> 3kB).
* generic/tclParse.c:
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* generic/tclExecute.c: TclStackAlloc and TclStackFree to make them
easier for callers to use (or more precisely, harder to misuse).
TclStackFree now takes a (void *) argument which is the pointer
intended to be freed. TclStackFree will panic if that's not actually
the memory the call will free. TSA/TSF also now tolerate receiving
(interp == NULL), in which case they simply fall back to be calls to
Tcl_Alloc/Tcl_Free.
* generic/tclIntDecls.h: make genstubs
* generic/tclBasic.c: Updated callers
* generic/tclCmdAH.c:
* generic/tclCmdIL.c:
* generic/tclCompCmds.c:
* generic/tclCompExpr.c:
* generic/tclCompile.c:
* generic/tclFCmd.c:
* generic/tclFileName.c:
* generic/tclIOCmd.c:
* generic/tclIndexObj.c:
* generic/tclInterp.c:
* generic/tclNamesp.c:
* generic/tclProc.c:
* generic/tclTrace.c:
* unix/tclUnixPipe.c:
|
|
|
|
|
|
| |
an error return doesn't prevent all literals getting placed on the
litList to be returned to the caller for freeing. Corrects some
memleaks. [Bug 1705778, leak K23]
|
|
|
|
| |
literal Tcl_Obj was not getting freed. [Bug 1705778, leak #1 (new)]
|
|
|
|
|
|
|
|
| |
leak in 'upvar' when compiling (a) upvar outside a proc, (b)
upvar with a syntax error, or (c) upvar where the frame index
is not known at compile time.
* generic/tclParseExpr.c (ParseExpr): Plugged a memory leak
when parsing expressions that contain syntax errors.
|
| |
|
|
|
|
| |
efficient). After [Patch 1529526] (afredd)
|
|
|
|
|
|
| |
* generic/tclCompCmds.c: Replace arrays on the C stack and
ckalloc calls with TclStackAlloc calls to use memory on Tcl's
evaluation stack
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
are in use to support operator commands, might as well make them
the default for [expr] as well and avoid passing every parsed
expression through the inefficient Tcl_Token array format. This
addresses most issues in [RFE 1517602] Assuming no performance
disasters result from this, much dead code supporting the other
implementation might now be removed.
|
|
|
|
|
|
| |
* generic/tclCompExpr.c: of the operator commands through TEBC,
* generic/tclCompile.h: dropping all the routines in tclMathOp.c.
* generic/tclMathOp.c: Still needs Engineering Manual attention.
|
|
|
|
|
| |
* generic/tclCompExpr.c: now routing through TEBC via
* generic/tclCompile.h: TclSortingOpCmd().
|
|
|
|
|
|
|
|
| |
* generic/tclCompExpr.c: TclExecuteByteCode to implement the TIP 174
* generic/tclCompile.h: commands instead of using a mass of code
* generic/tclMathOp.c: duplication. Now all operator commands that
* tests/mathop.test: demand exactly one operation are implemented
via TclSingleOpCmd and a call to TEBC.
|
|
|
|
|
|
|
|
|
|
| |
* generic/tclMathOp.c: to perform a bytecode compile / execute
sequence. This demonstrates a path toward avoiding mountains of
code duplication in tclMathOp.c and tclExecute.c.
* generic/tclCompile.h: Change TclExecuteByteCode() from static to
* generic/tclExecute.c: MODULE_SCOPE so all files including
tclCompile.h may call it.
|
|
|
|
|
|
|
| |
CompileExprTree() routine that can produce expression bytecode
directly from internal structures with no need to pass through
the Tcl_Token array representation. Still disabled by default.
#undef USE_EXPR_TOKENS to try it out.
|
|
|
|
|
|
|
|
|
|
| |
produce a different set of internal structures representing the parsed
expression, as well as routines that go on to convert those structures
into the traditional Tcl_Token array format. Use of these routines
is currently disabled. #undef PARSE_DIRECT_EXPR_TOKENS to enable
them. These routines will only become really useful when more
routines that compile directly from the new internal structures are
completed.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* generic/tclCmdAH.c:
* generic/tclCmdIL.c:
* generic/tclCmdMZ.c:
* generic/tclCompCmds.c:
* generic/tclCompExpr.c:
* generic/tclCompile.c:
* generic/tclCompile.h:
* generic/tclExecute.c:
* generic/tclIOUtil.c:
* generic/tclInt.h:
* generic/tclInterp.c:
* generic/tclNamesp.c:
* generic/tclObj.c:
* generic/tclProc.c:
* tests/compile.test:
* tests/info.test:
* tests/platform.test:
* tests/safe.test:
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* generic/tcl.decls: New public routines Tcl_ObjPrintf,
* generic/tclStringObj.c: Tcl_AppendObjToErrorInfo, Tcl_Format,
* generic/tclInt.h: Tcl_AppendLimitedToObj,
Tcl_AppendFormatToObj and Tcl_AppendPrintfToObj. Former internal
versions removed.
* generic/tclDecls.h: make genstubs
* generic/tclStubInit.c:
* generic/tclBasic.c: Updated callers.
* generic/tclCkalloc.c:
* generic/tclCmdAH.c:
* generic/tclCmdIL.c:
* generic/tclCmdMZ.c:
* generic/tclCompExpr.c:
* generic/tclCompile.c:
* generic/tclDictObj.c:
* generic/tclExecute.c:
* generic/tclIORChan.c:
* generic/tclIOUtil.c:
* generic/tclMain.c:
* generic/tclNamesp.c:
* generic/tclObj.c:
* generic/tclPkg.c:
* generic/tclProc.c:
* generic/tclStrToD.c:
* generic/tclTimer.c:
* generic/tclUtil.c:
* unix/tclUnixFCmd.c:
|