summaryrefslogtreecommitdiffstats
path: root/generic/tclCompExpr.c
Commit message (Collapse)AuthorAgeFilesLines
* Various mismatches between Tcl_Panic format string and its arguments,nijtmans2011-01-181-3/+3
| | | | discovered thanks to [Bug 3159920]
* * generic/tclBasic.c: [Patch 3072080] (minus the itclMiguel Sofer2010-09-271-2/+4
| | | | | | | | | | | | | | * generic/tclCmdIL.c: update): a saner NRE. * generic/tclCompExpr.c: * generic/tclCompile.c: This makes TclNRExecuteByteCode * generic/tclCompile.h: (ex TEBC) to be a normal NRE * generic/tclExecute.c: citizen: it loses its special status. * generic/tclInt.decls: The logic flow within the BC engine is * generic/tclInt.h: simplified considerably. * generic/tclIntDecls.h: * generic/tclObj.c: * generic/tclProc.c: * generic/tclTest.c:
* * generic/tclCompExpr.c: Slight change in the literal sharingMiguel Sofer2010-04-291-2/+2
| | | | | | * generic/tclCompile.c: mechanism to avoid shimmering of * generic/tclCompile.h: command names. * generic/tclLiteral.c:
* Code Audit results:dkf2010-03-051-9/+9
| | | | | | | | * use do { ... } while (0) in macros * avoid shadowing one local variable with another * use clearer 'foo.bar++;' instead of '++foo.bar;' where result not required (i.e., semantically equivalent) * follow Engineering Manual rules on spacing and declarations
* More tidying up (whitespace, spelling, useless parentheses, useless casts)dkf2010-02-241-27/+23
|
* Fix gcc warning, using gcc-4.3.4 on cygwinnijtmans2009-12-111-2/+2
| | | | | warning: array subscript has type 'char' win/makefile.vc Revert to version 1.203 [Bug #2912773]
* Fix gcc warning, using gcc-4.3.4 on cygwinnijtmans2009-12-111-2/+2
| | | | | warning: array subscript has type 'char' win/makefile.vc Revert to version 1.203 [Bug #2912773]
* * generic/tclExecute.c: fix potential uninitialized variable use anddas2009-09-071-1/+4
| | | | | | | | | | | | * generic/tclFCmd.c: null dereference flagged by clang static * generic/tclProc.c: analyzer. * generic/tclTimer.c: * generic/tclUtf.c: * generic/tclExecute.c: silence false positives from clang static * generic/tclIO.c: analyzer about potential null dereference. * generic/tclScan.c: * generic/tclCompExpr.c:
* Style fixes (unfouling whitespace, sorting comments, removing useless casts, ↵dkf2009-01-091-349/+387
| | | | etc.)
* Style improvements - invoking callbacks without visual junk.dkf2008-10-261-2/+2
|
* * generic/tclCompExpr.c (ParseExpr): Plug memory leak in errordgp2008-02-281-3/+3
| | | | message generation.
* More stray trailing ","s.jenglish2008-02-261-2/+2
|
* * generic/tclInt.h: New macro TclGrowParseTokenArray() todgp2008-01-231-18/+6
| | | | | | | | | | | | | | * generic/tclCompCmds.c: simplify code that might need to grow * generic/tclCompExpr.c: an array of Tcl_Tokens in the parsePtr * generic/tclParse.c: field of a Tcl_Parse. Replaces the TclExpandTokenArray() routine via replacing: int needed = parsePtr->numTokens + growth; while (needed > parsePtr->tokensAvailable) { TclExpandTokenArray(parsePtr); } with: TclGrowParseTokenArray(parsePtr, growth); This revision merged over from dgp-refactor branch.
* * generic/tclCompExpr.c: Revision to preserve parsed intrepsdgp2008-01-171-5/+42
| | | | | of numeric and boolean literals when compiling expressions with (optimize == 1).
* * generic/tclCompExpr.c: add an 'optimize' argument toMiguel Sofer2008-01-161-3/+4
| | | | | | * generic/tclCompile.c: TclCompileExpr() to profit from better * generic/tclCompile.h: literal management according to usage. * generic/tclExecute.c:
* * generic/tclCompExpr.c: Fix literal leak in exprs [Bug 1869989]Miguel Sofer2008-01-161-40/+21
| | | | * generic/tclExecute.c: (dgp)
* * generic/tclBasic.c: Replacing 'operator' by 'op' in the defMiguel Sofer2008-01-151-5/+4
| | | | | * generic/tclCompExpr.c: of struct TclOpCmdClientData to * generic/tclCompile.h: accomodate C++ compilers [Bug 1855644]
* merge stable branch onto HEADdgp2007-12-131-1/+1
|
* [Patch 1830038]: Increased usage of macros to detect and take advantage of ↵Miguel Sofer2007-11-111-5/+6
| | | | objTypes.
* * generic/tclCompExpr.c: Moved a misplaced declaration that blockedKevin B Kenny2007-10-171-2/+3
| | | | | | compilation on VC++. * generic/tclExecute.c: Silenced several VC++ compiler warnings about converting 'long' to 'unsigned short'.
* * generic/tclIOCmd.c: Revise [open] so that it interprets leadingdgp2007-10-151-1/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | zero strings passed as the "permissions" argument as octal numbers, even if Tcl itself no longer parses integers in that way. * unix/tclUnixFCmd.c: Revise the "-permissions" [file attribute] so that it interprets leading zero strings as octal numbers, even if Tcl itself no longer parses integers in that way. * generic/tclCompExpr.c: Corrections to code that produces * generic/tclUtil.c: extended "bad octal" error messages. * tests/cmdAH.test: Test revisions so that tests pass whether or * tests/cmdIL.test: not Tcl parses leading zero strings as octal. * tests/compExpr-old.test: * tests/compExpr.test: * tests/compile.test: * tests/expr-old.test: * tests/expr.test: * tests/incr.test: * tests/io.test: * tests/lindex.test: * tests/link.test: * tests/mathop.test: * tests/parseExpr.test: * tests/set.test: * tests/string.test: * tests/stringComp.test:
* * generic/tclCompExpr.c: Use a table lookup in ParseLexeme()dgp2007-08-281-63/+55
| | | | to determine lexemes with single-byte representations.
* * generic/tclBasic.c: Used unions to better clarify overloading ofdgp2007-08-281-9/+7
| | | | | * generic/tclCompExpr.c: the fields of the OpCmdInfo and * generic/tclCompile.h: TclOpCmdClientData structs.
* typodas2007-08-271-2/+3
|
* * generic/tclCompExpr.c: Call TclCompileSyntaxError() whendgp2007-08-271-23/+5
| | | | | | | | | | | | | | | | expression syntax errors are found when compiling expressions. With this in place, convert TclCompileExpr to return void, since there's no longer any need to report TCL_ERROR. * generic/tclCompile.c: Update callers. * generic/tclExecute.c: * generic/tclCompCmds.c: New routine TclCompileSyntaxError() * generic/tclCompile.h: to directly compile bytecodes that report a * generic/tclCompile.c: syntax error, rather than (ab)use a call to TclCompileReturnCmd. Also, undo the most recent commit that papered over some issues with that (ab)use. New routine produces a new opcode INST_SYNTAX, which is a minor variation of INST_RETURN_IMM. Also a bit of constification.
* * generic/tclCompile.c: Move the deallocation of local LiteralTabledgp2007-08-271-4/+1
| | | | | * generic/tclCompExpr.c: entries into TclFreeCompileEnv(). * generic/tclExecute.c: Update callers.
* * generic/tclCompExpr.c: Force numeric and boolean literalsdgp2007-08-271-7/+26
| | | | | in expressions to register with their intreps intact, even if that means overwriting existing intreps in already registered literals.
* * generic/tclCompExpr.c: Register literals found in expressionsdgp2007-08-241-5/+29
| | | | | | * tests/compExpr.test: to restore literal sharing. Preserve numeric intreps when literals are created for the first time. Correct memleak in ExecConstantExprTree() and add test for the leak.
* * generic/tclCompExpr.c: Suppress the attempt to convert todgp2007-08-231-2/+2
| | | | numeric when pre-compiling a constant expresion indicates an error.
* Missing init in ParseExpr().dgp2007-08-221-1/+2
| | | | Label needs debug build exposure in TEBC.
* * generic/tclCompExpr.c: Added a "constant" field to the OpNodedgp2007-08-161-90/+296
| | | | | | | | struct (again "free" due to alignment requirements) to mark those subexpressions that are completely known at compile time. Enhanced CompileExprTree() and its callers to precompute these constant subexpressions at compile time. This resolves the issue raised in [Bug 1564517].
* comment correctionsdgp2007-08-141-8/+7
|
* Then reorder code todgp2007-08-101-219/+174
| | | | eliminate duplication.
* * generic/tclCompExpr.c: Revise CompileExprTree() to use thedgp2007-08-101-65/+117
| | | | | | | | OpNode mark field scheme of tree traversal. This eliminates the need to use magic values in the left and right fields for that purpose. Also stop abusing the left field within ParseExpr() to store the number of arguments in a parsed function call. CompileExprTree() now determines that for itself at compile time.
* * tests/parseExpr.test: Update source file name of expr parser code.dgp2007-08-061-262/+285
| | | | | | | | | * generic/tclCompExpr.c: Added a "mark" field to the OpNode struct, which is used to guide tree traversal. This field costs nothing since alignement requirements used the memory already. Rewrote ConvertTreeToTokens() to use the new field, which permitted consolidation of utility routines CopyTokens() and GenerateTokensForLiteral().
* * generic/tclCompExpr.c: Removed unused arguments and variables.dgp2007-07-181-43/+25
|
* typodgp2007-07-171-2/+2
|
* * generic/tclCompExpr.c (ParseExpr): While adding comments todgp2007-07-171-202/+251
| | | | | | explain the operations of ParseExpr(), made significant revisions to the code so it would be easier to explain, and in the process made the code simpler and clearer as well.
* * generic/tclCompExpr.c: More commentary.dgp2007-07-161-6/+27
| | | | | | * tests/parseExpr.test: Several tests of syntax error messages to check that when expression substrings are truncated they leave visible the context relevant to the reported error.
* additional commentarydgp2007-07-121-6/+25
|
* * generic/tclCompExpr.c: Factored out, corrected, and commenteddgp2007-07-121-44/+43
| | | | common code for reporting syntax errors in LEAF elements.
* * generic/tclCompExpr.c: Added a "parseOnly" flag argument todgp2007-07-111-49/+29
| | | | | | | | | | | ParseExpr() to indicate whether the caller is Tcl_ParseExpr(), with an end goal of filling a Tcl_Parse with Tcl_Tokens representing the parsed expression, or TclCompileExpr() with the goal of compiling and executing the expression. In the latter case, more aggressive conversion of QUOTED and BRACED lexeme to literals is done. In the former case, all such conversion is avoided, since Tcl_Token production would revert it anyway. This enables simplifications to the GenerateTokensForLiteral() routine as well.
* Renamed some variables fordgp2007-07-101-46/+115
| | | | clarity and replaced some cryptic logic with more readable macros.
* Removed some unused counter variables.dgp2007-07-101-6/+17
|
* * generic/tclCompExpr.c: Added a field for operator precedencedgp2007-07-101-40/+165
| | | | | | | | to be stored directly in the parse tree. There's no memory cost to this addition, since that memory would have been lost to alignment issues anyway. Also, converted precedence definitions and lookup tables to use symbolic constants instead of raw number for improved readability, and continued extending/improving/correcting comments.
* More extended commentary about the data structures of the expr parser.dgp2007-07-091-43/+85
|
* * generic/tclCompExpr.c: Revision so that the END lexeme neverdgp2007-07-091-4/+32
| | | | | | | gets inserted into the parse tree. Later tree traversal never reaches it since its location in the tree is not variable. Starting and stopping with the START lexeme (node 0) is sufficient. Also finished lexeme code commentary.
* * generic/tclCompExpr.c: Added missing creation and returndgp2007-07-091-2/+11
| | | | of the Tcl_Parse fields that indicate error conditions. [Bug 1749987]
* More work in progress commenting the expr parserdgp2007-07-051-10/+55
|
* Start of work adding more useful comments to the expr parser.dgp2007-07-051-20/+63
|