summaryrefslogtreecommitdiffstats
path: root/generic/tclStringObj.c
Commit message (Collapse)AuthorAgeFilesLines
* * generic/tclBinary.c (TclAppendBytesToByteArray): Add commentsdgp2010-04-301-3/+3
| | | | | | | | | | | * generic/tclInt.h (TclAppendBytesToByteArray): placing overflow protection responsibility on caller. Convert "len" argument to signed int which any value already vetted for overflow issues will fit into. * generic/tclStringObj.c: Update caller; standardize panic msg. * generic/tclBinary.c (UpdateStringOfByteArray): Add panic when the generated string representation would grow beyond Tcl's size limits. [Bug 2994924]
* * generic/tclBinary.c (TclAppendBytesToByteArray): [Bug 2992970]: Makedkf2010-04-291-4/+3
| | | | | | * generic/tclStringObj.c (Tcl_AppendObjToObj): an append of a byte array to another into an efficent operation. The problem was the (lack of) a proper growth management strategy for the byte array.
* * generic/tclStringObj.c: Fix array overrun in test format-1.12dgp2010-03-291-2/+2
| | | | caught by valgrind testing.
* Code Audit results:dkf2010-03-051-3/+5
| | | | | | | | * use do { ... } while (0) in macros * avoid shadowing one local variable with another * use clearer 'foo.bar++;' instead of '++foo.bar;' where result not required (i.e., semantically equivalent) * follow Engineering Manual rules on spacing and declarations
* Pure whitespace changes, changing to follow Engineering Manual style.dkf2010-02-241-4/+4
|
* Ensure that objects are released in all cases (hard to test this particulardkf2010-01-181-1/+4
| | | | one without a very large system, but the leak path existed)
* [Bug 2932421]: Make [format] less likely to smash intreps.dkf2010-01-181-40/+48
|
* * generic/tclDictObj.c: Updated freeIntRepProc routines sodgp2009-09-301-1/+2
| | | | | | | | | | | | | | | * generic/tclExecute.c: that they set the typePtr field to * generic/tclIO.c: NULL so that the Tcl_Obj is not left * generic/tclIndexObj.c: in an inconsistent state. * generic/tclInt.h: [Bug 2857044] * generic/tclListObj.c: * generic/tclNamesp.c: * generic/tclOOCall.c: * generic/tclObj.c: * generic/tclPathObj.c: * generic/tclProc.c: * generic/tclRegexp.c: * generic/tclStringObj.c:
* * generic/tclStringObj.c: A few more string overflow cases indgp2009-08-271-3/+13
| | | | [format]. [Bug 2845535]
* * generic/tclStringObj.c: Corrected failure to grow bufferdgp2009-07-311-1/+4
| | | | | * tests/format.test: when format spec request large width floating point values. Thanks to Clemens Misch. [Bug 2830354]
* Fix [Bug 2637173] by consolidating bytearray purity check.dkf2009-07-121-18/+5
|
* Cast wide integer to int conversion (silence msvc6 warning)patthoyts2009-07-011-3/+3
|
* * generic/tclStringObj.c: sprintf() -> Tcl_ObjPrintf() conversion.dgp2009-06-151-5/+3
|
* * generic/tclStringObj.c: Revised [format] to not overflow thedgp2009-06-101-8/+69
| | | | | | | integer calculations computing the length of the %ll formats of really big integers. Also added protections so that [format]s that would produce results overflowing the maximum string length of Tcl values throw a normal Tcl error instead of a panic. [Bug 2801413]
* * generic/tclStringObj.c: Corrected failures to deal with thedgp2009-06-101-22/+10
| | | | | "pure unicode" representation of an empty string. Thanks to Julian Noble for reporting the problem. [Bug 2803109]
* * generic/tclStringObj.c: Correction so that value ofdgp2009-04-071-2/+2
| | | | TCL_GROWTH_MIN_ALLOC is everywhere expressed in bytes as comment claims.
* * generic/tclStringObj.c: Several revisions to the shimmeringdgp2009-02-221-17/+65
| | | | | | | | | | | | | patterns between Unicode and UTF string reps. Most notably the call: objPtr = Tcl_NewUnicodeObj(...,0); followed by a loop of calls: Tcl_AppendUnicodeToObj(objPtr, u, n); will now grow and append to the Unicode representation. Before this commit, the sequence would convert each append to UTF and perform the append to the UTF rep. This is puzzling and likely a bug. The performance of [string map] is significantly improved by this change (according to the MAP collection of benchmarks in tclbench). Just in case there was some wisdom in the old ways that I missed, I left in the ability to restore the old patterns with a #define COMPAT 1 at the top of the file.
* alternative solution to the signed/unsigned warningsdgp2009-02-191-5/+5
|
* fix signed/unsigned comparison warningsdas2009-02-191-4/+4
|
* * generic/tclStringObj.c: Simplify the logic of thedgp2009-02-181-66/+31
| | | | Tcl_*SetObjLength() routines.
* another TODOdgp2009-02-181-1/+2
|
* * generic/tclStringObj.c: Rewrite GrowStringBuffer() so that itdgp2009-02-181-16/+23
| | | | | | | | has parallel structure with GrowUnicodeBuffer(). The revision permits allocation attempts to continue all the way up to failure, with no gap. It also directly manipulates the String and Tcl_Obj internals instead of inefficiently operating via Tcl_*SetObjLength() with all of its extra protections and underdocumented special cases.
* * generic/tclStringObj.c: Another round of simplification ondgp2009-02-181-21/+21
| | | | the allocation macros.
* * generic/tclStringObj.c: Another round of simplification ondgp2009-02-181-29/+25
| | | | the allocation macros.
* * generic/tclStringObj.c: Pare back the length of the unicodedgp2009-02-171-12/+10
| | | | | | | | array in a non-extended String struct to one Tcl_UniChar, meant to hold the terminating NUL character. Non-empty unicode strings are then stored by extending the String struct by stringPtr->maxChars additional slots in that array with sizeof(Tcl_UniChar) bytes per slot. This revision makes the allocation macros much simpler.
* * generic/tclStringObj.c: Factor out common GrowUnicodeBuffer()dgp2009-02-171-44/+51
| | | | and solve overflow and growth algorithm fallbacks in it.
* * generic/tclStringObj.c: Factor out common GrowStringBuffer().dgp2009-02-171-150/+47
| | | | | | | | | | | * generic/tclStringObj.c: Convert Tcl_AppendStringsToObj into * tests/stringObj.test: a radically simpler implementation where we just loop over calls to Tcl_AppendToObj. This fixes [Bug 2597185]. It also creates a *** POTENTIAL INCOMPATIBILITY *** in that T_ASTO can now allocate more space than is strictly required, like all the other Tcl_Append* routines. The incompatibility was detected by test stringObj-6.5, which I've updated to reflect the new behavior.
* * generic/tclStringObj.c: Revise buffer growth implementationdgp2009-02-171-13/+32
| | | | | | | in ExtendStringRepWithUnicode. Use cheap checks to determine that no reallocation is necessary without cost of computing the precise number of bytes needed. Also make use of the string growth algortihm in the case of repeated appends.
* * generic/tclStringObj.c: Added protections from invalid memorydgp2009-02-161-4/+32
| | | | | | | * generic/tclTestObj.c: accesses when we append (some part of) * tests/stringObj.test: a Tcl_Obj to itself. Added the appendself and appendself2 subcommands to the [teststringobj] testing command and added tests to the test suite. [Bug 2603158]
* * generic/tclStringObj.c: Factor out duplicate code fromdgp2009-02-151-12/+4
| | | | Tcl_AppendObjToObj.
* * generic/tclStringObj.c: Replace the 'size_t uallocated' fielddgp2009-02-151-46/+42
| | | | | | | | of the String struct, storing the number of bytes allocated to store the Tcl_UniChar array, with an 'int maxChars' field, storing the number of Tcl_UniChars that may be stored in the allocated space. This reduces memory requirement a small bit, and makes some range checks simpler to code.
* * generic/tclStringObj.c: Removed limitation indgp2009-02-151-12/+7
| | | | | | | | Tcl_AppendObjToObj where the char length of the result was only computed if the appended string was all single byte characters. This limitation was in place to dodge a bug in Tcl_GetUniChar. With that bug gone, we can take advantage of always recording the length of append results when we know it.
* * generic/tclStringObj.c: Revisions so that we avoid creatingdgp2009-02-141-51/+73
| | | | | | | | | | | | the strange representation of an empty string with objPtr->bytes == NULL and stringPtr->hasUnicode == 0. Instead in the situations where that was being created, create a traditional two-legged stork representation (objPtr->bytes = tclEmptyStringRep and stringPtr->hasUnicode = 1). In the situations where the strange rep was treated differently, continue to do so by testing stringPtr->numChars == 0 to detect it. These changes make the code more conventional so easier for new maintainers to pick up. Also sets up further simplifications.
* Remove all "register" keywords.dgp2009-02-131-20/+20
|
* New utility routine UnicodeLength(), to compute the length of unicodedgp2009-02-131-23/+21
| | | | | buffer arguments when no length is passed in, with built-in overflow protection included. Update three callers to use it.
* * generic/tclStringObj.c: Rewrites of the routinesdgp2009-02-131-152/+98
| | | | | | | | | | | Tcl_GetCharLength, Tcl_GetUniChar, Tcl_GetUnicodeFromObj, Tcl_GetRange, and TclStringObjReverse to use the new macro, and to more simply and clearly split the cases depending on whether a valid unicode rep is present or needs to be created. * generic/tclInt.h: New macro TclNumUtfChars meant to be a faster replacement for a full Tcl_NumUtfChars() call when the string has all single-byte characters.
* * generic/tclStringObj.c: Simplified Tcl_GetCharLength bydgp2009-02-121-24/+25
| | | | | | * generic/tclTestObj.c: removing code that did nothing. Added early returns from Tcl_*SetObjLength when the desired length is already present; adapted test command to the change.
* * generic/tclStringObj.c: Re-implemented AppendUtfToUnicodeRepdgp2009-02-121-32/+49
| | | | | | so that we no longer pass through Tcl_DStrings which have their own sets of problems when lengths overflow the int range. Now AUTUR and FillUnicodeRep share a common core routine.
* Revise latest commit to better maintain stringPtr->numChars.dgp2009-02-121-8/+12
|
* * generic/tclStringObj.c: Re-implemented AppendUnicodeToUtfRepdgp2009-02-121-54/+79
| | | | | | so that we no longer pass through Tcl_DStrings which have their own sets of problems when lengths overflow the int range. Now AUTUR and UpdateStringOfString share a common core routine.
* Removed casts now unnecessary after type of stringPtr->allocated changed.dgp2009-02-111-5/+5
|
* * generic/tclStringObj.c: Changed type of the 'allocated' fielddgp2009-02-111-2/+2
| | | | | of the String struct from size_t to int since only int values are ever stored in it.
* - eliminate some unnessary type castsnijtmans2009-02-101-3/+3
| | | | | - some internal const decorations - spacing
* Removed handling of (objPtr->bytes != NULL) from UpdateStringOfString,dgp2009-02-101-3/+1
| | | | which is only called when objPtr->bytes is NULL.
* Simplify Tcl_SetObjLength by removing unreachable code.dgp2009-02-101-10/+3
|
* Simplify SetStringFromAny() by removing unreachable and duplicate code.dgp2009-02-101-25/+13
|
* * generic/tclObj.c (Tcl_GetString): Added comments and validitydgp2009-02-101-11/+4
| | | | | | checks following the call to an UpdateStringProc. Simplify Tcl_AttemptSetObjLength by removing unreachable code.
* Convert all Tcl_InvalidateStringRep() calls into macros.dgp2009-02-101-7/+7
|
* * generic/tclStringObj.c: Reduce code duplication in Tcl_GetUnicode*.dgp2009-02-101-5/+3
| | | | Restrict AppendUtfToUtfRep to non-negative length appends.
* * generic/tclStringObj.c (Tcl_GetUnicode*): Reduce code duplication.dgp2009-02-101-25/+2
|
generated by cgit v0.12 at 2024-11-14 04:32:03 (GMT)