Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | Add warning commentary making important assumptions explicit. | dgp | 2016-10-28 | 1 | -0/+2 |
| | |||||
* | Eliminate unnessessary end-of-line spacing. No functional change. | jan.nijtmans | 2015-10-04 | 1 | -2/+2 |
| | |||||
* | Revised ReadChars to restore an attempt to make sure we do not short readdgp_may_be_pointless | dgp | 2014-02-06 | 1 | -0/+32 |
| | | | | | because of a false notion of limited storage space. The test suite does not appear to demonstrate any case where this matters. Could be an incomplete test suite, or an example of pointless code. | ||||
* | Revise the Tcl_Append* machinery to tolerate NULL bytes to append. | dgp | 2014-01-27 | 1 | -10/+19 |
| | | | | Then have ReadChars() use that machinery to resize buffer receiving input, rather than invent its own version. Simplify ReadChars() callers. | ||||
* | Tcl_InvalidateStringRep -> TclInvalidateStringRep | jan.nijtmans | 2013-02-07 | 1 | -6/+6 |
| | |||||
* | Use twoPtrValue.ptr1 in stead of otherValuePtr everywhere. This is exactly ↵ | jan.nijtmans | 2013-01-31 | 1 | -2/+2 |
| | | | | the same field, but it allows twoPtrValue.ptr2 to be used for other purposes. | ||||
* | 3484402 Correct Off-By-One error appending unicode. Thanks to Poor Yorick. | dgp | 2012-02-09 | 1 | -2/+2 |
|\ | | | | | Also corrected test for when growth is needed. | ||||
| * | 3484402 Correct Off-By-One error appending unicode. Thanks to Poor Yorick. | dgp | 2012-02-09 | 1 | -2/+2 |
| |\ | | | | | | | Also corrected test for when growth is needed. | ||||
| | * | 3484402 Correct Off-By-One error appending unicode. Thanks to Poor Yorick.bug_3484402 | dgp | 2012-02-07 | 1 | -4/+4 |
| |/ | | | | | | | Also converted some memcpy() to memmove() to reliably handle overlapping copies, and corrected test for when growth is needed. | ||||
| * | Fix gcc warnings (discovered with latest mingw, based on gcc 4.6.1) | jan.nijtmans | 2011-10-07 | 1 | -1/+1 |
| | | |||||
* | | Backport fix for [Bug 2857044]. | dgp | 2011-04-27 | 1 | -0/+1 |
| | | |||||
* | | Repair corruption in [string reverse] when string rep invalidation failed | dgp | 2011-04-12 | 1 | -0/+1 |
| | | | | | | to also reset the bytes allocated for string rep to zero [Bug 3285472]. | ||||
* | | Now that we're no longer using SCM based on RCS, the RCS Keyword lines cause | dgp | 2011-03-02 | 1 | -2/+1 |
|\ \ | |/ | | | more harm than good. Purged them. | ||||
| * | Typo in last commit broke tclStringObj.c build. Fixed. | dgp | 2011-03-01 | 1 | -0/+1 |
| | | |||||
| * | Now that we're no longer using SCM based on RCS, the RCS Keyword lines cause | dgp | 2011-03-01 | 1 | -2/+0 |
| | | | | | | more harm than good. Purged them. | ||||
| * | * generic/tclStringObj.c: (SetStringFromAny): avoid trampling | vasiljevic | 2010-04-02 | 1 | -2/+4 |
| | | | | | | | | | | over the tclEmptyStringRep->bytes as it is thread-shared (thx to Gustaf Neumann for the (hard) work of locating this one). | ||||
| * | * generic/tclStringObj.c (UpdateStringOfString): Added cast to fix | andreas_kupries | 2009-04-22 | 1 | -2/+2 |
| | | | | | | | | signed/unsigned mismatch breaking win32 symbol/debug build. | ||||
| * | UpdateStringOfString: matchup with core-8-5-branch changes | das | 2009-04-15 | 1 | -6/+6 |
| | | |||||
| * | * generic/tclStringObj.c: AppendUnicodeToUnicodeRep failed | dgp | 2009-04-15 | 1 | -1/+2 |
| | | | | | | | | to set stringPtr->allocated to 0, leading to crashes. | ||||
| * | * generic/tclStringObj.c: Completed backports of fixes for | dgp | 2009-04-07 | 1 | -66/+113 |
| | | | | | | | | [Bug 2494093] and [Bug 2553906]. | ||||
| * | * generic/tclStringObj.c: Added protections from invalid memory | dgp | 2009-03-30 | 1 | -1/+32 |
| | | | | | | | | | | | | | | * generic/tclTestObj.c: accesses when we append (some part of) * tests/stringObj.test: a Tcl_Obj to itself. Added the appendself and appendself2 subcommands to the [teststringobj] testing command and added tests to the test suite. [Bug 2603158] | ||||
| * | * generic/tclStringObj.c: Test stringObj-6.9 checks that | dgp | 2009-03-21 | 1 | -2/+8 |
| | | | | | | | | | | * tests/stringObj.test: Tcl_AppendStringsToObj() no longer crashes when operating on a pure unicode value. [Bug 2597185] | ||||
| * | * generic/tclStringObj.c: Added overflow protections to the | dgp | 2009-02-05 | 1 | -4/+29 |
| | | | | | | | | | | AppendUtfToUtfRep routine to either avoid invalid arguments and crashes, or to replace them with controlled panics. [Bug 2561794] | ||||
| * | * generic/tclStringObj.c (SetUnicodeObj): Corrected failure of | dgp | 2009-02-04 | 1 | -46/+34 |
| | | | | | | | | | | Tcl_SetUnicodeObj() to panic on a shared object. [Bug 2561488]. Also factored out common code to reduce duplication. | ||||
| * | * generic/tclStringObj.c (STRING_SIZE): Corrected failure to limit | dgp | 2009-01-09 | 1 | -4/+7 |
| | | | | | | | | | | memory allocation requests to the sizes that can be supported by Tcl's memory allocation routines. [Bug 2494093]. | ||||
| * | * generic/tclStringObj.c (STRING_UALLOC): Added missing parens | dgp | 2009-01-08 | 1 | -2/+2 |
| | | | | | | | | | | required to get correct results out of things like STRING_UALLOC(num + append). [Bug 2494093]. | ||||
| * | * generic/tclParse.c (Tcl_ParseCommand): also return an error if | Miguel Sofer | 2006-09-24 | 1 | -3/+5 |
| | | | | | | | | | | | | | | start==NULL and numBytes<0. This is coverity's bug #20 * generic/tclStringObj.c (STRING_SIZE): fix allocation for 0-length strings. This is coverity's bugs #54-5 | ||||
| * | * generic/tclStringObj.c: fixed incorrect handling of internal rep | Miguel Sofer | 2006-01-23 | 1 | -2/+2 |
| | | | | | | | | in Tcl_GetRange [Bug 1410553]. Thanks to twylite and Peter Spjuth. | ||||
* | | * generic/tclStringObj.c: (SetStringFromAny): avoid trampling | vasiljevic | 2010-04-02 | 1 | -2/+4 |
| | | | | | | | | | | over the tclEmptyStringRep->bytes as it is thread-shared (thx to Gustaf Neumann for the (hard) work of locating this one). | ||||
* | | * generic/tclStringObj.c: Fix array overrun in test format-1.12 | dgp | 2010-03-29 | 1 | -2/+2 |
| | | | | | | | | caught by valgrind testing. | ||||
* | | [Bug 2932421]: Make [format] less likely to smash intreps. | dkf | 2010-01-18 | 1 | -21/+33 |
| | | |||||
* | | * generic/tclStringObj.c: A few more string overflow cases in | dgp | 2009-08-27 | 1 | -3/+13 |
| | | | | | | | | [format]. [Bug 2845535] | ||||
* | | * generic/tclStringObj.c: Corrected failure to grow buffer | dgp | 2009-07-31 | 1 | -1/+4 |
| | | | | | | | | | | * tests/format.test: when format spec request large width floating point values. Thanks to Clemens Misch. [Bug 2830354] | ||||
* | | fix 64bit int <-> ptr cast warnings | das | 2009-07-15 | 1 | -2/+2 |
| | | |||||
* | | Cast wide integer to int conversion and some signed/unsigned conversions. ↵ | patthoyts | 2009-07-01 | 1 | -3/+3 |
| | | | | | | | | (silence msvc6 warnings) | ||||
* | | * generic/tclStringObj.c: sprintf() -> Tcl_ObjPrintf() conversion. | dgp | 2009-06-15 | 1 | -5/+3 |
| | | |||||
* | | * generic/tclStringObj.c: Revised [format] to not overflow the | dgp | 2009-06-10 | 1 | -8/+68 |
| | | | | | | | | | | | | | | integer calculations computing the length of the %ll formats of really big integers. Also added protections so that [format]s that would produce results overflowing the maximum string length of Tcl values throw a normal Tcl error instead of a panic. [Bug 2801413] | ||||
* | | * generic/tclStringObj.c: AppendUnicodeToUnicodeRep failedcore_8_5_7 | dgp | 2009-04-15 | 1 | -1/+2 |
| | | | | | | | | to set stringPtr->allocated to 0, leading to crashes. | ||||
* | | silence warning preventing symbols build with msvc6 (signed/unsigned comparison) | patthoyts | 2009-04-10 | 1 | -2/+2 |
| | | |||||
* | | * generic/tclStringObj.c (UpdateStringOfString): Fix bug detected | dgp | 2009-04-10 | 1 | -3/+3 |
| | | | | | | | | by compiler warning about undefined "dst". | ||||
* | | * generic/tclStringObj.c: Completed backports of fixes for | dgp | 2009-04-07 | 1 | -68/+112 |
| | | | | | | | | [Bug 2494093] and [Bug 2553906]. | ||||
* | | * generic/tclStringObj.c: Added protections from invalid memory | dgp | 2009-03-30 | 1 | -1/+33 |
| | | | | | | | | | | | | | | * generic/tclTestObj.c: accesses when we append (some part of) * tests/stringObj.test: a Tcl_Obj to itself. Added the appendself and appendself2 subcommands to the [teststringobj] testing command and added tests to the test suite. [Bug 2603158] | ||||
* | | * generic/tclStringObj.c: Test stringObj-6.9 checks that | dgp | 2009-03-21 | 1 | -2/+8 |
| | | | | | | | | | | * tests/stringObj.test: Tcl_AppendStringsToObj() no longer crashes when operating on a pure unicode value. [Bug 2597185] | ||||
* | | * generic/tclStringObj.c: Added overflow protections to the | dgp | 2009-02-05 | 1 | -4/+29 |
| | | | | | | | | | | AppendUtfToUtfRep routine to either avoid invalid arguments and crashes, or to replace them with controlled panics. [Bug 2561794] | ||||
* | | comment typo | dgp | 2009-02-04 | 1 | -2/+2 |
| | | |||||
* | | * generic/tclStringObj.c (SetUnicodeObj): Corrected failure of | dgp | 2009-02-04 | 1 | -43/+28 |
| | | | | | | | | | | Tcl_SetUnicodeObj() to panic on a shared object. [Bug 2561488]. Also factored out common code to reduce duplication. | ||||
* | | * generic/tclStringObj.c (STRING_SIZE): Corrected failure to limit | dgp | 2009-01-09 | 1 | -4/+7 |
| | | | | | | | | | | memory allocation requests to the sizes that can be supported by Tcl's memory allocation routines. [Bug 2494093]. | ||||
* | | * generic/tclStringObj.c (STRING_UALLOC): Added missing parens | dgp | 2009-01-08 | 1 | -2/+2 |
| | | | | | | | | | | required to get correct results out of things like STRING_UALLOC(num + append). [Bug 2494093]. | ||||
* | | * generic/tclStringObj.c (Tcl_AppendFormatToObj): | dgp | 2008-04-07 | 1 | -3/+3 |
| | | | | | | | | | | | | Fix [format {% d}] so that it behaves the same way as in 8.4 and as C's printf(). * tests/format.test: Add a test for '% d' and '%+d'. | ||||
* | | * generic/tclStringObj.c (Tcl_AppendFormatToObj): [format %llx $big] | dgp | 2008-02-28 | 1 | -1/+4 |
| | | | | | | | | leaked an mp_int. |