| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
DOS application, the path priming does not need an ending space as
BuildCommandLine() will do this for us.
|
| | |
|
| |
|
|
| |
rules of quoting
|
| |
|
|
|
| |
with [Bug 805605] to the code, fixing the incorrect use of
ispace noted by Ronald Dauster <ronaldd@users.sourceforge.net>.
|
| |
|
|
|
|
| |
This bug built a command line with a missing space between
tclpipe.dll and the following arguments. It caused error
in Windows 98 when exec command.com (e.g. dir) [Bug 789040]
|
| |
|
|
|
| |
of the other pipe functions. Added a missing PipeInit() call to make
sure the initialization happens.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
symbol for every compile. Instead, define
TCL_PIPE_DLL only when compiling tclWinPipe.c.
This will break other build systems, so
they will need to remove the TCL_DBGX define
and replace it with a define for TCL_PIPE_DLL.
* win/makefile.vc: Ditto.
* win/tclWinPipe.c (TclpCreateProcess):
Remove PREFIX_IDENT and DEBUG_IDENT from
top of file. Use TCL_PIPE_DLL passed in
from build env instead of trying to construct
the dll name from already defined symbols.
This approach is more flexible and better
in the long run.
|
| |
|
|
|
| |
* win/tclWinPipe.c: from tcl.h -- they are not part of Tcl's
public interface. Put them in win/tclWinPipe.c where they are used.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TCL_DEBUG_IDENT, used only by TclpCreateProcess.
* unix/Makefile.in: Define TCL_DBGX.
* win/Makefile.in: Define TCL_DBGX.
* win/tclWinPipe.c (TclpCreateProcess):
Check that the Tcl pipe dll actually exists
in the Tcl bin directory and panic if it
is not found. Incorporate TCL_DBGX into
the Tcl pipe dll name. This fixes a really
mysterious error that would show up when
exec'ing a 16 bit application under Win95
or Win98 when Tcl was compiled with symbols.
The error seemed to indicate that the executable
could not be found, but it was actually the
Tcl pipe dll that could not be found.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
| |
* tests/winPipe.c:
* win/tclWinPipe.c (Tcl_WaitPid):
* win/tclWinTest.c: Gave Tcl_WaitPid the ability to return a
Win32 exception code translated into a posix style SIG*. This
allows [close] to report "CHILDKILLED" without the meaning
getting lost in a truncated exit code. In TclCleanupChildren(),
TclpGetPid() had to get moved to before Tcl_WaitPid() as the
the handle is removed from the list taking away the ability
to get the process id after the wait is done. This shouldn't
effect the unix implimentaion unless waitpid is called with
a pid of zero, meaning "any". I don't think it is..
|
| |
|
|
| |
failures that need to be resolved first.
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
exception, pass this notice on to the caller with a SIG* code
rather than truncating the exit code and missing the meaning.
This allows TclCleanupChildren() to report "CHILDKILLED".
This has a different behavior than unix in that closing the
read pipe to a process sends the SIGPIPE signal which is
returned as a SIGPIPE exit status. On windows, we send the
process a CTRL_BREAK_EVENT and get back a CONTROL_C_EXIT which
is documented to mean a SIGINT which seems wrong as a system,
but is the correct exit status.
|
| |
|
|
| |
to CTRL_BREAK_EVENT as it can't be ignored by the child.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
NULL handle.
* win/tclWinPipe.c (PipeClose2Proc, TclpCreateProcess): Send a
real Win32 signal (CTRL_C_EVENT) when the read channel is brought
down to alert the child to close on its side. Start the process
with CREATE_NEW_PROCESS_GROUP to allow the ability to send these
signals. The following test case now brings down the child
without the use of an external [kill] command.
% set p [open "|[info name]" w+]
file8d5380
% pid $p
2876
% close $p <- now doesn't block in Tcl_WaitPid()
%
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* win/tclWinPipe.c:
* win/tclWinSerial.c:
* win/tclWinSock.c:
* win/tclWinThrd.c:
* win/tclWinTime.c: General cleanup of all worker threads used
by the channel drivers. Eliminates the normal case where the
worker thread is terminated ('cept the winsock one). Instead,
use kernel events to signal a clean exit. Only when the worker
thread is blocked on an I/O call is the thread terminated.
Essentially, this makes all other channel worker threads behave
like the PipeReaderThread() function for it's cleaner exit
behavior. This appears to fix [Bug 597924] but needs 3rd party
confirmation to close the issue.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Split out functionality of TclInExit to make it
clear which one should be called in each situation.
* generic/tclInt.decls: Declare TclInThreadExit.
* generic/tclIntDecls.h: Regen.
* generic/tclStubInit.c: Regen.
* mac/tclMacChan.c (StdIOClose):
* unix/tclUnixChan.c (FileCloseProc):
* win/tclWinChan.c (FileCloseProc):
* win/tclWinConsole.c (ConsoleCloseProc):
* win/tclWinPipe.c (TclpCloseFile):
* win/tclWinSerial.c (SerialCloseProc): Invoke the
new TclInThreadExit method instead of TclInExit.
|
| |
|
|
|
|
| |
on windows did not treat { in filenames well.). Bug reported by
Vince Darley <vincentdarley@users.sourceforge.net>, patch
provided by Vince too.
|
| | |
|
| |
|
|
|
|
|
| |
* [Patch 506818] Updated interfaces of generic/tclHash.c (TIP 27).
* [Patch 506807] Updated interfaces of generic/tclObj.c (TIP 27).
* [Patch 507304] Updated interfaces of win/tclWin32.c (TIP 27).
* Update all callers.
|
| |
|
|
|
|
|
|
|
|
|
| |
generic/tclIOUtil.c, generic/tclPipe.c, generic/tclResult.c,
generic/tclUtil.c, generic/tclVar.c and mac/tclMacResource.c according
to TIP 27. Tcl_TranslateFileName rewritten as wrapper around
VFS-aware version. Updated callers.
***POTENTIAL INCOMPATIBILITY***
Includes source incompatibilities: argv arguments of Tcl_Concat,
Tcl_JoinPath, Tcl_OpenCommandChannel, Tcl_Merge; argvPtr arguments of
Tcl_SplitList and Tcl_SplitPath.
|
| |
|
|
|
|
|
|
|
|
|
| |
of TIP 27. Several minor documentation corrections as well.
* Updated channel driver interface according to the guidelines of
TIP 27. See also [Bug 500348].
* Moved Tcl_EolTranslation enum declaration from generic/tcl.h to
generic/tclInt.h (renamed to TclEolTranslation). It is not used
anywhere in Tcl's public interface.
|
| |
|
|
| |
[Patch: 436116]
|
| |
|
|
|
|
|
|
|
|
| |
* win/tclWinPipe.c (BuildCommandLine): Fixed tcl Bug
[432499]. Part of the code used the non-absolute path to the
executable to determine quoting. This failed if the absolute
path cotained spaces, but the application name itselfl not. This
bug caused no trouble on Win NT 5, but does for other variants
in the Win* family. Report and fix due to Ken Poole
<kenpoole@users.sourceforge.net>.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The following files were impacted.
* doc/Access.3:
* doc/FileSystem.3:
* doc/OpenFileChnl.3:
* doc/file.n:
* doc/glob.n:
* generic/tcl.decls:
* generic/tcl.h:
* generic/tclCmdAH.c:
* generic/tclCmdIL.c:
* generic/tclCmdMZ.c:
* generic/tclDate.c:
* generic/tclDecls.h:
* generic/tclEncoding.c:
* generic/tclFCmd.c:
* generic/tclFileName.c:
* generic/tclGetDate.y:
* generic/tclIO.c:
* generic/tclIOCmd.c:
* generic/tclIOUtil.c:
* generic/tclInt.decls:
* generic/tclInt.h:
* generic/tclIntDecls.h:
* generic/tclLoad.c:
* generic/tclStubInit.c:
* generic/tclTest.c:
* generic/tclUtil.c:
* library/init.tcl:
* mac/tclMacFCmd.c:
* mac/tclMacFile.c:
* mac/tclMacInit.c:
* mac/tclMacPort.h:
* mac/tclMacResource.c:
* mac/tclMacTime.c:
* tests/cmdAH.test:
* tests/event.test:
* tests/fCmd.test:
* tests/fileName.test:
* tests/io.test:
* tests/ioCmd.test:
* tests/proc-old.test:
* tests/registry.test:
* tests/unixFCmd.test:
* tests/winDde.test:
* tests/winFCmd.test:
* unix/mkLinks:
* unix/tclUnixFCmd.c:
* unix/tclUnixFile.c:
* unix/tclUnixInit.c:
* unix/tclUnixPipe.c:
* win/tclWinFCmd.c:
* win/tclWinFile.c:
* win/tclWinInit.c:
* win/tclWinPipe.c
|
| |
|
|
| |
just the TerminateThread call and waiting for termination. (jsmith)
|
| |
|
|
|
|
|
|
|
|
| |
* win/tclWinPipe.c:
* win/tclWinPort.h:
* win/tclWinSerial.c:
* win/tclWinThrd.c:
Remove unnecessary #includes of dos.h, direct.h,
and tchar.h. This will help the Cygwin porting
effort since these headers do not exist under Cygwin.
|
| |
|
|
| |
8.4a2 code base, merged in with some existing new 8.4a2 features.
|
| |
|
|
|
|
|
|
| |
Added more logic around the close-down of the pipe reader thread so
as to avoid, at all cost, a TerminateThread. Most cases with exec
are fixed, but I don't consider 2460 done yet. Closing down the
read side of a pipe before the child process, doesn't really fit
the windows model. [BUG: 2460]
|
| |
|
|
| |
to prevent potential memory leaks [Bug: 6041].
|
| |
|
|
|
|
|
|
| |
* win/tclWinInit.c:
* win/tclWinNotify.c:
* win/tclWinPipe.c:
* win/tclWinReg.c:
* win/tclWinThrd.c: Applied patch from [Bug 5794].
|
| |
|
|
| |
*native in TclpCreateTempFile, to supress compiler warnings.
|
| |
|
|
|
|
|
|
| |
contents string from UTF to native encoding [Bug: 4030].
* tests/regexp.test: Added tests for infinite looping in [regexp -all].
* generic/tclCmdMZ.c: Fixed infinite loop bug with [regexp -all] [Bug: 4981].
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* win/tclWinChan.c:
* win/tclWinFCmd.c:
* win/tclWinInit.c:
* win/tclWinPipe.c:
* win/tclWinSock.c: removed all code that supported Win32s. It
was no longer officially supported, and likely didn't work anyway.
* win/makefile.vc: removed 16 bit stuff, cleaned up.
* win/tcl16.rc:
* win/tclWin16.c:
* win/winDumpExts.c: these files have been removed from the
source tree (no longer necessary to build)
* win/aclocal.m4: made it just include tcl.m4
|
| |
|
|
|
|
|
|
|
|
| |
* win/Makefile.in: Fixing launching of 16-bit apps on Win9x from
wish. The command line was primed with tclpip82.dll, but it was
ignored. Fixed that, then fixed the gmake makefile to build
tclpip82.dll as an executable.
* win/tclWinSock.c: Applied small patch to get thread-specific
data after initializing the socket driver.
|
| |
|
|
| |
open issues, this code is a little more stable though.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* generic/tclInt.decls: Added TclWinAddProcess to make it possible
for expect to use Tcl_WaitForPid(). This patch is from Gordon
Chaffee.
* mac/tclMacPort.h:
* win/tclWinInit.c:
* unix/tclUnixPort.h:
* generic/tclAsync.c: Added TclpAsyncMark to fix bug in async
handling on Windows where async events don't wake up the event
loop. This patch comes from Gordon Chaffee.
* generic/tcl.decls: Fixed declarations of reserved slots.
|
| | |
|
| | |
|
| |
|
