From 5bcfdfbedb363aaa3e66ffc61232a83e68a1d46c Mon Sep 17 00:00:00 2001 From: andreas_kupries Date: Thu, 23 Aug 2001 21:15:59 +0000 Subject: 2001-08-23 Andreas Kupries * win/tclWinPipe.c (BuildCommandLine): Fixed tcl Bug [432499]. Part of the code used the non-absolute path to the executable to determine quoting. This failed if the absolute path cotained spaces, but the application name itselfl not. This bug caused no trouble on Win NT 5, but does for other variants in the Win* family. Report and fix due to Ken Poole . --- ChangeLog | 10 ++++++++++ win/tclWinPipe.c | 6 +++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 6d8cbda..bffa486 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,13 @@ +2001-08-23 Andreas Kupries + + * win/tclWinPipe.c (BuildCommandLine): Fixed tcl Bug + [432499]. Part of the code used the non-absolute path to the + executable to determine quoting. This failed if the absolute + path cotained spaces, but the application name itselfl not. This + bug caused no trouble on Win NT 5, but does for other variants + in the Win* family. Report and fix due to Ken Poole + . + 2001-08-23 Jeff Hobbs * unix/configure: diff --git a/win/tclWinPipe.c b/win/tclWinPipe.c index 432d956..578d7eb 100644 --- a/win/tclWinPipe.c +++ b/win/tclWinPipe.c @@ -9,7 +9,7 @@ * See the file "license.terms" for information on usage and redistribution * of this file, and for a DISCLAIMER OF ALL WARRANTIES. * - * RCS: @(#) $Id: tclWinPipe.c,v 1.18 2001/07/31 19:12:08 vincentdarley Exp $ + * RCS: @(#) $Id: tclWinPipe.c,v 1.19 2001/08/23 21:15:59 andreas_kupries Exp $ */ #include "tclWinInt.h" @@ -1549,10 +1549,10 @@ BuildCommandLine( } quote = 0; - if (argv[i][0] == '\0') { + if (arg[0] == '\0') { quote = 1; } else { - for (start = argv[i]; *start != '\0'; start++) { + for (start = arg; *start != '\0'; start++) { if (isspace(*start)) { /* INTL: ISO space. */ quote = 1; break; -- cgit v0.12