From a646385d673df42529a9c5a97493876e9c671d33 Mon Sep 17 00:00:00 2001 From: dgp Date: Mon, 23 Jun 2008 04:18:33 +0000 Subject: * generic/tclPathObj.c: Fixed bug in Tcl_GetTranslatedPath() when operating on the "Special path" variant of the "path" Tcl_ObjType intrep. A full normalization was getting done, in particular, coercing relative paths to absolute, contrary to what the function of producing the "translated path" is supposed to do. [Bug 1972879]. --- ChangeLog | 8 ++++++++ generic/tclPathObj.c | 11 +++++++++-- 2 files changed, 17 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index b4ad340..37cfee2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2008-06-23 Don Porter + + * generic/tclPathObj.c: Fixed bug in Tcl_GetTranslatedPath() when + operating on the "Special path" variant of the "path" Tcl_ObjType + intrep. A full normalization was getting done, in particular, coercing + relative paths to absolute, contrary to what the function of + producing the "translated path" is supposed to do. [Bug 1972879]. + 2008-06-20 Don Porter * changes: Updates for 8.6a1 release. diff --git a/generic/tclPathObj.c b/generic/tclPathObj.c index 80b511e..89fb210 100644 --- a/generic/tclPathObj.c +++ b/generic/tclPathObj.c @@ -10,7 +10,7 @@ * See the file "license.terms" for information on usage and redistribution of * this file, and for a DISCLAIMER OF ALL WARRANTIES. * - * RCS: @(#) $Id: tclPathObj.c,v 1.67 2008/04/27 22:21:31 dkf Exp $ + * RCS: @(#) $Id: tclPathObj.c,v 1.68 2008/06/23 04:18:34 dgp Exp $ */ #include "tclInt.h" @@ -1596,7 +1596,14 @@ Tcl_FSGetTranslatedPath( srcFsPathPtr = PATHOBJ(pathPtr); if (srcFsPathPtr->translatedPathPtr == NULL) { if (PATHFLAGS(pathPtr) != 0) { - retObj = Tcl_FSGetNormalizedPath(interp, pathPtr); + int numBytes; + const char *bytes = Tcl_GetStringFromObj(pathPtr, &numBytes); + Tcl_Obj *copy = Tcl_NewStringObj(bytes, numBytes); + Tcl_IncrRefCount(copy); + retObj = Tcl_FSGetTranslatedPath(interp, copy); + srcFsPathPtr->translatedPathPtr = retObj; + Tcl_IncrRefCount(retObj); + Tcl_DecrRefCount(copy); } else { /* * It is a pure absolute, normalized path object. This is -- cgit v0.12