From bb5c4230ac4a9acd532eae83581c1c64a2137dd1 Mon Sep 17 00:00:00 2001 From: dgp Date: Tue, 19 Apr 2011 16:38:15 +0000 Subject: Reduce internals access in the implementation of [::pkgconfig list]. --- ChangeLog | 5 +++++ generic/tclConfig.c | 11 +++-------- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/ChangeLog b/ChangeLog index d55c35e..ddb6690 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2011-04-19 Don Porter + + * generic/tclConfig.c: Reduce internals access in the implementation + of [::pkgconfig list]. + 2011-04-18 Don Porter * generic/tclCmdIL.c: Use ListRepPtr(.) and other cleanup. diff --git a/generic/tclConfig.c b/generic/tclConfig.c index 2ba1bd2..251868e 100644 --- a/generic/tclConfig.c +++ b/generic/tclConfig.c @@ -273,18 +273,13 @@ QueryConfigObjCmd( } if (n) { - List *listRepPtr = ListRepPtr(listPtr); Tcl_DictSearch s; - Tcl_Obj *key, **vals; - int done, i = 0; - - listRepPtr->elemCount = n; - vals = &listRepPtr->elements; + Tcl_Obj *key; + int done; for (Tcl_DictObjFirst(interp, pkgDict, &s, &key, NULL, &done); !done; Tcl_DictObjNext(&s, &key, NULL, &done)) { - vals[i++] = key; - Tcl_IncrRefCount(key); + Tcl_ListObjAppendElement(NULL, listPtr, key); } } -- cgit v0.12