From 712e8111093149680388ac32ee90b21290554bb3 Mon Sep 17 00:00:00 2001 From: das Date: Tue, 8 Apr 2008 23:16:02 +0000 Subject: * tests/chanio.test (chan-io-53.8,53.9,53.10): fix typo & quoting for * tests/io.test (io-53.8,53.9,53.10): spaces in builddir path --- ChangeLog | 54 ++++++++++++++++++++++++++++-------------------------- tests/chanio.test | 8 ++++---- tests/io.test | 8 ++++---- 3 files changed, 36 insertions(+), 34 deletions(-) diff --git a/ChangeLog b/ChangeLog index f557550..28d7a89 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,31 +1,34 @@ +2008-04-09 Daniel Steffen + + * tests/chanio.test (chan-io-53.8,53.9,53.10): fix typo & quoting for + * tests/io.test (io-53.8,53.9,53.10): spaces in builddir path + 2008-04-07 Andreas Kupries * tests/io.test (io-53.10): Testcase for bi-directionaly fcopy. * tests/chanio.test: * generic/tclIO.c: Additional changes to data structures for fcopy * generic/tclIO.h: and channels to perform proper cleanup in case - of a channel having two background copy operations running as is - now possible. + of a channel having two background copy operations running as is + now possible. * tests/io.test (io-53.10): Testcase for bi-directionaly fcopy. * generic/tclIO.c: Additional changes to data structures for fcopy - and channels to perform proper cleanup in case of a channel - having two background copy operations running as is now - possible. + and channels to perform proper cleanup in case of a channel having + two background copy operations running as is now possible. 2008-04-07 Andreas Kupries * generic/tclIO.c (BUSY_STATE, CheckChannelErrors, - TclCopyChannel): New macro, and the places using it. This change - allows for bi-directional fcopy on channels. [Bug 1350564]. - Thanks to Alexandre Ferrieux - for the patch. + TclCopyChannel): New macro, and the places using it. This change + allows for bi-directional fcopy on channels. [Bug 1350564]. Thanks + to Alexandre Ferrieux for the + patch. 2008-04-07 Reinhard Max - * generic/tclStringObj.c (Tcl_AppendFormatToObj): - Fix [format {% d}] so that it behaves the same way as in 8.4 and - as C's printf(). + * generic/tclStringObj.c (Tcl_AppendFormatToObj): Fix [format {% d}] + so that it behaves the same way as in 8.4 and as C's printf(). * tests/format.test: Add a test for '% d' and '%+d'. 2008-04-05 Kevin B. Kenny @@ -55,23 +58,22 @@ * tests/io.test (io-53.9): Added testcase for [Bug 780533], based * tests/chanio.test: on Alexandre's test script. Also fixed - problem with timer in preceding test, was not canceled properly - in the ok case. + problem with timer in preceding test, was not canceled properly in + the ok case. 2008-04-04 Andreas Kupries * generic/tclIORChan.c (ReflectOutput): Allow zero return from - write when input was zero-length anyway. Otherwise keept it an - error, and separate the message from 'written too much'. + write when input was zero-length anyway. Otherwise keept it an + error, and separate the message from 'written too much'. * tests/ioCmd.test (iocmd-24.6): Testcase updated for changed - message. + message. * generic/tclIORChan.c (ReflectClose): Added missing removal of - the now closed channel from the reflection map. Before we could - crash the system by invoking 'chan postevent' on a closed - reflected channel, dereferencing the dangling pointer in the - map. + the now closed channel from the reflection map. Before we could + crash the system by invoking 'chan postevent' on a closed + reflected channel, dereferencing the dangling pointer in the map. * tests/ioCmd.test (iocmd-31.8): Testcase for the above. @@ -80,15 +82,15 @@ * generic/tclIO.c (CopyData): Applied patch [Bug 1932639] to * tests/io.test: prevent fcopy from calling -command synchronously * tests/chanio.test: the first time. Thanks to Alexandre Ferrieux - for report and patch. + for report and patch. 2008-04-02 Andreas Kupries * generic/tclIO.c (CopyData): Applied patch for the fcopy problem - [Bug 780533], with many thanks to Alexandre Ferrieux - for tracking it down and - providing a solution. Still have to convert his test script into - a proper test case. + [Bug 780533], with many thanks to Alexandre Ferrieux + for tracking it down and + providing a solution. Still have to convert his test script into a + proper test case. 2008-04-01 Andreas Kupries diff --git a/tests/chanio.test b/tests/chanio.test index b4287f5..0526f65 100644 --- a/tests/chanio.test +++ b/tests/chanio.test @@ -13,7 +13,7 @@ # See the file "license.terms" for information on usage and redistribution # of this file, and for a DISCLAIMER OF ALL WARRANTIES. # -# RCS: @(#) $Id: chanio.test,v 1.3.2.5 2008/04/07 22:49:18 andreas_kupries Exp $ +# RCS: @(#) $Id: chanio.test,v 1.3.2.6 2008/04/08 23:16:04 das Exp $ if {[catch {package require tcltest 2}]} { chan puts stderr "Skipping tests in [info script]. tcltest 2 required." @@ -6911,7 +6911,7 @@ test chan-io-53.8 {CopyData: async callback and error handling, Bug 1932639} -se # Run the copy. Should not invoke -command now. chan copy $f $g -size 2 -command ::cmd # Check that -command was not called synchronously - set sbs [file size bar] + set sbs [file size $bar] lappend ::RES [expr {($sbs > 0) ? "sync/FAIL" : "sync/OK"}] $sbs # Now let the async part happen. Should capture the error in cmd # via bgerror. If not break the event loop via timer. @@ -6936,7 +6936,7 @@ test chan-io-53.8 {CopyData: async callback and error handling, Bug 1932639} -se test chan-io-53.9 {CopyData: -size and event interaction, Bug 780533} -setup { set out [makeFile {} out] set err [makeFile {} err] - set pipe [open "|[info nameofexecutable] 2> $err" r+] + set pipe [open "|[list [info nameofexecutable] 2> $err]" r+] chan configure $pipe -translation binary -buffering line chan puts $pipe { chan configure stdout -translation binary -buffering line @@ -6984,7 +6984,7 @@ test chan-io-53.9 {CopyData: -size and event interaction, Bug 780533} -setup { } -result OK test chan-io-53.10 {Bug 1350564, multi-directional fcopy} -setup { set err [makeFile {} err] - set pipe [open "|[info nameofexecutable] 2> $err" r+] + set pipe [open "|[list [info nameofexecutable] 2> $err]" r+] chan configure $pipe -translation binary -buffering line chan puts $pipe { chan configure stderr -buffering line diff --git a/tests/io.test b/tests/io.test index 4b495fa..9d4c45f 100644 --- a/tests/io.test +++ b/tests/io.test @@ -13,7 +13,7 @@ # See the file "license.terms" for information on usage and redistribution # of this file, and for a DISCLAIMER OF ALL WARRANTIES. # -# RCS: @(#) $Id: io.test,v 1.80.2.4 2008/04/07 22:33:30 andreas_kupries Exp $ +# RCS: @(#) $Id: io.test,v 1.80.2.5 2008/04/08 23:16:06 das Exp $ if {[catch {package require tcltest 2}]} { puts stderr "Skipping tests in [info script]. tcltest 2 required." @@ -6911,7 +6911,7 @@ test io-53.8 {CopyData: async callback and error handling, Bug 1932639} -setup { # Run the copy. Should not invoke -command now. fcopy $f $g -size 2 -command ::cmd # Check that -command was not called synchronously - set sbs [file size bar] + set sbs [file size $bar] lappend ::RES [expr {($sbs > 0) ? "sync/FAIL" : "sync/OK"}] $sbs # Now let the async part happen. Should capture the error in cmd # via bgerror. If not break the event loop via timer. @@ -6936,7 +6936,7 @@ test io-53.8 {CopyData: async callback and error handling, Bug 1932639} -setup { test io-53.9 {CopyData: -size and event interaction, Bug 780533} -setup { set out [makeFile {} out] set err [makeFile {} err] - set pipe [open "|[info nameofexecutable] 2> $err" r+] + set pipe [open "|[list [info nameofexecutable] 2> $err]" r+] fconfigure $pipe -translation binary -buffering line puts $pipe { fconfigure stdout -translation binary -buffering line @@ -6983,7 +6983,7 @@ test io-53.9 {CopyData: -size and event interaction, Bug 780533} -setup { } -result OK test io-53.10 {Bug 1350564, multi-directional fcopy} -setup { set err [makeFile {} err] - set pipe [open "|[info nameofexecutable] 2> $err" r+] + set pipe [open "|[list [info nameofexecutable] 2> $err]" r+] fconfigure $pipe -translation binary -buffering line puts $pipe { fconfigure stderr -buffering line -- cgit v0.12