From c9ca13a50c7725c87968a8ce5e2053d23b5bd5cf Mon Sep 17 00:00:00 2001 From: dkf Date: Wed, 7 May 2003 15:26:20 +0000 Subject: Fixed memory leak caused by confusion about string ownership. [Bug 731706] --- ChangeLog | 5 +++++ generic/tclDictObj.c | 8 +++++--- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 8c7f9ec..f3885f4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2003-05-07 Donal K. Fellows + + * generic/tclDictObj.c (DictInfoCmd): Fixed memory leak caused by + confusion about string ownership. [Bug 731706] + 2003-05-05 Don Porter * generic/tclBasic.c: Implementation of TIP 90, which diff --git a/generic/tclDictObj.c b/generic/tclDictObj.c index 3a03e2c..8a9ab53 100644 --- a/generic/tclDictObj.c +++ b/generic/tclDictObj.c @@ -9,7 +9,7 @@ * See the file "license.terms" for information on usage and redistribution * of this file, and for a DISCLAIMER OF ALL WARRANTIES. * - * RCS: @(#) $Id: tclDictObj.c,v 1.9 2003/04/29 08:13:41 dkf Exp $ + * RCS: @(#) $Id: tclDictObj.c,v 1.10 2003/05/07 15:26:27 dkf Exp $ */ #include "tclInt.h" @@ -1648,8 +1648,10 @@ DictInfoCmd(interp, objc, objv) } } dict = (Dict *)dictPtr->internalRep.otherValuePtr; - Tcl_SetObjResult(interp, - Tcl_NewStringObj(Tcl_HashStats(&dict->table), -1)); + /* + * This next cast is actually OK. + */ + Tcl_SetResult(interp, (char *)Tcl_HashStats(&dict->table), TCL_DYNAMIC); return TCL_OK; } -- cgit v0.12