From 9ba4b4f90141907cd56d190574d5b1906fbbe23a Mon Sep 17 00:00:00 2001 From: dgp Date: Wed, 6 Dec 2017 19:57:59 +0000 Subject: [0e4d88b650] Added enough refcounting to stop `make valgrind` complaints about "Invalid read". This is not a complete fix. Things are still broken. A working system of Namespace lifetime management looks like an 8.7 project. --- generic/tclBasic.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/generic/tclBasic.c b/generic/tclBasic.c index acdcf41..79de61e 100644 --- a/generic/tclBasic.c +++ b/generic/tclBasic.c @@ -3112,6 +3112,7 @@ Tcl_DeleteCommandFromToken( * traces. */ + cmdPtr->nsPtr->refCount++; if (cmdPtr->tracePtr != NULL) { CommandTrace *tracePtr; CallCommandTraces(iPtr,cmdPtr,NULL,NULL,TCL_TRACE_DELETE); @@ -3139,6 +3140,7 @@ Tcl_DeleteCommandFromToken( */ TclInvalidateNsCmdLookup(cmdPtr->nsPtr); + TclNsDecrRefCount(cmdPtr->nsPtr); /* * If the command being deleted has a compile function, increment the -- cgit v0.12