From 23817ae8722394a75cbeaa82c6c576933543a2be Mon Sep 17 00:00:00 2001 From: aspect Date: Mon, 13 Feb 2017 12:24:25 +0000 Subject: Tcl_GetWideIntFromObj must fail for values between WIDE_MAX+1 and UWIDE_MAX (bug [96c3f3b47d1]) --- generic/tclObj.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/generic/tclObj.c b/generic/tclObj.c index 5b11071..fe51558 100644 --- a/generic/tclObj.c +++ b/generic/tclObj.c @@ -3089,12 +3089,16 @@ Tcl_GetWideIntFromObj( while (numBytes-- > 0) { value = (value << CHAR_BIT) | *bytes++; } - if (big.sign) { - *wideIntPtr = - (Tcl_WideInt) value; + if ( (!big.sign) && ((Tcl_WideInt)value < 0) ) { + /* signed overflow - fall through to produce an error */ } else { - *wideIntPtr = (Tcl_WideInt) value; + if (big.sign) { + *wideIntPtr = - (Tcl_WideInt) value; + } else { + *wideIntPtr = (Tcl_WideInt) value; + } + return TCL_OK; } - return TCL_OK; } } if (interp != NULL) { -- cgit v0.12