From b136b0307e6b079262352c8541c019519fb34f6e Mon Sep 17 00:00:00 2001 From: dgp Date: Fri, 15 Jul 2016 02:33:11 +0000 Subject: One of the validity checks for the "cmdName" type is to see if the resolved command has been deleted by checking for the CMD_IS_DELETED flag. Only one thing sets this flag -- Tcl_DeleteCommandFromToken(), and every time it sets that flag it also bumps the cmdEpoch of the Command as well. The "cmdName" type is already validating that epoch. It gains nothing to be checking the CMD_IS_DELETED flag too. Eliminated the pointless test. --- generic/tclObj.c | 1 - 1 file changed, 1 deletion(-) diff --git a/generic/tclObj.c b/generic/tclObj.c index 0cd7839..8aaf78e 100644 --- a/generic/tclObj.c +++ b/generic/tclObj.c @@ -4156,7 +4156,6 @@ Tcl_GetCommandFromObj( register Command *cmdPtr = resPtr->cmdPtr; if ((cmdPtr->cmdEpoch == resPtr->cmdEpoch) - && !(cmdPtr->flags & CMD_IS_DELETED) && (interp == cmdPtr->nsPtr->interp) && !(cmdPtr->nsPtr->flags & NS_DYING)) { register Namespace *refNsPtr = (Namespace *) -- cgit v0.12