From 1abf9a46d01a0eb473a42503dce30c45fca080b6 Mon Sep 17 00:00:00 2001 From: dgp Date: Fri, 17 Jun 2011 20:03:24 +0000 Subject: 3062331 Caveat added to comments. --- generic/tclTrace.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/generic/tclTrace.c b/generic/tclTrace.c index 49c57bc..28e6934 100644 --- a/generic/tclTrace.c +++ b/generic/tclTrace.c @@ -2874,6 +2874,16 @@ Tcl_UntraceVar2( * The code below makes it possible to delete traces while traces are * active: it makes sure that the deleted trace won't be processed by * TclCallVarTraces. + * + * Caveat (Bug 3062331): When an unset trace handler on a variable + * tries to delete a different unset trace handler on the same variable, + * the results may be surprising. When variable unset traces fire, the + * traced variable is already gone. So the TclLookupVar() call above + * will not find that variable, and not finding it will never reach here + * to perform the deletion. This means callers of Tcl_UntraceVar*() + * attempting to delete unset traces from within the handler of another + * unset trace have to account for the possibility that their call to + * Tcl_UntraceVar*() is a no-op. */ for (activePtr = iPtr->activeVarTracePtr; activePtr != NULL; -- cgit v0.12