From 72376991f5c43b445f266ab25f73c1c41d6393f0 Mon Sep 17 00:00:00 2001 From: "jan.nijtmans" Date: Mon, 21 Mar 2016 12:03:17 +0000 Subject: (cherry-pick): Fix [d3071887dbc7aeac]: Fix SEGV in Tcl_FinalizeNotifier(). Thanks to hirofumi for both the bug-report and the fix --- unix/tclUnixNotfy.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/unix/tclUnixNotfy.c b/unix/tclUnixNotfy.c index 48ba0cc..1457890 100644 --- a/unix/tclUnixNotfy.c +++ b/unix/tclUnixNotfy.c @@ -433,9 +433,11 @@ Tcl_FinalizeNotifier( "unable to write q to triggerPipe"); } close(triggerPipe); + pthread_mutex_lock(¬ifierMutex); while(triggerPipe != -1) { pthread_cond_wait(¬ifierCV, ¬ifierMutex); } + pthread_mutex_unlock(¬ifierMutex); if (notifierThreadRunning) { int result = pthread_join((pthread_t) notifierThread, NULL); -- cgit v0.12 From fd553241ab33882835ecf6065d61b775c9e2f1b1 Mon Sep 17 00:00:00 2001 From: "jan.nijtmans" Date: Tue, 22 Mar 2016 09:07:44 +0000 Subject: =?UTF-8?q?(cherry-pick):=20Fix=20signed-unsigned-compare=20warnin?= =?UTF-8?q?g=20(reported=20by=20Fran=C3=A7ois=20Vogel=20on=20Windows,=20bu?= =?UTF-8?q?t=20gcc=20can=20trigger=20it=20as=20well)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- generic/tclCompExpr.c | 2 +- generic/tclEnsemble.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/generic/tclCompExpr.c b/generic/tclCompExpr.c index 50edbec..2ffcc68 100644 --- a/generic/tclCompExpr.c +++ b/generic/tclCompExpr.c @@ -666,7 +666,7 @@ ParseExpr( OpNode *newPtr = NULL; do { - if (size <= UINT_MAX/sizeof(OpNode)) { + if (size <= (int)(UINT_MAX/sizeof(OpNode))) { newPtr = attemptckrealloc(nodes, size * sizeof(OpNode)); } } while ((newPtr == NULL) diff --git a/generic/tclEnsemble.c b/generic/tclEnsemble.c index 986a553..6b6a156 100644 --- a/generic/tclEnsemble.c +++ b/generic/tclEnsemble.c @@ -3081,7 +3081,7 @@ TclAttemptCompileProc( int result, i; Tcl_Token *saveTokenPtr = parsePtr->tokenPtr; int savedStackDepth = envPtr->currStackDepth; - unsigned savedCodeNext = envPtr->codeNext - envPtr->codeStart; + int savedCodeNext = envPtr->codeNext - envPtr->codeStart; int savedAuxDataArrayNext = envPtr->auxDataArrayNext; int savedExceptArrayNext = envPtr->exceptArrayNext; #ifdef TCL_COMPILE_DEBUG -- cgit v0.12 From 08da639e50f42d9cb3447401a59db6669748f9a9 Mon Sep 17 00:00:00 2001 From: dgp Date: Tue, 22 Mar 2016 16:38:47 +0000 Subject: Don't compare signed and unsigned. Get types right. --- generic/tclCompile.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/generic/tclCompile.h b/generic/tclCompile.h index b5bfab1..5b747fe 100644 --- a/generic/tclCompile.h +++ b/generic/tclCompile.h @@ -135,7 +135,7 @@ typedef struct ExceptionAux { int numBreakTargets; /* The number of [break]s that want to be * targeted to the place where this loop * exception will be bound to. */ - int *breakTargets; /* The offsets of the INST_JUMP4 instructions + unsigned int *breakTargets; /* The offsets of the INST_JUMP4 instructions * issued by the [break]s that we must * update. Note that resizing a jump (via * TclFixupForwardJump) can cause the contents @@ -145,7 +145,7 @@ typedef struct ExceptionAux { int numContinueTargets; /* The number of [continue]s that want to be * targeted to the place where this loop * exception will be bound to. */ - int *continueTargets; /* The offsets of the INST_JUMP4 instructions + unsigned int *continueTargets; /* The offsets of the INST_JUMP4 instructions * issued by the [continue]s that we must * update. Note that resizing a jump (via * TclFixupForwardJump) can cause the contents -- cgit v0.12 From f0d0319ba6c340e680ec612d980061897bf07b4f Mon Sep 17 00:00:00 2001 From: dgp Date: Tue, 22 Mar 2016 17:08:50 +0000 Subject: More places where unsigned quantities should be decared such. --- generic/tclCompCmdsSZ.c | 2 +- generic/tclCompile.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/generic/tclCompCmdsSZ.c b/generic/tclCompCmdsSZ.c index ef9340e..101edbd 100644 --- a/generic/tclCompCmdsSZ.c +++ b/generic/tclCompCmdsSZ.c @@ -2028,7 +2028,7 @@ IssueSwitchChainedTests( int foundDefault; /* Flag to indicate whether a "default" clause * is present. */ JumpFixup *fixupArray; /* Array of forward-jump fixup records. */ - int *fixupTargetArray; /* Array of places for fixups to point at. */ + unsigned int *fixupTargetArray; /* Array of places for fixups to point at. */ int fixupCount; /* Number of places to fix up. */ int contFixIndex; /* Where the first of the jumps due to a group * of continuation bodies starts, or -1 if diff --git a/generic/tclCompile.h b/generic/tclCompile.h index 5b747fe..d5bc86b 100644 --- a/generic/tclCompile.h +++ b/generic/tclCompile.h @@ -928,7 +928,7 @@ typedef enum { typedef struct JumpFixup { TclJumpType jumpType; /* Indicates the kind of jump. */ - int codeOffset; /* Offset of the first byte of the one-byte + unsigned int codeOffset; /* Offset of the first byte of the one-byte * forward jump's code. */ int cmdIndex; /* Index of the first command after the one * for which the jump was emitted. Used to -- cgit v0.12