From 3204e89f4e57ec3a5ae382db506743fdb6ce3429 Mon Sep 17 00:00:00 2001 From: nijtmans Date: Tue, 11 Nov 2008 21:54:06 +0000 Subject: Eliminate warning: passing arg 4 of `Tcl_SplitList' from incompatible pointer type reverted change from 2008-11-06 (was under the impression that "-Wno-implicit-int" added an extra warning) --- ChangeLog | 8 ++++++++ generic/tclNamesp.c | 12 ++++++------ win/configure | 2 +- win/tcl.m4 | 2 +- 4 files changed, 16 insertions(+), 8 deletions(-) diff --git a/ChangeLog b/ChangeLog index b35f999..d1767bb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2008-10-28 Jan Nijtmans + + * generic/tclNamesp.c: Eliminate warning: passing arg 4 of `Tcl_SplitList' + from incompatible pointer type + * win/tcl.m4: reverted change from 2008-11-06 (was under the impression + that "-Wno-implicit-int" added an extra warning) + * win/configure (regenerated) + 2008-11-10 Andreas Kupries * doc/platform_shell.n: Fixed [Bug 2255235], reported by Ulrich diff --git a/generic/tclNamesp.c b/generic/tclNamesp.c index 10e3fd6..a88d140 100644 --- a/generic/tclNamesp.c +++ b/generic/tclNamesp.c @@ -23,7 +23,7 @@ * See the file "license.terms" for information on usage and redistribution of * this file, and for a DISCLAIMER OF ALL WARRANTIES. * - * RCS: @(#) $Id: tclNamesp.c,v 1.181 2008/11/07 20:10:19 patthoyts Exp $ + * RCS: @(#) $Id: tclNamesp.c,v 1.182 2008/11/11 21:54:06 nijtmans Exp $ */ #include "tclInt.h" @@ -6151,17 +6151,17 @@ TclMakeEnsemble( Tcl_Command ensemble; Tcl_Namespace *ns; Tcl_DString buf; - char **nameParts; + const char **nameParts; const char *cmdname; int i, nameCount = 0, ensembleFlags = 0; /* * Construct the path for the ensemble namespace and create it */ - + Tcl_DStringInit(&buf); Tcl_DStringAppend(&buf, "::tcl", -1); - + if (Tcl_SplitList(NULL, name, &nameCount, &nameParts) != TCL_OK) { Tcl_Panic("invalid ensemble name '%s'", name); } @@ -6170,7 +6170,7 @@ TclMakeEnsemble( Tcl_DStringAppend(&buf, "::", 2); Tcl_DStringAppend(&buf, nameParts[i], -1); } - + ns = Tcl_FindNamespace(interp, Tcl_DStringValue(&buf), NULL, TCL_CREATE_NS_IF_UNKNOWN); if (!ns) { @@ -6181,7 +6181,7 @@ TclMakeEnsemble( /* * Create the named ensemble in the correct namespace */ - + if (nameCount == 1) { ensembleFlags = TCL_ENSEMBLE_PREFIX; cmdname = Tcl_DStringValue(&buf) + 5; diff --git a/win/configure b/win/configure index d627b5e..54c8274 100755 --- a/win/configure +++ b/win/configure @@ -3886,7 +3886,7 @@ echo "$as_me: error: ${CC} does not support the -shared option. CFLAGS_DEBUG=-g CFLAGS_OPTIMIZE="-O2 -fomit-frame-pointer" - CFLAGS_WARNING="-Wall -Wno-implicit-int" + CFLAGS_WARNING="-Wall" LDFLAGS_DEBUG= LDFLAGS_OPTIMIZE= diff --git a/win/tcl.m4 b/win/tcl.m4 index f76fbf8..1a46527 100644 --- a/win/tcl.m4 +++ b/win/tcl.m4 @@ -529,7 +529,7 @@ AC_DEFUN([SC_CONFIG_CFLAGS], [ CFLAGS_DEBUG=-g CFLAGS_OPTIMIZE="-O2 -fomit-frame-pointer" - CFLAGS_WARNING="-Wall -Wno-implicit-int" + CFLAGS_WARNING="-Wall" LDFLAGS_DEBUG= LDFLAGS_OPTIMIZE= -- cgit v0.12