From 198c3c32b977b8c0f383c6951d63edfa8c0b6ac8 Mon Sep 17 00:00:00 2001 From: hobbs Date: Wed, 9 Nov 2005 00:53:05 +0000 Subject: * unix/tclUnixFCmd.c (MAX_READDIR_UNLINK_THRESHOLD): reduce to 130 based on errors seen on OS X 10.3 with lots of links in a dir. [Bug 1034337 followup] --- ChangeLog | 6 ++++++ unix/tclUnixFCmd.c | 6 +++--- 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 037abfd..210ce5a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2005-11-08 Jeff Hobbs + + * unix/tclUnixFCmd.c (MAX_READDIR_UNLINK_THRESHOLD): reduce to 130 + based on errors seen on OS X 10.3 with lots of links in a dir. + [Bug 1034337 followup] + 2005-11-08 Don Porter * tests/expr.test: Portable tests expr-46.13-18 [Bug 1341368] diff --git a/unix/tclUnixFCmd.c b/unix/tclUnixFCmd.c index c600ff3..e9d60ab 100644 --- a/unix/tclUnixFCmd.c +++ b/unix/tclUnixFCmd.c @@ -10,7 +10,7 @@ * See the file "license.terms" for information on usage and redistribution * of this file, and for a DISCLAIMER OF ALL WARRANTIES. * - * RCS: @(#) $Id: tclUnixFCmd.c,v 1.28.2.5 2005/10/07 22:35:03 hobbs Exp $ + * RCS: @(#) $Id: tclUnixFCmd.c,v 1.28.2.6 2005/11/09 00:53:06 hobbs Exp $ * * Portions of this code were derived from NetBSD source code which has * the following copyright notice: @@ -129,14 +129,14 @@ CONST TclFileAttrProcs tclpFileAttrProcs[] = { * a bug that makes readdir return NULL even though some directory entries * have not been processed. The bug afflicts SunOS's readdir when applied to * ufs file systems and Darwin 6.5's (and OSX v.10.3.8's) HFS+. JH found the - * Darwin readdir to reset at 172, so 150 is chosen to be conservative. We + * Darwin readdir to reset at 147, so 130 is chosen to be conservative. We * can't do a general rewind on failure as NFS can create special files that * recreate themselves when you try and delete them. 8.4.8 added a solution * that was affected by a single such NFS file, this solution should not be * affected by less than THRESHOLD such files. [Bug 1034337] */ -#define MAX_READDIR_UNLINK_THRESHOLD 150 +#define MAX_READDIR_UNLINK_THRESHOLD 130 /* * Declarations for local procedures defined in this file: -- cgit v0.12